To: Pavel Roskin <proski@gnu.org>
Cc: Jon Masters <jonathan@jonmasters.org>, Andi Kleen <andi@firstfloor.org>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org,
       Rusty Russell <rusty@rustcorp.com.au>,
       Giridhar Pemmasani <pgiri@yahoo.com>
Subject: Re: ndiswrapper and GPL-only symbols redux
From: Andi Kleen <andi@firstfloor.org>
References: <1201641765.18773.35.camel@dv> <20080129224529.4b8016c3@core>
	<1201651006.23553.8.camel@dv> <p73bq746lml.fsf@bingen.suse.de>
	<20080130050721.GB22444@dallas.jonmasters.org>
	<1201670805.4382.4.camel@rd>
Date: Wed, 30 Jan 2008 07:03:05 +0100
In-Reply-To: <1201670805.4382.4.camel@rd> (Pavel Roskin's message of "Wed\, 30 Jan 2008 00\:26\:45 -0500")
Message-ID: <p734pcv7sva.fsf@bingen.suse.de>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 786
Lines: 24

Pavel Roskin <proski@gnu.org> writes:
>   */
> @@ -162,6 +163,7 @@ const char *print_tainted(void)
>  	if (tainted) {
>  		snprintf(buf, sizeof(buf), "Tainted: %c%c%c%c%c%c%c%c",
>  			tainted & TAINT_PROPRIETARY_MODULE ? 'P' : 'G',
> +			tainted & TAINT_BLOB_WRAPPER ? 'W' : ' ',


Are you sure you don't need to add a new '%c' to the format string too?
I think gcc should have warned.

-Andi

>  			tainted & TAINT_FORCED_MODULE ? 'F' : ' ',
>  			tainted & TAINT_UNSAFE_SMP ? 'S' : ' ',
>  			tainted & TAINT_FORCED_RMMOD ? 'R' : ' ',
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/