Message-ID: <20080130011245.9ns4zafum84ck88k@webmail.spamcop.net>
Date: Wed, 30 Jan 2008 01:12:45 -0500
From: Pavel Roskin <proski@gnu.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jon Masters <jonathan@jonmasters.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
       linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
       Giridhar Pemmasani <pgiri@yahoo.com>
Subject: Re: ndiswrapper and GPL-only symbols redux
References: <1201641765.18773.35.camel@dv> <20080129224529.4b8016c3@core>
	<1201651006.23553.8.camel@dv> <p73bq746lml.fsf@bingen.suse.de>
	<20080130050721.GB22444@dallas.jonmasters.org> <1201670805.4382.4.camel@rd>
	<p734pcv7sva.fsf@bingen.suse.de>
In-Reply-To: <p734pcv7sva.fsf@bingen.suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=ISO-8859-1;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.1.4)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 741
Lines: 24

Quoting Andi Kleen <andi@firstfloor.org>:

> Pavel Roskin <proski@gnu.org> writes:
>>   */
>> @@ -162,6 +163,7 @@ const char *print_tainted(void)
>>  	if (tainted) {
>>  		snprintf(buf, sizeof(buf), "Tainted: %c%c%c%c%c%c%c%c",
>>  			tainted & TAINT_PROPRIETARY_MODULE ? 'P' : 'G',
>> +			tainted & TAINT_BLOB_WRAPPER ? 'W' : ' ',
>
>
> Are you sure you don't need to add a new '%c' to the format string too?
> I think gcc should have warned.

You are right!  Thanks.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/