Received-SPF: pass (google.com: domain of linux-kernel+bounces-172342-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <89d9996e-3414-43f9-82f6-0260a4f49285@intel.com>
Date: Tue, 7 May 2024 16:06:17 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v3 10/17] x86/resctrl: Add data structures for ABMC
 assignment
To: <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1711674410.git.babu.moger@amd.com>
 <c3103dd30bc07070380a01922f66208759afe837.1711674410.git.babu.moger@amd.com>
 <3149b62a-b9a4-49c6-a757-5a0e36df62df@intel.com>
 <b367a6ba-3ff1-4173-bf71-cd7a04bf9882@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <b367a6ba-3ff1-4173-bf71-cd7a04bf9882@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yiszb2ZxSlFSTVpYa0hPM1E2ZlhkQ0EyYnA3RXNFSUc5TE0xbzZFcUVUb1FK?=
 =?utf-8?B?cW9NdVFCNHM2cDVremk3Wng1cVlEb3JRV3pkUisvV1VxdHVBRGErWERLQ1RN?=
 =?utf-8?B?SzRXRWJ3MlFxaXJ0cjZwWEdlcVYxUnpzYlJzZVMyK1hzSnRSODJ0T2RVZ3VQ?=
 =?utf-8?B?OVNtSmVmbHZFdHJxbVo1T3E1NWpmVm0zanFQanRRM0FJWm5xWEplRjZYTXox?=
 =?utf-8?B?L0E3MHVWRjNwZ0lwN0J3bGpCdDRhaUp0VS9OWHdKRm5Na29zdDNWTCt1V245?=
 =?utf-8?B?dytNdzI3TFBoSVFDRWZzRFQ3eWN3ZllOeE9PN0h2NFFPZXQ1Q0c2UzBJUm1F?=
 =?utf-8?B?NFRTMzVkRmhQUERjck9na2dLTjIrOWI5aDBoKzNCLzZ6Y0UzSVhxWmRaQVZP?=
 =?utf-8?B?NHNMa1lCdGRjSzEyUUdJdllabTZjUGNseVE0N1doSE13ekZ1akZsbHllcms4?=
 =?utf-8?B?bDVESzF2MTUwV3QvNTN2ZWV6QVcvL20zM3psYUp5S3lnSlZ0eDZIK29JcHNB?=
 =?utf-8?B?S21LbEhmZlpRNVVSaVdyRkxYankwMHdHVmRSbFdPK0dRbnVHSC8zRTc0MUwx?=
 =?utf-8?B?c0c4WWZjWTFKenYxU1E3WUIxWWpCS0ZoMnV0YncyMWtmQVdybjRuMHZGOGlj?=
 =?utf-8?B?amxKeFFWSUtKN3JRUHB5QklORkEwWEZrVGZyNUlvVWliOVBsUWhvcXNYbGZw?=
 =?utf-8?B?SGJETEJoQTFGYkZqcTZWV1lwRmF4UW8zYzhKdjY1NmlqZ1dteW84TVFBb1BK?=
 =?utf-8?B?YXVNNFNRc2F4VUlrWXZhMTJwbUpFNWFYc1VUR1RFR21aY1QvcVBBS09QWVkr?=
 =?utf-8?B?TG82QjNOSnYzd2dUV3Q0OCtvL0tNU0Z6NDNxQkxDWEdYaHg4QnR0Znd5VE9l?=
 =?utf-8?B?RkxMNXBDZjhYSnpWMUhuc3FCVUhiUzRFTEUxaVZQRjZjOUI0d1JVTU01czAy?=
 =?utf-8?B?MW4waHNMV2lvdVZjM3ZFSkJlVFgyV0JXWUdwb0dnSllQSEhTQUFRSERXa3RY?=
 =?utf-8?B?WjNSTWNvNWlOKzhhTG9tTkg1QktFTlZqaThBRm9WazIyenRRa240ZFAveC9r?=
 =?utf-8?B?ekh3ek9oazdyT2xtUkFWYTMxWFNZMnlhWmxHV3FyWmV3emdzYnVMKzZlVlhF?=
 =?utf-8?B?dmlzTTJhcGZvL0FRSy9ZMXFQTXhZdFZuUnMvRXp2TDljbVQzR2JySjNHUFEv?=
 =?utf-8?B?Ri9sRGVKNm1BbDNBcDJ6aUtSM3Y4ZXhKYXBHcWF6bGx6LzZUTFdhcDluT3Bl?=
 =?utf-8?B?ZjlOQ2t3bHg1V3FhSTY5cGpSclJRcjFjdDNpNWg4Mks3OG03Um4ybFV1MEVX?=
 =?utf-8?B?QzFKc0F4MlNMTEJ5MjUzRFBXM3BBanpoOUlLVmM0dGRRSzNxOWZrUEQ4cHV2?=
 =?utf-8?B?NzZmY08yakw4eG56aTkzelUxSmJ0QlBYODl5R0lUa0JVZUpTL1VkcytuNkll?=
 =?utf-8?B?YTNxNXdHVEVLSkZmQ21sbWc0WDZPTlNmdXN1d2ZKTlRIOTNybnYzL2RoYXda?=
 =?utf-8?B?eCtBa1VnTDFnTStWcUt4UFpBdTBhVTJqWis5SE83VHZscEpSKzhIbHNTTEhi?=
 =?utf-8?B?YnRScmJqakQ3NVRBcVJidmt4U2xRdlp2VUE0WmhhbEpRZjZQdG1BRURqTFRk?=
 =?utf-8?B?Vnh6cG5mQkg3L3lGekM2bVlVOHBrcldzR05Ra2tLY1JsSll6cTRwNzRXMGVm?=
 =?utf-8?B?K2F5VFpMRFh6ZHNJOEpCbkkyR25DRVQ5YjBWMDdoVmhwNyt2RGZsRFk4ajlM?=
 =?utf-8?B?UFV0bSs1SFNUK1BwMi9DUm91dlpCb21tMlg2TVRKbmIyWGQ5cnNpcnMrTjlw?=
 =?utf-8?B?YmtLV1NQbkhZTlI4N2R3UFhnOTZhaU5vOUhQbDZnd0hHeUpSWTlFWHliL2dZ?=
 =?utf-8?B?ckVsbmZpc1V5S0d4a0NCQ3BQK2kvSFBCYkI4VTl2ZGM2QzJHTjBkQm1nM3Y5?=
 =?utf-8?B?N3NCN09zeDVMeXVveXN5WjNEUmhUczBUb1ZRL0NSWHVLZ2x5WnhJN3U0UUs0?=
 =?utf-8?B?eDFuSVlpOVdSbi9GL0d1K3E5QXA0cktrVTdKQ1hyUk55Uk1LOExCZjNUc3V5?=
 =?utf-8?B?ZGI2QjFrTklIa2IwR0sybVF0Z1F1UFhFeEI0czZlK21pR043UGIwc1luKzli?=
 =?utf-8?B?V0hiNE5PWVhyeFhCRVZGaEU0VlFCdlIvbG5rLzhxNGQ1bFZKZ3BIdyszcUYr?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e62cbd91-a4c6-48fb-85a8-08dc6eea4f1e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 23:06:21.0659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zFTy7Qfqn1Ay1q4sTGHFBaL/lu/m5U2tYQLjZgthedFOjlz1sxsHzoEi9k87A/FBxcCicQjXSkA7B63ILYP89OYBQtWz+ISsX/yobonkyls=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4707
X-OriginatorOrg: intel.com

Hi Babu,

On 5/7/2024 1:40 PM, Moger, Babu wrote:
> On 5/3/24 18:32, Reinette Chatre wrote:
>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>> ABMC (Bandwidth Monitoring Event Configuration) counters can be configured
>>> by writing to L3_QOS_ABMC_CFG MSR. When ABMC is enabled, the user can
>>> configure a counter by writing to L3_QOS_ABMC_CFG setting the CfgEn field
>>> while specifying the Bandwidth Source, Bandwidth Types, and Counter
>>> Identifier. Add the MSR definition and individual field definitions.
>>>
>>> MSR L3_QOS_ABMC_CFG (C000_03FDh) definitions.
>>>
>>> ==========================================================================
>>> Bits 	Mnemonic	Description		Access Type   Reset Value
>>> ==========================================================================
>>> 63 	CfgEn 		Configuration Enable 	R/W 		0
>>>
>>> 62 	CtrEn 		Counter Enable 		R/W 		0
>>>
>>> 61:53 	– 		Reserved 		MBZ 		0
>>>
>>> 52:48 	CtrID 		Counter Identifier	R/W		0
>>>
>>> 47 	IsCOS		BwSrc field is a COS	R/W		0
>>> 			(not an RMID)
>>>
>>> 46:44 	–		Reserved		MBZ		0
>>>
>>> 43:32	BwSrc		Bandwidth Source	R/W		0
>>> 			(RMID or COS)
>>>
>>> 31:0	BwType		Bandwidth types to	R/W		0
>>> 			track for this counter
>>> ==========================================================================
>>>
>>> The feature details are documentd in the APM listed below [1].

documentd -> documented

>>> [1] AMD64 Architecture Programmer's Manual Volume 2: System Programming
>>> Publication # 24593 Revision 3.41 section 19.3.3.3 Assignable Bandwidth
>>> Monitoring (ABMC).
>>
>> This changelog is purely a summary of the hardware architecture. I have not come
>> across a clear explanation on how this architecture is intended to be supported
>> by resctrl. When would resctrl need/want to set particular fields? What is
>> the mapping to resctrl?
> 
> Something like this in the changelog?
> 
> ABMC feature provides an option to assign(or pin) an RMID to the
> hardware counter and monitor the bandwidth for a longer duration.

Regarding "a longer duration":
https://lore.kernel.org/lkml/b5e68d85-4bf2-4e55-a9c1-b39cb7d94db6@intel.com/

> 
> Hardware counters can be configured by writing to L3_QOS_ABMC_CFG MSR.
> Configuration is done by setting the CfgEn field while specifying the
> Bandwidth Source(RMID or CLOS), Bandwidth Types, and Counter Identifier.
> 
> Add the configuration register definition.

This still looks to me like a cryptic description of the hardware architecture.
Could you please spell out to me how the above answers each of my questions?

Reinette