Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp177044lqo; Tue, 7 May 2024 16:49:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWlwaOhWIDsh+3BVOCsGf6enPDGhyxrwzcmXXNwUGfAhl8N+FVGXT18gyAY4nslMpC+I6o4HLA1rP/on7gqmI4aF2JT61RT54pzS48EWQ== X-Google-Smtp-Source: AGHT+IHoaB1KT6eVAXQ7rW+Z1bHtIAyhRaR7EJon+u+u5Jng/ErsKFnBYQXTmztmOcEXX1mRu8JX X-Received: by 2002:a05:6a00:6181:b0:6e7:8322:ff8e with SMTP id d2e1a72fcca58-6f49c2bcf1amr1063096b3a.30.1715125749416; Tue, 07 May 2024 16:49:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715125749; cv=pass; d=google.com; s=arc-20160816; b=R2nTgKP4UFWJqseVuMzPy2mEtXecc4a1ZQV6OMadDgDVZodsqh9CNpw0+0AyeznbTz SKCBMupTjgN1rhyExjAtSxK2s9Vc7Sa4uPUB6iIl9XSvB3okTQLI1hNBywCnK9VUt/dG z8zVafYU2uTATtP6A8q9cbozSdhd0Op3MEPDA+AoV5i0B4pTiPN4Nn6sUL6373tjasLr 88Cjchm35kxqA8lXFZWBXFSM6klDO0CEGDlEBc3OFOkU9P3LipnWmCUmDYX+UhttzGJ0 k2ryEPoUw3j7WcNU/G4WUx9Fz8x3YhPEkEvV8oSuIu+EB4iKdsgjhtm788Symk2j6NI7 wV0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=AU8qzrXpoeuK/0DvQ/GuL0pn0ZUApvqyrnXQ5sj19c0=; fh=6oRTMOMqoHzh8rgmvOuQOID8wnoIu9ZHoeoSNI8JEig=; b=oB8j+seVzmgpFjqGt1iMzubX9pcRGd35eIQ/8vrnbJZQ0ovRH2GHQSGeWN5ZhGMSen dA+j4B0XUU+QKQ6a1ukRH/9tTj4Xdw38EhexPxypY/TMo5GAaf1OqpvfgePveNh540o1 Q2a1kQZOj1NkEyWD3o5tUF62wa86os4q3VKmrL4JBSoJKIGo/tfYOOSoJ1U8umffzh06 o9APgNa4XcrYvszWpItanf5mEfIsxsycxn9RaLDYBAGx4hc+ISXYg7GEPL5LmBrH4AFH q5tSlA/wy08R9vcRiHljVv7GfzE12YiajBPQqrmU2LtW9U720KqJXJJgiBeWhoEKcAEz 8e0w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MAMjw2F8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b185-20020a6334c2000000b0061eacd308dbsi9063069pga.301.2024.05.07.16.49.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 16:49:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-172452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MAMjw2F8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A6DEB287434 for ; Tue, 7 May 2024 23:47:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E93581C2301; Tue, 7 May 2024 23:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MAMjw2F8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2D81C0DC0; Tue, 7 May 2024 23:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715123574; cv=none; b=pprbusB9h5XyhLQy3tF/7L8r2G/erfvT7w/0HPRHcscugiJ2gjo+bJDquY1aWj4izC+ikQsGdef8xToLmLWZsRO0nb7ewvSInztf3hZmKna5XlFAK765pXCveTMTlfHHVZ7y5VGEgmzoZgvJJ8aPpve/KSMQ4/CP2+fxjj+GckQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715123574; c=relaxed/simple; bh=3zFSXmcuGLIb480BIJuMGLzc+nUlr8bq1zGtX3DKV/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iYw45YMxW6ymFx0A8n/XrSE15Z8xYpFOgB6gubmo2qnOu7C0DDq/DplhQq+NAR8jM08woH139im0aVHSqn3RspcOFkqfta9wzqdxpeqlt7leCvO89Bb6GIqnDs2HXOTuhPQiGjHvlNcGzuzqyn/MuKBW1dj6HTcboSZi+KrjrWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MAMjw2F8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D925DC4AF17; Tue, 7 May 2024 23:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715123574; bh=3zFSXmcuGLIb480BIJuMGLzc+nUlr8bq1zGtX3DKV/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MAMjw2F8AdxO678RAtc3l42gZvV4Do/rHKMjzGgPDrd7GOeb60663lwy5Na4wamGh R4YAm8RUVI2Wjs1kN3kACLEmh7Z80dt6pR20Fm9+fMYJZMNODJDzCn7/eBU27c8cVH /JfArXXTuihYpdZmKW2UulQ4uihxtxuzqrSisSySteRi8dr98lhyv4abYJBK7gxCtj RTiBKtFgKbWF2cOBORj5vbusvFmd1AmbXQhJmgB8rfXeF3o044H34hB0lgtEyUhGG4 osxdsLuLXZUtyYz/ztBxnf7udTSMlEBMcP61bBvPqar6Cl5H6s9H3XsjK9/BQB2NeP 54kP2Mlz58w2g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pierre-Louis Bossart , Mark Brown , Sasha Levin , support.opensource@diasemi.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 13/25] ASoC: da7219-aad: fix usage of device_get_named_child_node() Date: Tue, 7 May 2024 19:12:00 -0400 Message-ID: <20240507231231.394219-13-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240507231231.394219-1-sashal@kernel.org> References: <20240507231231.394219-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.90 Content-Transfer-Encoding: 8bit From: Pierre-Louis Bossart [ Upstream commit e8a6a5ad73acbafd98e8fd3f0cbf6e379771bb76 ] The documentation for device_get_named_child_node() mentions this important point: " The caller is responsible for calling fwnode_handle_put() on the returned fwnode pointer. " Add fwnode_handle_put() to avoid a leaked reference. Signed-off-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20240426153033.38500-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/da7219-aad.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index c8410769188a0..d613f1074524a 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -638,8 +638,10 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) return NULL; aad_pdata = devm_kzalloc(dev, sizeof(*aad_pdata), GFP_KERNEL); - if (!aad_pdata) + if (!aad_pdata) { + fwnode_handle_put(aad_np); return NULL; + } aad_pdata->irq = i2c->irq; @@ -714,6 +716,8 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) else aad_pdata->adc_1bit_rpt = DA7219_AAD_ADC_1BIT_RPT_1; + fwnode_handle_put(aad_np); + return aad_pdata; } -- 2.43.0