Received-SPF: pass (google.com: domain of linux-kernel+bounces-172514-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 7 May 2024 23:24:25 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	bhelgaas@google.com, dave.hansen@linux.intel.com, x86@kernel.org,
	linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'
Message-ID: <Zjq4KWSh63P6Y_Zg@gallifrey>
References: <ZjjsiO33y08dJLPX@gallifrey>
 <20240506152304.GA1699729@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240506152304.GA1699729@bhelgaas>
User-Agent: Mutt/2.2.12 (2023-09-09)

* Bjorn Helgaas (helgaas@kernel.org) wrote:
> On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> > * Ilpo J?rvinen (ilpo.jarvinen@linux.intel.com) wrote:
> > > On Mon, 6 May 2024, linux@treblig.org wrote:
> > > 
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > 
> > > > This doesn't look like it was ever used.
> > > 
> > > Don't start with "This" but spell what you're talking about out so it 
> > > can be read and understood without shortlog in Subject (or looking into 
> > > the code change).
> > 
> > I'm of course happy to rework that if it helps you, although
> > I thought the subject line was sufficient.
> 
> It's a minor point, to be sure.  The way I think about this is "an
> essay title is not part of the essay itself," so the essay (commit
> log) should make sense all by itself.

OK, modified v2 sent.

Dave

> Bjorn
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/