Received-SPF: pass (google.com: domain of linux-kernel+bounces-172524-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 7 May 2024 19:35:55 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>, mhiramat@kernel.org,
 linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
 mathieu.desnoyers@efficios.com, kernel-team@android.com,
 rdunlap@infradead.org, rppt@kernel.org, david@redhat.com, Shuah Khan
 <shuah@kernel.org>, linux-kselftest@vger.kernel.org, Muhammad Usama Anjum
 <usama.anjum@collabora.com>
Subject: Re: [PATCH v22 5/5] ring-buffer/selftest: Add ring-buffer mapping
 test
Message-ID: <20240507193555.592a1e28@rorschach.local.home>
In-Reply-To: <5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org>
References: <20240430111354.637356-1-vdonnefort@google.com>
	<20240430111354.637356-6-vdonnefort@google.com>
	<5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 3 May 2024 13:12:56 -0600
Shuah Khan <skhan@linuxfoundation.org> wrote:

> On 4/30/24 05:13, Vincent Donnefort wrote:
> > This test maps a ring-buffer and validate the meta-page after reset and
> > after emitting few events.
> >   
> 
> Changelog needs to be imperative - refer to the following:
> 
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> Update the change log and describe what the test does and include
> test output.
> 
> If the test requires root privileges - make sure add a check to skip
> when a normal use runs the test.
> 
> The rest looks good.
> 

Vincent,

Can you address Shuah's concerns. I'm starting to test patches 1-4 so
you only need to send an update to this one, unless of course I find an
issue with one of the others.

Thanks,

-- Steve