Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp183198lqo; Tue, 7 May 2024 17:04:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUWJVEi8Lhzm6ilh0muu3Ube5xQG5KPgj5kqWQ7TmQqNz1Vp+MrPC4xhY7BBgZLwRlS8VOIxAwYKjvBYHXV4msxqjyVj8CQGakhAAoO9g== X-Google-Smtp-Source: AGHT+IHEaM3+hL8FCWqqHEeOQOx256aGPTmq+kVyChu1SLOIT3HEtpDB1kRRdWsqVA/dKN7lxmrs X-Received: by 2002:a17:906:3901:b0:a52:65bd:a19a with SMTP id a640c23a62f3a-a59fb9d6462mr53052566b.57.1715126693222; Tue, 07 May 2024 17:04:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715126693; cv=pass; d=google.com; s=arc-20160816; b=PKW7XDs+CkxZBkPILTstB8FJO5zSoR0iUrk+t0Pj7rP4m/ZT3EkchIxBYSAuPmhadl mtxBP0u8QZej/r3ciHvAxjvDKLtoAylCnsNkevFZHituk2b/zW7rsPInTQkUMUc1jRTe YV+FvTfE3lPW64Pe5IXDLYd0ALQKCpa8qAh4l32kgIZa/Mf49Rs1254TZYdIw/N184Cp rVNr6sJdAl7CiM3W6aS0yb2GSzv/ZjEHfIzX6ZjjLpYL/KNlUKRwqwS1kc/Z+MF66Nd6 8+Gr+EtD9qzgycpTwOS9PUVqe2JU+0NNwEKcm7UnIbYQv1raPoUrjcJCiVkPP8aitON9 rCzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=KMCT/Pd2SkLtHm9bGOpC6cxBwZv8iGj8rlet4Pep/Bk=; fh=wDiucda8OLdYJkcRaD2JFBO8HvMxZ1kjMcCyIdm4EFQ=; b=EU66MBQ9adz+4DpHUPTAvn2G1QD5ZFjUAEwKqC0W3tm62trWCb/Q/lqePf/ID4lsGd mWWrqYUXgfL75FhF0csrzWQT0oPqGkdebJ+xlTLe3+4AYcPl3y0+0D8XN8GnnpygfhJq HLTLw1GnuGFOgugddR6yITUMbnXkFoLMYeepJlZ5TG8g9B3sZoVnr7mnwrnY0gQ6tbZj jXDCzbIn5ACvWGzOsAkRFLVj3Kqn1lT2eNzngwqx/l4GFFY1JuXk05lttZRhkbF+eLgg /0nYW1gyz1/hR9L+gTKEWOTxDdINmAN/V3cU6Pblex/o5sO/wr6GSay605wdMYseAsMk X+ig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-172524-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172524-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gn25-20020a1709070d1900b00a59ed7c7a5fsi1235366ejc.66.2024.05.07.17.04.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 17:04:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-172524-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-172524-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172524-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CDA161F215B2 for ; Wed, 8 May 2024 00:04:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9D01131BB4; Tue, 7 May 2024 23:35:58 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DB3A13174E; Tue, 7 May 2024 23:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715124958; cv=none; b=TWzTtr6wzyuw2K+dvJdHAeZIlqYgEVUThJfnvDHz/jd+R9zSavQb5JeaOJA+gXuT061RKH/uaUO6aNMsSjJJUfBgzQNIoZF1l+9Krq3YZnSNmFKi6CTBJOL+dhgBps8zQbZfE8QUqbJEizmYHovGGjBaBRW7hGi0vMMCjDl6h0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715124958; c=relaxed/simple; bh=gaeDja9fME/KkLtLEpCcfbpv+skEwWy0D4LLH9190n4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Pat2nCg0UeZiUqs8NHH/2VCkGk91QkL1RB1kceF6MpbJ4v4Wa8r62bjnn9COmEvF8LDEM1nxJRlORuhOKQ2g8wezHGMeiI7yQ4BXl1hw+BnG+UZ7r8Fnrf+oyx/cVfxmi3mEfSlqnYUUWOvn1UNFj1rs+f/7M6xzlZ8dXNBKwho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 650B9C2BBFC; Tue, 7 May 2024 23:35:57 +0000 (UTC) Date: Tue, 7 May 2024 19:35:55 -0400 From: Steven Rostedt To: Vincent Donnefort Cc: Shuah Khan , mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, rdunlap@infradead.org, rppt@kernel.org, david@redhat.com, Shuah Khan , linux-kselftest@vger.kernel.org, Muhammad Usama Anjum Subject: Re: [PATCH v22 5/5] ring-buffer/selftest: Add ring-buffer mapping test Message-ID: <20240507193555.592a1e28@rorschach.local.home> In-Reply-To: <5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org> References: <20240430111354.637356-1-vdonnefort@google.com> <20240430111354.637356-6-vdonnefort@google.com> <5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 3 May 2024 13:12:56 -0600 Shuah Khan wrote: > On 4/30/24 05:13, Vincent Donnefort wrote: > > This test maps a ring-buffer and validate the meta-page after reset and > > after emitting few events. > > > > Changelog needs to be imperative - refer to the following: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Update the change log and describe what the test does and include > test output. > > If the test requires root privileges - make sure add a check to skip > when a normal use runs the test. > > The rest looks good. > Vincent, Can you address Shuah's concerns. I'm starting to test patches 1-4 so you only need to send an update to this one, unless of course I find an issue with one of the others. Thanks, -- Steve