Received-SPF: pass (google.com: domain of linux-kernel+bounces-172554-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 7 May 2024 17:19:07 -0700
From: Ashok Raj <ashok.raj@intel.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>
CC: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<platform-driver-x86@vger.kernel.org>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<hdegoede@redhat.com>, <ilpo.jarvinen@linux.intel.com>,
	<tony.luck@intel.com>, <jithu.joseph@intel.com>, Ashok Raj
	<ashok.raj@intel.com>
Subject: Re: [PATCH v2 2/2] platform/x86/intel/ifs: Initialize AMX state for
 the scan test
Message-ID: <ZjrE+6UEhKFFYvBG@a4bf019067fa.jf.intel.com>
References: <20240430212508.105117-1-chang.seok.bae@intel.com>
 <20240507235344.249103-1-chang.seok.bae@intel.com>
 <20240507235344.249103-3-chang.seok.bae@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240507235344.249103-3-chang.seok.bae@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7AQkUiP4ysHqKVoy43/ZSQsisdn6+j/gHDTTYTLmgvNoy7Vqf+F7Dng1VzGO?=
 =?us-ascii?Q?qEVwh7M5YgH+e1nXdTKiCs8m16QSZ8kU/ZozzucwQax69eK6kttfY2Xl9I4i?=
 =?us-ascii?Q?ukIBdPo8nj2eZ1JzzZBsOO5OGHMIP1WiRmWfdZJxem0uBnXbEup/uh2vMDIe?=
 =?us-ascii?Q?Rg/O3IyKpqDaYx0GmgidqxNIo9iw9qybHnU1d7zhAJzpSPZI4KFF5FVsLUbb?=
 =?us-ascii?Q?QdZgPunC47g8NCGbR1NzDknkKVn9QlQEhOFf2VrOY8TdwmLdeAcPAMDDtjbv?=
 =?us-ascii?Q?nbKbQe92ko9dhN4a8ctY2BuVBlcQ+ZUA3s8fBnWdccft8y5/RQH+fsHJ3rbF?=
 =?us-ascii?Q?+LrCtWroXLhnkzmOd3uPhQO9k95YtpQ2NrH4bI5nPkWThcPhW3ZRjIknkNrf?=
 =?us-ascii?Q?cwbJTBG6peL/Z90KWozgmjBr90hj79rrszngEXkhp0VZWMb0BB0v+0VmxGns?=
 =?us-ascii?Q?MxffLnBStZU+82phdM1L6sXiaRmj0Nokh3PfhqNAW0lyce8J8QlJUsggjYmR?=
 =?us-ascii?Q?0Ds9u0UX+W3Rrdi2rLk8ZdbGV2QnVPYJdN2Vds9/8u//eOlqxPHU5q+yxiCk?=
 =?us-ascii?Q?D34xt1U+5ecM5z82naKR6jBsnqVQBl4v4enCJcLGY6uDDadc9C7Vvyz0vLc/?=
 =?us-ascii?Q?UWn4MksYuctQ9ZDGRAGfGdOyAkLEUaDRw7u+IK+LsYRNR7ov2xKoNkW/1Xmv?=
 =?us-ascii?Q?M9BKvnRlZaDrG0ud82aP5CjAyua0ry/8i5+x1O35bgHSxcju8PdS9cHTmYDT?=
 =?us-ascii?Q?GIPmmC2knp9nvuNb33OZd7vNfFj+32Sjz4svjS4hfvo11HX3it+sa8tAhG9Y?=
 =?us-ascii?Q?zkJ3fno9qxdoHKzwwhFUjLikEvB5xCyvQOLnGk1Msgv+k41TglfbFezOu5ML?=
 =?us-ascii?Q?P9sHi3w8EPEKM03pYOb31qeZ6W2Cvm7mc9Xp1vDU8SUXNfVBwUw/Oral4UlY?=
 =?us-ascii?Q?8n3e+04M/OMzPkdChHIoRLopw+dyyIear7aZwfnURYACnnoM3pltBeT31UYX?=
 =?us-ascii?Q?LrtL8mMWbDQNredyUQeSBTVgvUDEBzrO9Vh0kG5O6rYM2G5YdphNzqwMrrDd?=
 =?us-ascii?Q?fdepVFggaJVgkbLwUIK+tbrXUy+WLBNg8bI2391vdDrFWVr/90XrwgZjEk0y?=
 =?us-ascii?Q?5a/9JUhjmrPVN+Ufgm6zz+2fdsMTWCikaup/qpPGTbfXd/0803oL3xDmESqi?=
 =?us-ascii?Q?PjuZCl2wVMeCj5xLI96kXHEtZVSx9xtyRg8NkmRAlVQvCJo+BmljyNhDvFLq?=
 =?us-ascii?Q?yMf0Y98ZYHKLbXYywYQF4S0r3Z3CKTl/3KMXkOBEqEGxpp4HBmypi143iqgb?=
 =?us-ascii?Q?tS3eYSTByTuKEh9wzaUQPHVERn0zs8yMv70peTBPWmMt91AWwAl2nBgb3N7t?=
 =?us-ascii?Q?i0WaGLdQLNlDvf+wj2i1ZlBr3Il490Dzh8UURO0FbQcE5AyO52GKEj0U5hyo?=
 =?us-ascii?Q?0+9GhuR3anCmpBAnn3vIXufyE+9JOd7msfdkzSR0AwZupHy7sdLATqpZpuKN?=
 =?us-ascii?Q?cys4JPYoqM55BjIegevExJ4x4DK02JGo8fWQToKNOucYkj7evz2SBpiBokjW?=
 =?us-ascii?Q?MpqAAbFGkAQQOXb1qP87A9NCIYOP9FgXbf3XE/PI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eb893489-8a97-4ab9-64c5-08dc6ef47bba
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 00:19:10.8506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NF514tTjgMVSyfJFVI6XoUVcq2AP9t9o+Uz6CCjR6zKM4ya5xIQjsIUGxZat4iLXKBb0wkqIbdEsgbE1Sjro/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6096
X-OriginatorOrg: intel.com

On Tue, May 07, 2024 at 04:53:44PM -0700, Bae, Chang Seok wrote:
> In-Field Scan aborts if AMX state is not in initialized state. Use
> kernel_fpu_begin_mask(KFPU_AMX) to ensure AMX state is initialized.
> 
> Introduce custom FPU handling wrappers to ensure compliance with the
> established FPU API semantics. This change follows the EFI case from
> commit b0dc553cfc9d ("x86/fpu: Make the EFI FPU calling convention
> explicit").
> 
> Then, use these wrappers to surround the MSR_ACTIVATE_SCAN write to
> minimize the critical section. To prevent unnecessary delays, invoke
> ifs_fpu_begin() before entering the rendezvous loop.
> 
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
> Reviewed-by: Jithu Joseph <jithu.joseph@intel.com>
> Tested-by: Jithu Joseph <jithu.joseph@intel.com>
> Acked-by: Hans de Goede <hdegoede@redhat.com>

Reviewed-by: Ashok Raj <ashok.raj@intel.com>

for both patches.