Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp194038lqo; Tue, 7 May 2024 17:32:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVirkCipFvBfRzLZs+i5JQuf4giEHzfMPPZJIz0Vl9byJJnFfhfum4jy1S8XlbC82zhM910tuyrGE6HEvZmZ/8Su1im/6F+mzL7KHQxVg== X-Google-Smtp-Source: AGHT+IG4eqH4hiO/HYrlwdXecAtFdlkAf5cCi3DxYTzeX5bpUXlVWnuGn6Ki/fDJIVp6FPIN2OD6 X-Received: by 2002:a17:903:244b:b0:1e2:817b:460a with SMTP id d9443c01a7336-1eeb03a3004mr16181555ad.34.1715128334132; Tue, 07 May 2024 17:32:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715128334; cv=pass; d=google.com; s=arc-20160816; b=ZQqkvLe3Q0HfNaskacjouJnQQHOvihluGG70MpeQx1u6cmfE7PpC1rzgHR3AosZ8AR VxvrGX46EbKZwq9mY7ykrtJRQ3hDAMAJmGdSIpMARfiXuda9Eq6ng3wm1kdDZWhSoOdq 7CCfCcBznx2I0Ew4YVggcKxqLtw3B3VohT+csvowVvJdJj8Zm1lQYtlKqLf2pPTy6gQz hFydN36ruHNfctov6y8FgcPp6kM7+tmwdFYD7OIlpzqkZpDK5YC18XhX0AVIcZRjoxng MY0AR9iztVVUycXe/72GVxnd9NGqD7BiOgdT3pYIYnQ79KoybosTS54o43XJbsE59yw8 ULZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Gz2Eh5Q57ZsPnX+Mm22sVVGe83uwU3MNPViCO2JxFZI=; fh=Jc7t152nnkYUzxZNqYFb3WScjeSLYoEQL7dLYywR3M8=; b=sXZ53EArzvXVe6gDOzPgp72jOaOGRPBZiUyqQ4Q3M9s6sm+bgBqro4ySqX5Z0w3Nio MYdqsQChTWcM2SwGbSkfCYADeiCd/bUs0r5hOHf1fNplnNY6jrtXT/ncmmtlU2ZjiuwP UwjXQcYXy9auRb1N21cF75yxSRInEa6o5a32d4+fvnDYdECvgfjJGcFTYYsIj33xlOwL CSmzD3RiigkEXoakyO0l9DJZzX8XseEyydw8m2tIZqH+x4D4RKSUlK3z+wBJ15262rxZ YSFkfIniiPSWclnN+nktcfiMSeW/+t1HrbwPJYDGI7VcUA7CmyBx+UaWVvp+/N0DAad8 KdkQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j35DM3+W; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172564-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172564-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c9-20020a170903234900b001ecce0112d9si11514998plh.235.2024.05.07.17.32.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 17:32:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-172564-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j35DM3+W; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172564-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172564-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4DB18285014 for ; Wed, 8 May 2024 00:31:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4CA57EC2; Wed, 8 May 2024 00:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j35DM3+W" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7625138B; Wed, 8 May 2024 00:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715128249; cv=none; b=INTYY/MgtpIDeidn5zJkr95loxPGUPeBGdJbEPXXSHDGz7pks5eeYH+MvqPYunB8ZpCEjb4jtQt22dvpNhFls9E6ZUvrsBhTi1d3vdXcVuAuCSakwXCNbp9vn/lhQ3Io1TVQhzIxAVvJgAK1Rt0lW/bU21mfyJaSccLxtXX8rA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715128249; c=relaxed/simple; bh=E+MEqaMI2H1mlAS0yyvf/LG3IxZ91Jzmyg/2JNYYdyk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JA3SwSuLsofCXhwInfC+op10jrM3hp7LMOIVIcrZa9of9iZXGCueQ2EcEAReMAekG2q8Q190FVOSeriaP3oJ5iu1bB+8IQf+NV81bDfOJvOnVxwqdbag7BqNYtPib9kYRbX+RgtXCrdPtk+d7Sfs0vD0gRrFEWE0LYC8mhgmTIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j35DM3+W; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CA4CC2BBFC; Wed, 8 May 2024 00:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715128249; bh=E+MEqaMI2H1mlAS0yyvf/LG3IxZ91Jzmyg/2JNYYdyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j35DM3+WvzaZPDJkrsXvUIYUHjeRcoNpWkUrxKt2msJMe64NGTAW0XXPUOdEKjBEH UoWz9Gme/0BeVU2zCRPmoPOptV5EXwFZswU+wIMHM5BsSJR1yOKwidXubyrCxUGDOD pJs4PvyDmXARw7hUgxObI8NbRih/gjgFJYLxJg18UL5GjXNh4MCe+Ya6yTsLweGXbd 2ZViQpXoCLaisTgpExfTwCFLosFF5BVtCSzetJ60k/9WsCzyK5BndjWrQEvEvKkSwk jh/p7eXchQ772iwCnua2fL0HwlE+PxyL89qMzYaLyV8EQ+OmkCE+zBQAxqGL6Ti7Ln zis/oVjGQpNwA== Date: Tue, 7 May 2024 17:30:47 -0700 From: Jakub Kicinski To: Praveen Kumar Kannoju Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rajesh.sivaramasubramaniom@oracle.com, rama.nichanamatlu@oracle.com, manjunath.b.patil@oracle.com Subject: Re: [PATCH v2] net/sched: adjust device watchdog timer to detect stopped queue at right time Message-ID: <20240507173047.47586a14@kernel.org> In-Reply-To: <20240506135944.7753-1-praveen.kannoju@oracle.com> References: <20240506135944.7753-1-praveen.kannoju@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit LGTM! One nit.. On Mon, 6 May 2024 19:29:44 +0530 Praveen Kumar Kannoju wrote: > + if (time_after(jiffies, (trans_start + dev->watchdog_timeo))) { ^ ^ Would you mind dropping these brackets while you're touching this line? They are unnecessary.