Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp195106lqo; Tue, 7 May 2024 17:35:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVOIkuhEJS3zUdY2JhT0tmg0hbeNNXOTtaQ763FL/ljhnFRiGj05S/tODLEKFwoUdhiCQta48qaJfKDBKf61keaTvuDJOiqh3higVW+5A== X-Google-Smtp-Source: AGHT+IEDJB7EFvO1WBYmwGC9lF3GJMv+2xqHbagnZ/ZKSmThcHmxoiQ3aIPhLR2ARoKyajNGltDF X-Received: by 2002:a62:e509:0:b0:6f3:ebc4:4407 with SMTP id d2e1a72fcca58-6f49c1f1e16mr1338229b3a.4.1715128506598; Tue, 07 May 2024 17:35:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715128506; cv=pass; d=google.com; s=arc-20160816; b=rTzakoVY+GJUaNjQmanIiHhZuwhy96gbkq8vw3LsBFSZLzIDNa4Zd1nGubQmQk4iMi P/JQF+svOdSE0aMQv0TmRmzz3Rvc8mm6F++AgtE0bOojHnGXf66Y9CfydoKbProHxMgc YFjOM792qbLcLQ8tiB32XhnOQTq+hYUbTspbr97JAh/IwqqeB4XxC4U8Vorgjg5IPOFq zNKeMClaCF75hLN69NV6S6V4kXFqthAv+sEAg4548FWalf6r0DrjmkdtjsDUnat9MDS/ RO2Zw7kLtJ8vUenLE2qoPeMKM9vSeWzgvEW02qRylz7QvNtS/WesQ33k+7CKcMV9ofGF ko7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=CObgmXuUR6Pk/ZJMC9nAphuOvnyydyVfsAVC+QAp/Tg=; fh=W/fRjJ/WGkp+RywL+su4SYsqwcUFHQKpocdfATxAC3A=; b=c/KVCroxDvb8PxISyR9QGrnsZfGpN4UPs+7J7gXJvyv5VQZ2DztWsVEsWbiZ397XcH xQ2gfHagXiL2FIGzRQYlpCbUsST7yAdBjasvl+8GHhO63wkxdEg9eGJgCxvnb+X+nFoo A+6QHeS5Zm8klscSw3+jhZ0bO2xzENW47AVFKRt2pd6o13YCtPIFmWM4OMiZ5CPsxU3Q ibOvo/nmaWUhQ7uTEd1vH28APau3tWq80LaIK9ZoTbGjAV/1yZYzOBLDnrPDL8iM9E5Q ThvPnvqgJDvuIl3CJnc3AUZrIIKEfR0ik6/9wJ9kw65UWIlweQoZQMLhIi+lN/e+z9Eo D9Tg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hZxfO6uu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f13-20020a63554d000000b0061afbfee29csi11069014pgm.726.2024.05.07.17.35.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 17:35:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-172566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hZxfO6uu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2E11F284136 for ; Wed, 8 May 2024 00:35:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADDE98BE7; Wed, 8 May 2024 00:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hZxfO6uu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF53C7490; Wed, 8 May 2024 00:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715128488; cv=none; b=JuBDqhimWQdQlESGnPs46GJs/23TLfcuTveess0+l8rQGgwe6oGaa26srL/7sMKla4e3gGucXoYzqTsSUsHWKOwF4hGVm2naBGdCzYs7rxuPEv0CsBMiUh3N/sDABmXf2w2u+eIYMiDuCpkJ46eTKwfkxUSEVQ01tMlR4xTlpk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715128488; c=relaxed/simple; bh=KMjZdINE6p4LPP83BwN/kf1WG3JBITPmf6n2KYAIkwU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NBmIMB8/cOimdoWa4trE5r79vPnDrxV65p2wgcC2ABPlbCGoP/nG121OW2LgC18IoGXRWcMjC/UcwqMw/JdgJdFmmpbMLsNXWw79XTXoXZCVbgu5zCc0OMPU2lg+jes04coP/Sb16l/fYK4pdWTvYMI5aB78B21jZ5LRbLdd8+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hZxfO6uu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5563C4AF63; Wed, 8 May 2024 00:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715128488; bh=KMjZdINE6p4LPP83BwN/kf1WG3JBITPmf6n2KYAIkwU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hZxfO6uuR0sJsZ4maM3E83w8LHyCysvPwHU9Kwn/G06Zbv4L2e/hFTq9GUS5Ai1SV dS2srV0P/M8Wy15kUE5x+9yxIpbJJF9kzZBsOxYvlNG+SPDOb5Te1nRAP26K19I+z1 Egars8UnKppMv4utEWCCS29OKItnDCev17XefLnfZorFryFeFWCrUNtdVCrTR/1OT0 oVq7c/WDtgjsh5sNvDOq/ZIKGWHLgyysT64CGBp1cgL9Ij5Y1z05BX2QU17eSJ3XlA TweCwTcn3bxY24+CITarXvlNVsUhsNTPQo/nnVFfhXRmOB6I8jJVH4L/31eSJGwo8Q AwqETHFwAltDQ== Date: Tue, 7 May 2024 17:34:47 -0700 From: Jakub Kicinski To: Richard Gobert Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, willemdebruijn.kernel@gmail.com, dsahern@kernel.org, alexander.duyck@gmail.com, shuah@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v9 0/3] net: gro: remove network_header use, move p->{flush/flush_id} calculations to L4 Message-ID: <20240507173447.015a03a5@kernel.org> In-Reply-To: <20240507162349.130277-1-richardbgobert@gmail.com> References: <20240507162349.130277-1-richardbgobert@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 7 May 2024 18:23:45 +0200 Richard Gobert wrote: > The cb fields network_offset and inner_network_offset are used instead of > skb->network_header throughout GRO. > > These fields are then leveraged in the next commit to remove flush_id state > from napi_gro_cb, and stateful code in {ipv6,inet}_gro_receive which may be > unnecessarily complicated due to encapsulation support in GRO. These fields > are checked in L4 instead. > > 3rd patch adds tests for different flush_id flows in GRO. Doesn't apply to either tree, please rebase. -- pw-bot: cr