Received-SPF: pass (google.com: domain of linux-kernel+bounces-172585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <aa0bd09d-5b9f-4bb9-ad31-061b0244afc8@intel.com>
Date: Wed, 8 May 2024 09:19:52 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 04/27] x86/fpu/xstate: Introduce
 XFEATURE_MASK_KERNEL_DYNAMIC xfeature set
To: Dave Hansen <dave.hansen@intel.com>, Sean Christopherson
	<seanjc@google.com>
CC: <pbonzini@redhat.com>, <x86@kernel.org>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <peterz@infradead.org>, <chao.gao@intel.com>,
	<rick.p.edgecombe@intel.com>, <mlevitsk@redhat.com>, <john.allen@amd.com>
References: <20240219074733.122080-1-weijiang.yang@intel.com>
 <20240219074733.122080-5-weijiang.yang@intel.com>
 <ZjKNxt1Sq71DI0K8@google.com>
 <893ac578-baaf-4f4f-96ee-e012dfc073a8@intel.com>
 <Zjqx8-ZPyB--6Eys@google.com>
 <1159c4e1-dae6-462a-8e34-6f74be4c83b3@intel.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <1159c4e1-dae6-462a-8e34-6f74be4c83b3@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1NycFg5MGV6NEhWV3BxWW1ZQ290MURPL2IwdCsyK2hYS21obXY1Z0lXVGoy?=
 =?utf-8?B?MG8rS0FUcDB3WVZwbFFXQjBhWFJhSXBsd0xORGJIRmIrM2ZnVVU0R0lLSzhR?=
 =?utf-8?B?ZEExc2NJd1ZVRDNuRytoYldvSkw4T3FPemt4VUpHd040VVhaeFBMcVVzQVNZ?=
 =?utf-8?B?eS8vWkJWc0ptUzgrdjNNenNZNTg2ampMZGsyTXUzeWVvRzBydXJOQ3ozMTky?=
 =?utf-8?B?V05TRVNpUXBHNXVtS3REUnFaeW13eStMTzN1R3NNZE1wWVEvdERWMUNSZ0lv?=
 =?utf-8?B?OXBwWnhnTlY5TUtXS3hzZ0NaMFJDOWtVNUFJdUM2NzJjL3NYcmlWN2RKRE44?=
 =?utf-8?B?dk9qdS91TG55QW5WYmJQT3A0NnJGL0IwS05JYjYvZWZyWkptRTBqMGVxVkdW?=
 =?utf-8?B?S2c1V1VsS1pRdXliaEtId25JU1BVL3JFakVOTEZiVkYrc1d6RXJaZnF3UDNx?=
 =?utf-8?B?eTBnVGwxZ2dldlVzZEpYNE8vUGRCaTFpU2VhckJUbEdvclJNTEV6V0NyQ1BB?=
 =?utf-8?B?SUJyek42WGZ1b0RPdG9UTVZ5Qk9zK0FGSVBKSG9ZZzRvWmM1cnllS0VrNmhQ?=
 =?utf-8?B?MVBKM1VjekxkQlJ5SitNN2szWWZwUWxnVDltaVp2dXFXMS9YT2ZSM3IwVzhX?=
 =?utf-8?B?bE5nYnRKSTdrVG1ZMWRudkpRN2ZhUjVqcW56Q0VGcGRYSDNOcUJOaFZWdzdZ?=
 =?utf-8?B?SzAvbko0eW0vb09PVzFRQ0ttZmJYMTJwSEh0WkErZDl6UHdxRFNWNWVhaWMz?=
 =?utf-8?B?YyswWUZoT1Y0SFp3V3NzbmY0VXNKcnZKQjdYWEZCQWwxTzBSSUREeUFTTmZu?=
 =?utf-8?B?WmtYUXNoWXJJalVuWkNCdHE5YW90YWd5Z1lOM2VHUTRMQXArd0lkM29rLzVX?=
 =?utf-8?B?ZjRBRUlOUkJiTUFSWlhEUjI4bUxKZ2N1Zk1KRm9wNFhaTDc3ZkR4aWhOUW42?=
 =?utf-8?B?SllUR2Y4cFZsTUdSbXhNTms1QTRSWnpWUkprTjlZcGVNeGdWaGFBcmxKckl6?=
 =?utf-8?B?ZHRWa0JJY1RubmJHVmJ2bWpOV0lZa1daSXNlOFlWNityRUs5aU50L0prcFda?=
 =?utf-8?B?Q1RMREp6OXBpOUNjVXFvUGRJNE5YZVFGY1R1a003cXdSbmJGaW5jTGU1NjJN?=
 =?utf-8?B?UElTME5FTmF2TmJMVHhwam5Kem5McWgzRmI2ZWxiZGRpY29NYXZydFYyYWly?=
 =?utf-8?B?ckV1YmFlOGxDaXRYdW1sUmQzcnlIVzAvZEc2VFpxOUVqdFRUS0I2RGtZYWky?=
 =?utf-8?B?TkRwblN2MEhmeUZBRTAvejhYbVdSa0IzUlduRHpGd2IzRUV0bjMzRkRrRlU0?=
 =?utf-8?B?TW5VOWRVVzBuNC9McmdNT2UwSzdqcDlhK0RlSzBXSk16bEtkQkhicXFZQWlv?=
 =?utf-8?B?Mm9HUHVWUktuTUxWOHRQcGcxMzAyWGsvMllGWkNWcEJDU3c4WXh1SGwxbzB3?=
 =?utf-8?B?cFNhWU9ITkZKeE9mS2poclRGWUtKRXdLWDFWTkNlL3JCVXdWSEdJd2g3U1pv?=
 =?utf-8?B?UGh1dmdkNTB2RUI2S3AyQ3cxR1ZUQXQyVVh6U2FpVlkzV3lLamlQdDNocHJa?=
 =?utf-8?B?d0JmVEVWZ0MvSkZzbXRIWWJZRzJ6RUNIU29XYXBuTmk1RWhHZGMzanBQdmZJ?=
 =?utf-8?B?UUVqYm1UUzF6RkNRZGFudDhnLzNpeDk5MmtrY3Npa2RPOFIxTHdLMUpaUFJP?=
 =?utf-8?B?VmhYczllWUVmOXNDc2l5SW9HdDJVeC9HUmlmTjE5VnhILzlNcGZ1TjZ4NFZB?=
 =?utf-8?B?bUVvWloxOENEdDFlWTg0bE9mMGs1RklIK1A1blZ2alIyYkV2ZTFKNTFjOG5k?=
 =?utf-8?B?UFdFSTZqbk8xaGFVUUoxOStCVnJINVFTSW5YSG5ZQjYyeXZLK1U2K25GN0hL?=
 =?utf-8?B?b3V3ZXlXOW14UGh3RjVnQ0dGTmY1MlhzbURHV3hzWG1pcVAxRDJTejE1ZE9Y?=
 =?utf-8?B?YWM3SG96ZEtnQWg2VU85RW5nL2ZOSjRNTm1haktLN3JpaW5pWnB0dUUrYXFF?=
 =?utf-8?B?ZitObFJpaDhJT3pTdDVPc0Y0SllFV2RQWldqVjdvM09GdTRieUludjg1czJw?=
 =?utf-8?B?TnAxV25sNFV5dnF6RE9YRWxEL2xBWEZQMlNiQ2xxY0d0cC82eXVTQUl5MG43?=
 =?utf-8?B?LzR5OE1GRWswOG5CVmZTR1UrbHNtaklsdlJNb0p4eTd5SDVFMXB2em1PN2lw?=
 =?utf-8?B?dHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a835eb2-b423-4544-4afb-08dc6efcfc0f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 01:20:02.4173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fmqAXAK1QvOL7OI+4FMDzWBafmFd7L0VNse+KS9kOdyOLfjaBskqlYelY61efsSHfkbLP9xfUj0E2DnJf6WBVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5127
X-OriginatorOrg: intel.com

On 5/8/2024 7:17 AM, Dave Hansen wrote:
> On 5/7/24 15:57, Sean Christopherson wrote:

[...]

>> My one request would be to change the WARN in os_xsave() to fire on CET_KERNEL,
>> not KERNEL_DYNAMIC, because it's specifically CET_KERNEL that is guest-only.
>> Future dynamic xfeatures could be guest-only, but they could also be dynamic for
>> some completely different reason.  That was my other hang-up with "DYNAMIC";
>> as-is, os_xsave() implies that it really truly is GUEST_ONLY.
>>
>> diff --git a/arch/x86/kernel/fpu/xstate.h b/arch/x86/kernel/fpu/xstate.h
>> index 83ebf1e1cbb4..2a1ff49ccfd5 100644
>> --- a/arch/x86/kernel/fpu/xstate.h
>> +++ b/arch/x86/kernel/fpu/xstate.h
>> @@ -185,8 +185,7 @@ static inline void os_xsave(struct fpstate *fpstate)
>>          WARN_ON_FPU(!alternatives_patched);
>>          xfd_validate_state(fpstate, mask, false);
>>   
>> -       WARN_ON_FPU(!fpstate->is_guest &&
>> -                   (mask & XFEATURE_MASK_KERNEL_DYNAMIC));
>> +       WARN_ON_FPU(!fpstate->is_guest && (mask & XFEATURE_MASK_CET_KERNEL));
>>   
>>          XSTATE_XSAVE(&fpstate->regs.xsave, lmask, hmask, err);
> Yeah, that would make a lot of sense.  We could add a more generic
> #define for it later if another feature gets added like this.

Thank you for getting alignment! I will change the code accordingly.