Received-SPF: pass (google.com: domain of linux-kernel+bounces-172587-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 7 May 2024 21:21:16 -0400
From: Kent Overstreet <kent.overstreet@linux.dev>
To: Edward Adam Davis <eadavis@qq.com>
Cc: bfoster@redhat.com, linux-bcachefs@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, 
	syzbot+c48865e11e7e893ec4ab@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] bcachefs: fix oob in bch2_sb_clean_to_text
Message-ID: <nq3ka3ovvksptfkl5c53c4yn54efhu6dtt356lrda2wg7xzwak@tutbtfe7eskb>
References: <7chwa5h2y2eotafxfnapxn754n7y3zpze2sm5dif3zyx7hkxcc@2zu6pskc7fbo>
 <tencent_CBBB5E331C9E521B014B6C1B9B2576BA8E08@qq.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_CBBB5E331C9E521B014B6C1B9B2576BA8E08@qq.com>

On Wed, May 08, 2024 at 09:11:37AM +0800, Edward Adam Davis wrote:
> On Tue, 7 May 2024 20:59:14 -0400, Kent Overstreet wrote:
> > > > diff --git a/fs/bcachefs/sb-clean.c b/fs/bcachefs/sb-clean.c
> > > > index 35ca3f138de6..194e55b11137 100644
> > > > --- a/fs/bcachefs/sb-clean.c
> > > > +++ b/fs/bcachefs/sb-clean.c
> > > > @@ -278,6 +278,17 @@ static int bch2_sb_clean_validate(struct bch_sb *sb,
> > > >  		return -BCH_ERR_invalid_sb_clean;
> > > >  	}
> > > > 
> > > > +	for (struct jset_entry *entry = clean->start;
> > > > +	     entry != vstruct_end(&clean->field);
> > > > +	     entry = vstruct_next(entry)) {
> > > > +		if ((void *) vstruct_next(entry) > vstruct_end(&clean->field)) {
> > > > +			prt_str(err, "entry type ");
> > > > +			bch2_prt_jset_entry_type(err, le16_to_cpu(entry->type));
> > > > +			prt_str(err, " overruns end of section");
> > > > +			return -BCH_ERR_invalid_sb_clean;
> > > > +		}
> > > > +	}
> > > > +
> > > The original judgment here is sufficient, there is no need to add this section of inspection.
> > 
> > No, we need to be able to print things that failed to validate so that
> > we see what went wrong.
> The follow check work fine, why add above check ?
>    1         if (vstruct_bytes(&clean->field) < sizeof(*clean)) {
>   268                 prt_printf(err, "wrong size (got %zu should be %zu)",
>     1                        vstruct_bytes(&clean->field), sizeof(*clean));
> 

You sure you're not inebriated?