Received-SPF: pass (google.com: domain of linux-kernel+bounces-172656-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <13a313c7-c214-4d49-9029-c79b503c17dd@canonical.com>
In-Reply-To: <13a313c7-c214-4d49-9029-c79b503c17dd@canonical.com>
From: Jason Wang <jasowang@redhat.com>
Date: Wed, 8 May 2024 11:33:53 +0800
Message-ID: <CACGkMEtZEeObDxcVBnvczLFGm1=13=tz_4mJGeXMw+4JgGWRpA@mail.gmail.com>
Subject: Re: [REGRESSION][v6.8-rc1] virtio-pci: Introduce admin virtqueue
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: feliu@nvidia.com, parav@nvidia.com, jiri@nvidia.com, mst@redhat.com, 
	yishaih@nvidia.com, alex.williamson@redhat.com, xuanzhuo@linux.alibaba.com, 
	virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, 
	Francis Ginther <francis.ginther@canonical.com>, John Cabaj <john.cabaj@canonical.com>, 
	Catherine Redfield <catherine.redfield@canonical.com>, 
	Ankush Pathak <ankush.pathak@canonical.com>, Chlo Smith <chloe.smith@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, May 4, 2024 at 2:10=E2=80=AFAM Joseph Salisbury
<joseph.salisbury@canonical.com> wrote:
>
> Hi Feng,
>
> During testing, a kernel bug was identified with the suspend/resume
> functionality on instances running in a public cloud [0].  This bug is a
> regression introduced in v6.8-rc1.  After a kernel bisect, the following
> commit was identified as the cause of the regression:
>
>         fd27ef6b44be  ("virtio-pci: Introduce admin virtqueue")

Have a quick glance at the patch it seems it should not damage the
freeze/restore as it should behave as in the past.

But I found something interesting:

1) assumes 1 admin vq which is not what spec said
2) special function for admin virtqueue during freeze/restore, but it
doesn't do anything special than del_vq()
3) lack real users but I guess e.g the destroy_avq() needs to be
synchronized with the one that is using admin virtqueue

>
> I was hoping to get your feedback, since you are the patch author. Do
> you think gathering any additional data will help diagnose this issue?

Yes, please show us

1) the kernel log here.
2) the features that the device has like
/sys/bus/virtio/devices/virtio0/features

> This commit is depended upon by other virtio commits, so a revert test
> is not really straight forward without reverting all the dependencies.
> Any ideas you have would be greatly appreciated.

Thanks

>
>
> Thanks,
>
> Joe
>
> http://pad.lv/2063315
>