Received-SPF: pass (google.com: domain of linux-kernel+bounces-172682-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <367fc6ac-cad3-4b2b-9456-2859f1bd4be3@intel.com>
Date: Wed, 8 May 2024 07:46:48 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: fix link fluctuations problem
To: Andrew Lunn <andrew@lunn.ch>, En-Wei WU <en-wei.wu@canonical.com>
CC: <jesse.brandeburg@intel.co>, <netdev@vger.kernel.org>,
	<rickywu0421@gmail.com>, <linux-kernel@vger.kernel.org>,
	<edumazet@google.com>, <intel-wired-lan@lists.osuosl.org>, <kuba@kernel.org>,
	<anthony.l.nguyen@intel.com>, <pabeni@redhat.com>, <davem@davemloft.net>,
	"Ruinskiy, Dima" <dima.ruinskiy@intel.com>, "Lifshits, Vitaly"
	<vitaly.lifshits@intel.com>, "Neftin, Sasha" <sasha.neftin@intel.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>, "Keller, Jacob E"
	<jacob.e.keller@intel.com>, "Avivi, Amir" <amir.avivi@intel.com>
References: <20240502091215.13068-1-en-wei.wu@canonical.com>
 <f47e0bb6-fb3f-4d0e-923a-cdb5469b6cbe@lunn.ch>
 <CAMqyJG0kMFShx8Kir17mNZ1rD7SaBt2f_Wpv4ir+5-92v3bNaA@mail.gmail.com>
 <aad721c1-93c4-48bd-9f05-00c4f6301dce@lunn.ch>
Content-Language: en-US
From: Sasha Neftin <sasha.neftin@intel.com>
In-Reply-To: <aad721c1-93c4-48bd-9f05-00c4f6301dce@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1p3ZCswcXIrUGdJRitqOGtPRWpZeUw1cFhXYWpxcGl0SjRnVEJINnhLaGNH?=
 =?utf-8?B?L3h0U1prakJJb1k1cnhjRlF5RkFIdk5lMm85UlMwbEMxWXg4N1hkck1vQVAr?=
 =?utf-8?B?eDViOUZoaksrYXVsSzhJNUpna09FSnF4akJ0ekJQWmVMMG9MWmVmbmVzb0NW?=
 =?utf-8?B?b25FYXdmMGEvc2JjR1ZkN0xERkNKWE5jWWh2ZlhFZjV0NERlUHJLbjI1N1dV?=
 =?utf-8?B?andNMHJDeTE5enVjVitUUjNkTHBiWVQ5RjhpR0gwZ204a2xqOUJVcG5ldEE5?=
 =?utf-8?B?Z3RkcDljcWtYb05hY2V2N24xOEs1QTNGRDM0Q24zOVZIZWxYN2VvUUpBcHFL?=
 =?utf-8?B?Q2J3UmF2V0h0a2pOY3h0V1Jyanc5SUc2WnBySnI2TzU5QmZna0cxMnlxVlAx?=
 =?utf-8?B?eXhKdDZkaGpHZWdidjhDUFF5S0xwbVlwZE1WV0lGazFQZTRvNW4zeXYyMm5W?=
 =?utf-8?B?YjZpOS9JVU9XRW9XK1diallSL2xROUhwSUR1cy84RjRDTlkvL0RBZ3F4a1ZO?=
 =?utf-8?B?TmVBc0NDVXJBSGh6ZDlYVytKNWFLNmtVVktXZm5LMW5OZU9iQWVrQ1lXU0lP?=
 =?utf-8?B?NEpjUW0wV3B1dVE2MG9nWm02UVAvS1V4UldHMUlsTkVNNXBZUVRNYmU1VENC?=
 =?utf-8?B?S0tKc0x3K3ByMU0wOTNlMmR6b004ZzdRbDQ5T0hwMmp3T09XRzlvQnhmT0Fl?=
 =?utf-8?B?YUdJc0xqQ0VLT3ZKbHNIako2dXYreEQ4ZC9vNXJPQ0ZpWUwza0xiK0hRRFdG?=
 =?utf-8?B?dDhvcUJhNmFJUnZ1OEpJKysrWnNEVGxBaDVEUTdYUlRjZWtYdVB3RVRIWjlL?=
 =?utf-8?B?QllTaHpxK3VzMVllNktEZTBOY2lUaG53RUQ0aU5BM0RNOUhmbS8zajJqYzFD?=
 =?utf-8?B?TXBZY3FrU0g3Y0h6K2pMcEEzUWZ1L1daWTREL2tRbmpYaVJaMko4MktqeEJB?=
 =?utf-8?B?Zk1zeG1JSW1VbEl2NmtzaDNUaVlsUEVPYU1tWkVwZDRWeXJweklzY3E0N3l5?=
 =?utf-8?B?UEFnMzVhU3NUaDVvZWMwWUZna0pkRVZmVTBNUGlXT2IxSXA4blRGYzUzT3Jx?=
 =?utf-8?B?UmgxTXpKQ0dyQkNjb3NmN3BrZFA5VmpOQXd6SU94VU9JV0dCR09jRWU0VjdB?=
 =?utf-8?B?eVJvT09HTkV6TmkxaTh6U3B6SVBIeENqZXdIS2JYRUFaTWZzaXJaSE1aODNi?=
 =?utf-8?B?c0UycFUzMTVzY2M4WjRFVDhaakxVd3E1aDZWNktrZjduakZ4SnVnYkpNWHFW?=
 =?utf-8?B?aWtyWDgwNGsyWWhCYXRodEhSSXBzREJPRkoxZS9PQmpydTJPYThBTzBFUWVM?=
 =?utf-8?B?cDJnYnkzMWMvL0J3UlV1Q0VmaVFHVm5CQjNHN1NDaG1rQ1I0RUkwa3E1VWQ0?=
 =?utf-8?B?cWNOc0t5ZWFpMnRYOXJaMU1NMFMxV3NVcFBtUDg4S2dIQlVlK2YrYnpUM0Rk?=
 =?utf-8?B?QjhvTnl6RDRYWGhtY1VtcVQ4MGhjN0FpUzJTbGlzeFRsOHZ2K2N0THdFZ1Jl?=
 =?utf-8?B?Wk1lekpVdUluOGpTa0FCVHFhcVNmeXpCSlFiNXFJV0ZwV25oM09HSHBMN1h1?=
 =?utf-8?B?VUxzR3czdDFJRzFmczVUYkNsb0hNbVl6K00yQ1JUOXM2RFY3VWlZUEpUVyti?=
 =?utf-8?B?cFNEU2JkeFhLUjVkcDc3WFArbmJDZ0czZDRxOGt5SEROMnBUQ2owMzRoNVBk?=
 =?utf-8?B?YmVERGt3dkhEd2hDMEhZaFpuakhucnNaZHZya3hUOGpCdVU4U3IzMmhFcTF6?=
 =?utf-8?B?S1hYall5eExWeG8vck9rSVl5WGx2Vi82UVpYaDFVa3B3UjFWMEcwS0tMMFJU?=
 =?utf-8?B?R24wY1F3d1llaEFPNjMzL2ZXMDRzU3hyaTR5d3hNNDMzSWRBMXpvOWdQaDhK?=
 =?utf-8?B?OFhPSTRUYjVoTUJRRks2TG5GUDhtb2wwelFVZ3NZczVtVVdjQ3ZMWExlVysw?=
 =?utf-8?B?S0JrcUl4OUtZZ3dIZ3hEREJLbUxhczdrck9jcWVBQXNYb1lIYUJldUJ2bWpE?=
 =?utf-8?B?ZmNmZ2NVdTJJUUlIYmNxN2MzSk16ZVhOT3RZUGttaU9hYkdkZ3YzN2ZrNTdv?=
 =?utf-8?B?V1F0Slg5U216cTA1eXFZQjY0VzRqY2JWS1lqZ0QxTzBtTVg3eWlmREJsaFBH?=
 =?utf-8?B?Ynh3NS9WZEYyNWxQZkdQVm1tL2NGdzlhSGJWaUEvWitMM1A3WlRva3NtTWVV?=
 =?utf-8?B?cUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbc00499-3c3a-40db-f433-08dc6f19e3f0
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6738.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 04:46:57.1906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oORfNhVQip2ys8SS271cZZE9KUsHKCoFov+gWbPrBgb5Y33lhGMuokBime3I7n1NDItPyzGTDP6gdrf5/zfNVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6875
X-OriginatorOrg: intel.com

On 07/05/2024 15:10, Andrew Lunn wrote:
> On Tue, May 07, 2024 at 11:24:05AM +0200, En-Wei WU wrote:
>>> Why PHY is this?
>> It's the Intel I219-LM, and I haven't found any other device having
>> the same issue.
> 
> There is no Linux PHY driver for this device, only the code buried in
> the e1000e MAC driver. Sometimes Intel use Marvell PHYs, and there are
> a couple of work arounds in the Marvell PHY driver, which might of
> given you a clue. But not in this case...

In I219-* parts used LSI PHY. This PHY is compliant with the 802.3 IEEE 
standard if I recall correctly. Auto-negotiation and link establishment 
are processed following the IEEE standard and could vary from platform 
to platform but are not violent to the IEEE standard.

En-Wei, My recommendation is not to accept these patches. If you think 
there is a HW/PHY problem - open a ticket on Intel PAE.

Sasha

> 
>        Andrew