Received-SPF: pass (google.com: domain of linux-kernel+bounces-172685-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <dc369d86-2a67-423e-a020-8e7ff58b6029@ti.com>
Date: Wed, 8 May 2024 10:25:57 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/5] arm64: boot: dts: ti: k3-am68-sk-base-board: Add
 LP8733 and TPS6287 nodes
To: Neha Malcom Francis <n-francis@ti.com>, <robh@kernel.org>,
        <conor+dt@kernel.org>, <krzk+dt@kernel.org>, <kristo@kernel.org>,
        <vigneshr@ti.com>, <nm@ti.com>, <broonie@kernel.org>,
        <lgirdwood@gmail.com>
CC: <marten.lindahl@axis.com>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240507122158.3739291-1-n-francis@ti.com>
 <20240507122158.3739291-4-n-francis@ti.com>
Content-Language: en-US
From: "Kumar, Udit" <u-kumar1@ti.com>
In-Reply-To: <20240507122158.3739291-4-n-francis@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hi Neha

On 5/7/2024 5:51 PM, Neha Malcom Francis wrote:
> Add DTS node for LP87334E PMIC and two TPS6287x high current buck
> converters.
>
> LP87334E is responsible for supplying power to the MCU and MAIN domains
> as well as to LPDDR4. The two TPS6287x supply power to the MAIN
> domain for AVS and other core supplies.
>
> Signed-off-by: Neha Malcom Francis <n-francis@ti.com>
> Link: https://www.ti.com/lit/pdf/slda060
> ---
> [..]
> +	tps62873b: tps62873@43 {
> +		compatible = "ti,tps6287x";
> +		bootph-pre-ram;

I think,  we don;t need bootph-pre-ram for fixed regulator,

Please check once, if really bootph-pre-ram needed here


> +		reg = <0x43>;
> +		regulator-name = "VDD_CORE_0V8";
> +		regulator-min-microvolt = <800000>;
> +		regulator-max-microvolt = <800000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +};
> +
>   &mcu_uart0 {
>   	status = "okay";
>   	pinctrl-names = "default";