Received-SPF: pass (google.com: domain of linux-kernel+bounces-172689-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <514e990b-50c6-419b-96f2-09c3d04a2fda@intel.com>
Date: Wed, 8 May 2024 08:05:29 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations
 problem
To: Andrew Lunn <andrew@lunn.ch>, Ricky Wu <en-wei.wu@canonical.com>
CC: <netdev@vger.kernel.org>, <rickywu0421@gmail.com>,
	<linux-kernel@vger.kernel.org>, <edumazet@google.com>,
	<intel-wired-lan@lists.osuosl.org>, <kuba@kernel.org>,
	<anthony.l.nguyen@intel.com>, <pabeni@redhat.com>, <davem@davemloft.net>,
	"Ruinskiy, Dima" <dima.ruinskiy@intel.com>, "Lifshits, Vitaly"
	<vitaly.lifshits@intel.com>, naamax.meir <naamax.meir@linux.intel.com>,
	"Avivi, Amir" <amir.avivi@intel.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@intel.com>, "Keller, Jacob E" <jacob.e.keller@intel.com>
References: <20240503101836.32755-1-en-wei.wu@canonical.com>
 <83a2c15e-12ef-4a33-a1f1-8801acb78724@lunn.ch>
Content-Language: en-US
From: Sasha Neftin <sasha.neftin@intel.com>
In-Reply-To: <83a2c15e-12ef-4a33-a1f1-8801acb78724@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elFjY3lxeEQyamRzNnFyTlVmbXpDSE1ESFFxeEREN1ZFRElyUXJGR2x5NFNl?=
 =?utf-8?B?eEFKVUJsVUVxcEdvTEJhVTRvc1RQdURxeXZNNE9IdTJ3NmZRVU9peE9vM3Ry?=
 =?utf-8?B?VHhrSUhvOWVJcmhEaWsxam4zZ1Y5ZjUzQXcvNm5lUFJDOTNsUmRkSkl2dkhS?=
 =?utf-8?B?M2JiVHFOcDg0OWsrK2gyTGpWZTVISFZvRXRHbkV5WnczS1Z5SWVBVEg5Z3BI?=
 =?utf-8?B?bFliVWxXd2gyZHAyVzhUTzE0OWNHWDFoMHZaaERCdWlDK1J4dzh0bERIMDZU?=
 =?utf-8?B?cnE0ZXVTSDZkZUlodnB0Y1pQbVpZeWw0RXhiN2NJNSt1dDlXeldvSmp0N3VL?=
 =?utf-8?B?K0plTHhqUEpzVFZlR2E5Mng3VW1mMkNzclgxaUJRQVpDNXF3M2xiNzNaZU1m?=
 =?utf-8?B?Ykswc3JGeGkvZUtqOEdpZzgwT1J6Ti82ZzRNc0hxNzF3ZWwxcGozZUlmeG1n?=
 =?utf-8?B?ZjlJMXowUUpsSE5NYzZZRThCY1FQZGNKU1RYWkExRkI2bHV1dUhFeWRDcDA5?=
 =?utf-8?B?VnBDZFhZN0krZnl0ZVg2c1B1N3Nab2QrbE1kVzk2U0ZEb0swUURJT2pCbUJ0?=
 =?utf-8?B?MWRwQXpxYzZxb28xZWxrbXlzRmJvSHZnblRhQjJZTzBMY3ZMYmxDc1RldHB1?=
 =?utf-8?B?ak1PVHovQjN0Tm1BNWt3QVl0SGg2VFgwckR5dlI3SHZ6YXBUamRkWEp5bFA5?=
 =?utf-8?B?TStWSjlBQ0pTOE1vbExYNDhtemJ0ZkdPckRBYUdENjBocGhNcHY5N2VsWHZ0?=
 =?utf-8?B?RTUrenp1M2p1ZFNGUFVuM0FVdzFvdFJmenhkVGluTG1EcWJsdTl4cURwY0Jl?=
 =?utf-8?B?aElqdmJ6TmpkdUw0SzZRSmpPTkpHVGlXbERCc3d4UVNjUDdxS0l0dndwSCtY?=
 =?utf-8?B?Q1lBSHVyUzBscnMyMk9vSmY5ZFFUZnduZnVhbzZhbitTWldDRTZyRUJWRWI3?=
 =?utf-8?B?dlpqTmdFTkhIMGcxZkhvMEhqUDh5VXVNVG9aeTJMV2hQNFcwcjBDTVNPV1da?=
 =?utf-8?B?WmdVTFFHbXd5cEROWGFUQzRlNEgrK1R6ZU9tMGNHeWR4SENhUDVkUk1FZkgz?=
 =?utf-8?B?ZHJhdE5NeGhEV0x4eVZuYXJhdC9JMWtZRWNpdVFtUXRqMVJhZFlvQnk4Mkx4?=
 =?utf-8?B?Unh0NkkrNnpBRk1XSENLN0pScnFwOXNuaTliYklpdUpETmpDci9YSEtBTHRh?=
 =?utf-8?B?OVp0OTNVTXRiZDQ3dWVpeEtSVy9uQkZWRDNXaktIWkVPRkZ1K0oyQU0zM2x4?=
 =?utf-8?B?ZTBlK2QzSWNFaGNScGIwdHFucFZCL2drMCswNXJpMUZ2eUgvUEgrc0d1ekhi?=
 =?utf-8?B?QWc2dkxwUWl0Z3RHb2x4NDR1MHdBV3AwRnVMejlkcGthMzdHNWkxUjdFQXN1?=
 =?utf-8?B?VHpDVTZtbXhqU1RzdmM0V3lPYlh5U3VqaWJ2cjUxSllSY0dJMkRxTGgzZmdq?=
 =?utf-8?B?TklITWdTby9XUjB4QURuZHNCTVQ5MjZZeHdGcC9zQll1RHJmSkVEM0cxNGdv?=
 =?utf-8?B?L1hZMldKODA5YjI0VmVwUDExTkdwRnNEWnZqcTJMbkdqeU1TeG9heDBHQUhy?=
 =?utf-8?B?b2N2SzltTzFzMVYyYmFpS2dlRXpYamt0SjVmdVEzU3U3RkMxcFBydGJBV1Zt?=
 =?utf-8?B?MVBob3dxN0JsTDhWbHZjN1dyTXlTVzdkTmhaOUNQNU1SaHN1dEx4bDBkaGc0?=
 =?utf-8?B?L1BjRmlaZlErSWtOZnhId00wS1E0a0RmQmsvMFpwWndBdGxDWXdLS2Zpalp2?=
 =?utf-8?B?ZkNtUmUxaGsrcThjdkVTUVBUcnl4czJuTytQM1Y3NmZ2cHYrVVVuUzhONXp4?=
 =?utf-8?B?L0dzc0VpazRJeUJpM0hEVWpXK09hTkU3OVdDVmZ0cDdPYzd0LzNPY3RxcVEz?=
 =?utf-8?B?RXVWSlp0dmpyNTJ0SS9iNmR1VTNaZjVnbFZJVnlOZEVBQ2diclN6aDhiUEdo?=
 =?utf-8?B?OEdYQ25uUTZXeUtRbFA4TytOMDI3dDdZVXVkdkREK016cXg2aTBzQ0FiYTYz?=
 =?utf-8?B?M0ViS0tvcjUrQ2JMeVE3YlVrMXFheGZaQ1RzNW8raUhxT0NHYzYvVlJPNDZX?=
 =?utf-8?B?dVFabVVOUkh2VFg1a1lBakEyaTJCM25HRWRwTXlhTGJzRUJIUjVyekNEa0h4?=
 =?utf-8?B?dzJXS3dZTG1kcXAvSVVKcnZXUnhHL2hGbGRNZUpUczlxOTdZK1VaTndjNlha?=
 =?utf-8?B?RHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 24ce0f5b-be3c-45bc-48e1-08dc6f1c7fd2
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6738.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 05:05:37.7112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c4MZr6igQqkhMIuA4d51SZhUwWl+CECVIeZU2mWBSH+k/nM6maqabJ8cezo2i1U7emdE9OaBJUOK1vojgfKg5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5249
X-OriginatorOrg: intel.com

On 07/05/2024 15:31, Andrew Lunn wrote:
> On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote:
>> As described in https://bugzilla.kernel.org/show_bug.cgi?id=218642,
>> Intel I219-LM reports link up -> link down -> link up after hot-plugging
>> the Ethernet cable.
> 
> Please could you quote some parts of 802.3 which state this is a
> problem. How is this breaking the standard.
> 
> 	Andrew

In I219-* parts used LSI PHY. This PHY is compliant with the 802.3 IEEE 
standard if I recall correctly. Auto-negotiation and link establishment 
are processed following the IEEE standard and could vary from platform 
to platform but are not violent to the IEEE standard.

En-Wei, My recommendation is not to accept these patches. If you think 
there is a HW/PHY problem - open a ticket on Intel PAE.

Sasha