Received-SPF: pass (google.com: domain of linux-kernel+bounces-172864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 8 May 2024 10:55:07 +0300 (EEST)
To: "Dr. David Alan Gilbert" <linux@treblig.org>
cc: bhelgaas@google.com, dave.hansen@linux.intel.com, x86@kernel.org, 
    linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op'
In-Reply-To: <20240507232348.46677-1-linux@treblig.org>
Message-ID: <8a3efad2-8e65-5ba4-573c-4fb041bf675b@linux.intel.com>
References: <20240507232348.46677-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-1989487649-1715154864=:3164"
Content-ID: <cab851e2-067e-3290-0970-8adbffef36a3@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1989487649-1715154864=:3164
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <4773f2f7-b4b1-5e0f-d133-313ae9fbffb4@linux.intel.com>

On Wed, 8 May 2024, linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>=20
> struct 'sim_reg_op' doesn't look like it was ever used.
> Remove it.
>=20
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  arch/x86/pci/ce4100.c | 6 ------
>  1 file changed, 6 deletions(-)
>=20
> diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> index 87313701f069e..f5dbd25651e0f 100644
> --- a/arch/x86/pci/ce4100.c
> +++ b/arch/x86/pci/ce4100.c
> @@ -35,12 +35,6 @@ struct sim_dev_reg {
>  =09struct sim_reg sim_reg;
>  };
> =20
> -struct sim_reg_op {
> -=09void (*init)(struct sim_dev_reg *reg);
> -=09void (*read)(struct sim_dev_reg *reg, u32 value);
> -=09void (*write)(struct sim_dev_reg *reg, u32 value);
> -};
> -

Thanks.

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.
--8323328-1989487649-1715154864=:3164--