Received-SPF: pass (google.com: domain of linux-kernel+bounces-172907-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 8 May 2024 10:24:38 +0200
From: Borislav Petkov <bp@alien8.de>
To: Oliver Sang <oliver.sang@intel.com>,
	Sean Christopherson <seanjc@google.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org,
	x86@kernel.org, Ingo Molnar <mingo@kernel.org>,
	Srikanth Aithal <sraithal@amd.com>, fengwei.yin@intel.com,
	yujie.liu@intel.com
Subject: Re: [tip:x86/alternatives] [x86/alternatives] ee8962082a:
 WARNING:at_arch/x86/kernel/cpu/cpuid-deps.c:#do_clear_cpu_cap
Message-ID: <20240508082438.GBZjs2xsn4diYXU4ud@fat_crate.local>
References: <20240430193211.GEZjFHO0ayDXtgvbE7@fat_crate.local>
 <ZjFLpkgI3Zl4dsXs@google.com>
 <20240430223305.GFZjFxoSha7S5BYbIu@fat_crate.local>
 <20240504124822.GAZjYulrGPPX_4w4zK@fat_crate.local>
 <ZjiCJz4myN2DLnZ5@xsang-OptiPlex-9020>
 <Zjj3Lrv2NNHLEzzk@google.com>
 <20240506155759.GOZjj-B_Qrz4DCXwmb@fat_crate.local>
 <ZjnTW4XQwVHEiSaW@xsang-OptiPlex-9020>
 <20240507114814.GBZjoU_u5kYBhLips3@fat_crate.local>
 <Zjsy8v0pZHPMkjPY@xsang-OptiPlex-9020>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Zjsy8v0pZHPMkjPY@xsang-OptiPlex-9020>

On Wed, May 08, 2024 at 04:08:18PM +0800, Oliver Sang wrote:
> we really don't do any manual change recently, however, per your reminding,
> we rerun tests on both ee8962082a and its parent v6.9-rc3 again.
> 
> while we made original report, we always saw below for both commits.
> "x86/cpu: VMX (outside TXT) disabled by BIOS"
> 
> by rerun today, we cannot see it again, on both commits.

Yeah, from the last dump you shouldn't be seeing it.

> then for ee8962082a, the reported
>   WARNING:at_arch/x86/kernel/cpu/cpuid-deps.c:#do_clear_cpu_cap
> disappeared also while no "x86/cpu: VMX (outside TXT) disabled by BIOS"

Yeah, it does feel like something underneath the OS has changed/is
changing for this to happen.

> we are using kexec to boot into kernel, and the kernel images keep same,
> so we are sure this strage phenomenon is not caused by kernel build.

Hmm, kexec won't go through BIOS so I can imagine if the kernel has left
FEAT_CTL in some weird state... but then if it has been locked, nothing
should change it anymore.

> now we doubt it's really a bios issue, we found another similar machine,
> which also show "x86/cpu: VMX (outside TXT) disabled by BIOS", but after
> several rounds of cold reboot, the message disappeared, too.

If you see that again, please run my branch with the debug patch - that
should at least tell us what's weird in FEAT_CTL.

> we will investigate this BIOS further and avoid this kind of misleading
> report in the future.
> 
> sorry again :(

No worries, thanks for testing kernels and thanks Sean too. :-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette