Received-SPF: pass (google.com: domain of linux-kernel+bounces-172903-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <CABOYnLwAe+hVUNe+bsYeKJJQ-G9svs7dR2ymZDh0PsfqFNMm2A@mail.gmail.com>
 <2625b40f-b6c5-2359-33fe-5c81e9a925a9@huaweicloud.com>
In-Reply-To: <2625b40f-b6c5-2359-33fe-5c81e9a925a9@huaweicloud.com>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Wed, 8 May 2024 10:21:14 +0200
Message-ID: <CAJfpegvGhtLSxOHUQQ95a3skqEgEPt+MzpBT8vOOdqWcRxPR5Q@mail.gmail.com>
Subject: Re: WARNING in fuse_request_end
To: Hou Tao <houtao@huaweicloud.com>
Cc: lee bruce <xrivendell7@gmail.com>, linux-fsdevel@vger.kernel.org, 
	yue sun <samsun1006219@gmail.com>, linux-kernel@vger.kernel.org, 
	syzkaller@googlegroups.com
Content-Type: text/plain; charset="UTF-8"

On Tue, 7 May 2024 at 15:30, Hou Tao <houtao@huaweicloud.com> wrote:

> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 3ec8bb5e68ff5..840cefdf24e26 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -1814,6 +1814,7 @@ static void fuse_resend(struct fuse_conn *fc)
>
>         list_for_each_entry_safe(req, next, &to_queue, list) {
>                 __set_bit(FR_PENDING, &req->flags);
> +               clear_bit(FR_SENT, &req->flags);
>                 /* mark the request as resend request */
>                 req->in.h.unique |= FUSE_UNIQUE_RESEND;
>         }
>

ACK, fix looks good.

Would you mind resending it as a proper patch?

Thanks,
Miklos