Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp353876lqo; Wed, 8 May 2024 01:34:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW9caftMQvuFZLf+WmOzuaLz8wDrD93QshN3pAVO2O/GEqrDWJwTgd8ujDOV+quZdFZzBlrfYilNRxyawGbrUPdDBuHS8yh0sgGOfXxaQ== X-Google-Smtp-Source: AGHT+IHqLLFP6TSqdcPHSNunlZmWDe/n1pQYWNDz69WtfygRoHKsKhZxqsFlc5OO8S+gpmHU22vQ X-Received: by 2002:a05:6e02:18c9:b0:36a:199f:345e with SMTP id e9e14a558f8ab-36caecd67f2mr21900625ab.7.1715157259953; Wed, 08 May 2024 01:34:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715157259; cv=pass; d=google.com; s=arc-20160816; b=ZxNmcAggKmxz7yxVhg20BO6HPupIwB3jcdtelaRETS3/VK2j1CpCfPNWnDFLQGGPt2 IvyEZ29ydBC3fhs/n5jaAqZb3LASaLmbMw9cf/e/xV3Po1xlDIkUBy8oYoVDAbmFA0S2 2J50filZgXz62MGiKWGgbgMxzIVh609zo29GTpB/9jyw1yPxuZRy4VyQGEzZ0vXnT63D c8Gy0KCCLQDX3q2NgpMJePjd7Rp3xA9eLvcV5WdaChKKjSY24ACodT3CNIpt9u/l4Sgr FWm4EYWJVfEDV6AcUe+mSe0nz5wENF6oLqNzpNbt4LW4FaaMQD6hw46Sq8QOOhAwkIoF wklw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=KdH49O0cAgoNSOuWczucbNczC7ApQHsjG59jww0LLZo=; fh=358nmBdzlBefYP6/rnzQCE3GLyiYdFWBZlidHwDLFgE=; b=n9m1+vKZsCRLW6FNRB3v3Dyig/Ry7nHofZoj/iNANgRVYJFdBH0EkyMnhBEQ8JhG9t FpHvjlgj1CReL+peqvEU6Q3Z5U83lr90aDTDK4GnCBnfwK8SbAf74EIBmsr9WLTDj2zt bVV/1LegRV2XxI8XyNpilF5paHVuO6QK8OuzRYuuZ9MNkuFe/cncpUepclsTDLLB5LVO IrVLFV5ph9PUwvq7VVTagkZZVEmXgaP4emDwJWz6zyCbrABPcvapTkTbXyvXY5Rn1dU5 4Z9pssCUyT4s1NcpbtZbL+2pz+tmkrG/yxvkatgWPC0b2lvxSevX6iP70uNIv1KOOYKx FMow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YVmlE9ma; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-172909-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172909-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o13-20020a635d4d000000b0062297fb5451si7426097pgm.423.2024.05.08.01.34.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 01:34:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-172909-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YVmlE9ma; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-172909-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172909-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 73A50286337 for ; Wed, 8 May 2024 08:25:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BA32F47F6C; Wed, 8 May 2024 08:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YVmlE9ma" Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29AD53DB97 for ; Wed, 8 May 2024 08:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715156739; cv=none; b=hlxrl7c3NfhdY7yx/nVM9xRQGIPWRNiBOeWEr22aafeBnx5rTe1DcwK1W7FxUXzuCjxTL+knEqm9OQjR43ZVslO1XrIO8IrdTrgq/tEr5fs2bpCXnV6PnChQrzTquSd1MVw5mp2ZVeYROsxvwXvOgKjSvLZozuKMuI15OeWszyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715156739; c=relaxed/simple; bh=yR3XoFNf5Y4X3lhAQdk0Tm3X5mQiV+Ctsnm7TSM1xM0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bL+075n9lmRq5p7/FURvhXBqDm/0Wv5bny0IOqPtrWKZgt2KMvrFQyV2IpQDQrzxaiR5KWCHgxHj8nK4secxyTBwOh9oPI8H3KjTbk20s980W4ViQhROGTdqzoptt8j6XUdBbgNfLCEwosWGMet50f4TEhrCiwU7RFpD1VEl/v8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YVmlE9ma; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a59c04839caso907492466b.2 for ; Wed, 08 May 2024 01:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715156736; x=1715761536; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=KdH49O0cAgoNSOuWczucbNczC7ApQHsjG59jww0LLZo=; b=YVmlE9mazTTz3qYoJTUBK6cBrWayKSPqgcE29/MgOxuiOFHiCqBvHPpSHdXA1HAZPX i9wuriAb11EHGJ6e1z40egeaiFCIc6nxG1tESwcPnb0UIVJ0swgkP+KvgcZ2OZP/Bgp0 zbherUl6U+qlPbaJJznq0AiVn7eCPEWFC+n17aelWygvuzZeeJlnEuvMcjFdCTpGW0zy xoSGNNP67ojVkrfAdxwEgGySLjrDQSNXCcCJoY9RM7dFCX+xDxF++js5hz6CF/wxnAwo 6+NC8U4I6foNxlT+G5zTd5qyg7aQE6+RtT/P5RMRIHY5xLKvZS2P2lSVdgSLErYfHXxF 3grA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715156736; x=1715761536; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KdH49O0cAgoNSOuWczucbNczC7ApQHsjG59jww0LLZo=; b=ZJP7z7NJCj8rhNBXXtxwjJXILDNIcenSJIurmtuj3X4eMO+WxYiCskC3bmlqDNZPv8 se5CiBOfsmXt3jUk1elF5tn/QeQbVbzT+s/q2sMcnCm008/zMJI17v49V5WeaHsuGg1O lfP2WKP9B0/dNCWPKe7ELWvbiP1lGZm9fQHPyibth1w+S5p0sP+NhVjdumS9TomCCTYY zhBm02c3naoNv4LDmMHtZ4+t5/wi2sSOVAG5zSCywDQa90T8Y+1ae7m6FUd4krf3jHz9 zPk5ne5sIjc41ONWiZV4VpxNL5S4TPEoBV/S4g8yULrDaKXiaPLfmIj4QcOGHNzkd7Pu 81uw== X-Forwarded-Encrypted: i=1; AJvYcCVvB9KgRW+SNQ538die3OixWvhdIaNqUCPiKXwapQAEguSl4DIGdjiIPHCZuPNtgCQZoNCLUUGO3F+dTGFuXE+tsNnIDhzzg+dWtTdM X-Gm-Message-State: AOJu0YywkEIXoRjVxso0axekknlAoqBXmo96NAeSh5row9FAQNGVGjQf 8S6gtlatH4cwWTSn3zUC90HjjEWuASqNfoGf2eT2GpvizNJK3SB/XowZBR90RNw= X-Received: by 2002:a17:906:791:b0:a59:cfab:504 with SMTP id a640c23a62f3a-a59fb9b8620mr105914966b.48.1715156736514; Wed, 08 May 2024 01:25:36 -0700 (PDT) Received: from [192.168.1.20] ([178.197.206.169]) by smtp.gmail.com with ESMTPSA id h8-20020a17090634c800b00a59b8e16ac7sm4518734ejb.36.2024.05.08.01.25.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 01:25:35 -0700 (PDT) Message-ID: <9530cd0a-a10d-49be-a415-e9d2351c0cbc@linaro.org> Date: Wed, 8 May 2024 10:25:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] ASoC: Constify channel mapping array arguments in set_channel_map() To: James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Lars-Peter Clausen , =?UTF-8?Q?Nuno_S=C3=A1?= , Srinivas Kandagatla , Banajit Goswami Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240508-asoc-x1e80100-4-channel-mapping-v2-0-ccef9a66a572@linaro.org> <20240508-asoc-x1e80100-4-channel-mapping-v2-1-ccef9a66a572@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240508-asoc-x1e80100-4-channel-mapping-v2-1-ccef9a66a572@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/05/2024 10:16, Krzysztof Kozlowski wrote: > There is no need for implementations of DAI set_channel_map() to modify > contents of passed arrays with actual channel mapping. Additionally, > the caller keeps full ownership of the array. > > Constify these pointer arguments so the code will be safer and easier to > read (documenting the caller's ownership). > > Signed-off-by: Krzysztof Kozlowski Oh, crap, I forgot Ack from Charles. I'll wait till tomorrow and send a new version with the tag included (unless some review comes). Acked-by: Charles Keepax Best regards, Krzysztof