Received-SPF: pass (google.com: domain of linux-kernel+bounces-172932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240506114752.47204-1-charles.goodix@gmail.com>
 <6362e889-7df2-4c61-8ad5-bfe199e451ec@redhat.com> <ZjmOUp725QTHrfcT@google.com>
 <Zjo8eTQQS1LvzFgZ@finisterre.sirena.org.uk> <ZjpFVGw6PgjRcZY3@nixie71>
 <ZjqYp1oxPPWcF3jW@google.com> <ZjrledLjn8RsGiwC@finisterre.sirena.org.uk>
In-Reply-To: <ZjrledLjn8RsGiwC@finisterre.sirena.org.uk>
From: Richard Hughes <hughsient@gmail.com>
Date: Wed, 8 May 2024 09:39:41 +0100
Message-ID: <CAD2FfiE+VFa+7sHQg=LGkBy556msNyyFUhmWW_cAfZd0V4DPYQ@mail.gmail.com>
Subject: Re: [PATCH] Input: goodix-berlin - Add sysfs interface for reading
 and writing touch IC registers
To: Mark Brown <broonie@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jeff LaBundy <jeff@labundy.com>, 
	Hans de Goede <hdegoede@redhat.com>, Charles Wang <charles.goodix@gmail.com>, hadess@hadess.net, 
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, 
	neil.armstrong@linaro.org
Content-Type: text/plain; charset="UTF-8"

On Wed, 8 May 2024 at 03:37, Mark Brown <broonie@kernel.org> wrote:
> The other model I've seen used BTW is to expose a MTD device, if the
> device actually looks like a MTD device (perhaps even is just a flash
> that's fairly directly exposed) that minimises the kernel code quite
> well.

If it helps, fwupd already uses mtd for other devices too, although at
the moment we're using it only for system firmware -- e.g. intel-spi
style. The MTD subsystem doesn't give fwupd much info about the
{removable} device itself, and that can pose a problem unless you
start using heuristics about the parent device to match firmware to
the mtd device.

Richard.