Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp357370lqo; Wed, 8 May 2024 01:44:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUfUO+82TgyapjrebopMg77vPY8HWON3HNYYvJoCm+sxZ4IMcfJ4JKZo8NrGTbt6g2AGxGOcDydvWXZa2TBfnk8F6fw561OiOpo9ouYbg== X-Google-Smtp-Source: AGHT+IF4BHQcz8njAtZu+sakh4PbgAYJC2bC/kFuUm/juIfi214T/qjMqcs1RwyokKvJgjjKzobP X-Received: by 2002:a17:903:2292:b0:1ec:2bca:5aa8 with SMTP id d9443c01a7336-1eeb049b2b0mr27366205ad.6.1715157844669; Wed, 08 May 2024 01:44:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715157844; cv=pass; d=google.com; s=arc-20160816; b=Q/45Wkd2By1RBYj9vsu5kOqCVfY5H36p1LurwbAbakfjD2wUPnT67m3vFgpPoPzJno rRqrcRvWeZOf3bw9QT21W0RSlnM8sO7xZln3jYz1BKHvdo+rhynANeDHNmIOgeYjbrWZ Dxvr/rxkLDbBWme8CGquJdstpJpJ27FeuTJ514WBM6ilEnKt5RD9Asl0f8nTRQeHg7OY LBL2rUKWxmRNnEG4xU2EK0+Ik6nKCWtxfXYzUD05L3Ct73oULf+CflS+z03TArOTv2z7 0AI0ibj4QA1YDDahE3LiNqSV0ayWFvDbQ3ezq5ELOlAelk30Eu+JiutBAj8E32VI6jup h3gA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=uYVXQrqtYJzxvgAUILBWv9cvfYPim9+daqcr2pol0ls=; fh=c1p7tFchADJHauGbUN4ZwJt8qgfR1zUtYrsg9hCv9y4=; b=DZwb8D4nbRkpbM4a2nkOqW4BwF5RRXUWffDDgLNDY6kBxa7Au07p9FYXqaEM0Ynu1Y 0i7UabX+vZgFtfb3dNR7PTRT7phlWYev8mnzXyKkiouH9pzWDxAPMHPpgHkmW0YZzpz1 XCKZ1pcUkYqBxfXBNWIsS5LtIYtDUnIEDfnKk36opUzinY86QLY71XpDOP27i/GgHu0W RU60yFP8yd6o/s5GLesRpV9kAr1Fey4qQ0ExhdTMgvtf5TaXEowm14lyk4+erDpULX2g bXvWm5ZGgu+9FPxGIBnbUmlueCFAzmdutU4M/Aob5n6hAY4hGI9shU3qUZLYzV5UOSn/ vNeg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=droVsfqg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172934-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172934-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b3-20020a170902e94300b001e9219222cfsi12411728pll.269.2024.05.08.01.44.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 01:44:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-172934-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=droVsfqg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-172934-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-172934-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D0898280FDB for ; Wed, 8 May 2024 08:42:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1470654910; Wed, 8 May 2024 08:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="droVsfqg" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3710D54668; Wed, 8 May 2024 08:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715157635; cv=none; b=skeMp75ECAedMIX4oTGTETslgbe+q7OyTDYNlSYjSDhB+fUacn2zPxulMAnjvbs+CjsXZmCYiIpxyrCRjgeFNKsIvZ8+tkRCUM5nqaJFxvVME6WKI2FJb+0lM/bk/6pOUjKws8BC8bu8YN9ZJAlG3bVu2yTHo5rCUhKK/qmlLbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715157635; c=relaxed/simple; bh=7AkH+Cd52kKIzQ6Z1eGmeRFbIVVvMbs2fVbYsa8ENKE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kdeyJ0zzk7Cm+gAZiyGR0zcIyNROET+/6cvJsp7Sxlh0xtJ3RlxHcmMZwSaPyH+GSxQpSDcQ+VcOxqC0bkctc64npQKAAK6wZIUOFJBbmG6IsPQKlXUl0qcw19/DznLc6rmCtWPoRLts8VGvqf2RDx8G5cTh6HoWBvUh1hp/uwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=droVsfqg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BFB9C113CC; Wed, 8 May 2024 08:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715157634; bh=7AkH+Cd52kKIzQ6Z1eGmeRFbIVVvMbs2fVbYsa8ENKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=droVsfqgQLlY5fn/Vt+M7KFqUK8CKoh3x8pk8O7hiSlH+LLrXoFhbLEOMEBzKSfSJ RW6Cg0/CXmktZnLv3xWhN3fVBJ0GHSvvmlpJtWA4H2GeFzyd2TaMmkvhYFs6I7gRyC rjRpZlaVpVWqP/mO7ty8Zv6GgLrUaL4BPgSJbagucUx/5FjvFx00pisN6wobVbxP4L xBYbs419tu86cidfsKDlkkKF8MPP2vnQ4TW1PnqoHoULcIxlZvJD6OfosCATT8B4Sn xIe/XRy67//r1SbHqzYJ4KU3oHgU43lmMWtZsMNJAFLJm9QtU5T7btGJRzcIr/3rAF 7w7ZC+2BqY0LA== Date: Wed, 8 May 2024 09:40:30 +0100 From: Simon Horman To: Justin Lai Cc: "kuba@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "andrew@lunn.ch" , "jiri@resnulli.us" , Ping-Ke Shih , Larry Chiu Subject: Re: [PATCH net-next v17 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Message-ID: <20240508084030.GP15955@kernel.org> References: <20240502091847.65181-1-justinlai0215@realtek.com> <20240502091847.65181-13-justinlai0215@realtek.com> <20240503083534.GL2821784@kernel.org> <1470b2c0983442fcb5078ca510aade35@realtek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470b2c0983442fcb5078ca510aade35@realtek.com> On Tue, May 07, 2024 at 09:44:14AM +0000, Justin Lai wrote: > > On Thu, May 02, 2024 at 05:18:46PM +0800, Justin Lai wrote: > > > 1. Add the RTASE entry in the Kconfig. > > > 2. Add the CONFIG_RTASE entry in the Makefile. > > > > > > Signed-off-by: Justin Lai > > > --- > > > drivers/net/ethernet/realtek/Kconfig | 17 +++++++++++++++++ > > > drivers/net/ethernet/realtek/Makefile | 1 + > > > 2 files changed, 18 insertions(+) > > > > > > diff --git a/drivers/net/ethernet/realtek/Kconfig > > > b/drivers/net/ethernet/realtek/Kconfig > > > index 93d9df55b361..57ef924deebd 100644 > > > --- a/drivers/net/ethernet/realtek/Kconfig > > > +++ b/drivers/net/ethernet/realtek/Kconfig > > > @@ -113,4 +113,21 @@ config R8169 > > > To compile this driver as a module, choose M here: the module > > > will be called r8169. This is recommended. > > > > > > +config RTASE > > > + tristate "Realtek Automotive Switch > > 9054/9068/9072/9075/9068/9071 PCIe Interface support" > > > + depends on PCI > > > + select CRC32 > > > > Hi Justin, > > > > I believe that you also need: > > > > select PAGE_POOL > > > > As the driver uses page_pool_alloc_pages() > > > > FWIIW, I observed this when using a config based on make tinyconfig with PCI > > and NET enabled, all WiFi drivers disabled, and only and only this Ethernet > > driver enabled. > > > > > + help > > > + Say Y here if you have a Realtek Ethernet adapter belonging to > > > + the following families: > > > + RTL9054 5GBit Ethernet > > > + RTL9068 5GBit Ethernet > > > + RTL9072 5GBit Ethernet > > > + RTL9075 5GBit Ethernet > > > + RTL9068 5GBit Ethernet > > > + RTL9071 5GBit Ethernet > > > + > > > + To compile this driver as a module, choose M here: the module > > > + will be called rtase. This is recommended. > > > > The advice above to chose Y and M seem to conflict. > > Perhaps this can be edited somehow. > > > > Hi Simon, > I would like to ask if it would be clearer if I changed it to the following? > > config RTASE > tristate "Realtek Automotive Switch 9054/9068/9072/9075/9068/9071 PCIe Interface support" > depends on PCI > select CRC32 > select PAGE_POOL > help > Say Y here and it will be compiled and linked with the kernel > if you have a Realtek Ethernet adapter belonging to the > following families: > RTL9054 5GBit Ethernet > RTL9068 5GBit Ethernet > RTL9072 5GBit Ethernet > RTL9075 5GBit Ethernet > RTL9068 5GBit Ethernet > RTL9071 5GBit Ethernet > > To compile this driver as a module, choose M here: the module > will be called rtase. This is recommended. Thanks Justin, Yes, I think that addresses my concern.