Received-SPF: pass (google.com: domain of linux-kernel+bounces-172917-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 8 May 2024 09:36:43 +0100
From: Simon Horman <horms@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"jiri@resnulli.us" <jiri@resnulli.us>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Larry Chiu <larry.chiu@realtek.com>
Subject: Re: [PATCH net-next v17 02/13] rtase: Implement the .ndo_open
 function
Message-ID: <20240508083643.GN15955@kernel.org>
References: <20240502091847.65181-1-justinlai0215@realtek.com>
 <20240502091847.65181-3-justinlai0215@realtek.com>
 <20240503085257.GM2821784@kernel.org>
 <745b2ee9e81f4904920e0e4fe6e4df89@realtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <745b2ee9e81f4904920e0e4fe6e4df89@realtek.com>

On Mon, May 06, 2024 at 02:45:11AM +0000, Justin Lai wrote:

..

> > > +
> > > +             /* request other interrupts to handle multiqueue */
> > > +             for (i = 1; i < tp->int_nums; i++) {
> > > +                     ivec = &tp->int_vector[i];
> > > +                     snprintf(ivec->name, sizeof(ivec->name),
> > > + "%s_int%i", tp->dev->name, i);
> > 
> > nit: This line could trivially be split into two lines,
> >      each less than 80 columns wide.
> > 
> I will check if there are other similar issues and make corrections.

Thanks.

FWIIW, checkpatch.pl --max-line-length=80 can be helpful here.