Received-SPF: pass (google.com: domain of linux-kernel+bounces-172966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <38b22230-01f8-4334-a8c1-dd3dde42fe40@intel.com>
Date: Wed, 8 May 2024 11:17:08 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2] lib: Allow for the DIM library to be modular
To: Florian Fainelli <florian.fainelli@broadcom.com>
CC: <netdev@vger.kernel.org>, <kuba@kernel.org>, <jgg@nvidia.com>,
	<leonro@nvidia.com>, <horms@kernel.org>, Andrew Morton
	<akpm@linux-foundation.org>, Tal Gilboa <talgi@nvidia.com>, "open
 list:LIBRARY CODE" <linux-kernel@vger.kernel.org>
References: <20240506175040.410446-1-florian.fainelli@broadcom.com>
 <dfc2d0b4-3ff4-424f-8bdd-3e9bdedba914@intel.com>
 <52bfe069-bff1-4f8e-baed-1c556e43a242@broadcom.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <52bfe069-bff1-4f8e-baed-1c556e43a242@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T05CS1JiNkpyN21TalJPZi95SWZFMjhGYW1tWk9EVENma0dNZndrbmVwOGsy?=
 =?utf-8?B?bXRMaWNuQmdndDZySjFoN0RHdUtJMkFNVkJWYjhDaWlubHFrZHVPejlBY2hV?=
 =?utf-8?B?VU1JNTZsRzdDMktQZ2RCYVNaeGpsajVaYjZJcEordVlQWXhtTFAydU51a0w2?=
 =?utf-8?B?Q1JON01RK2dFY0VBakM2c29VTVpZL1NiY0J1VEZQU2szc0E4QmlMc3NXemdN?=
 =?utf-8?B?allHQTRPMmFrcExKVDdCMEtFSlVlVU5pMkFMVVpMUHpteHFhU045aTRwMTF1?=
 =?utf-8?B?R1lKN01OU1cxem9tNnhOclczTTQ1TmZXNnhpTVFySnVuRG5TSDBNcGN4cTFI?=
 =?utf-8?B?azgzZC8xUGY3dlRvYStwV3ppd3lmYjVocXRtaFBPUnFhdWtOU1dSZE5OUnJt?=
 =?utf-8?B?UXZLK2FEM2pOdHZ5UWI2a01VUE51T3FXZ1JHVGVBVHd6YXhRdWdTT09VcGo4?=
 =?utf-8?B?bW95eXl6dFVrRFRiWUsyN3ZKRzMvaytRcVBjcFNCWTU3U203dXhxbWlFTE1a?=
 =?utf-8?B?Z1VTTko1TDRmRlBERGM0bUdHSjhBOW1ELzZEaitzQWU1bmYzYUhSSmJoOTBr?=
 =?utf-8?B?NXgvMGVlODl4V00xQUEvSTRMQjNYNjcyWVF2UnVySWtacWNwWjlMVHhCRjM4?=
 =?utf-8?B?REZGWEIwSWFxSksvTEtMS1lqL1FnRTAwM3dwazdNMTAxUFYzMDlueWxZUFZ2?=
 =?utf-8?B?ODJGNVpISHBSZDJTcWJxRnRMKzdnUTVsVVlHWVEvdjR6a3FVN1BmZGhtK0Fo?=
 =?utf-8?B?eWVsVGJ6R1ZWZ3FDVjJ3SmNxNldWaFBScThUc0JJemNkdVJxZzErOVNoQU1n?=
 =?utf-8?B?Z1QxbGgrUFBXcUdrV3F0Z1dMWmNlSnVpSDZ0ZUJxMVRFM0JxbFZYQjQwN1Ju?=
 =?utf-8?B?VjZ1OUc1V1VURHVHQkNjRWhhb0dKU2U4dnJ3eEtuNjVuTGcvTE1aTkdDWkRz?=
 =?utf-8?B?aGYzbW1uL2wrTHp2MlcrU2ZNYjdaaTRYYk9VOW15WjdEWW9UdWlQK1dmVW9O?=
 =?utf-8?B?QmNyYlEvM3JuUTVlZVFLa2VvUWZzbW5nTjN5akRMWTRoa1FoLzZ0cnM0NEZT?=
 =?utf-8?B?Q1JSQ2QzTE9tR1ArWEpjTUhXRUpIZzFRUWFaVXEreVIxTVhMbnpOUUNkUzBJ?=
 =?utf-8?B?VTZTVklBNUZxRyswdjFCVWxzdExEek13UkVKd3VGUnVoZjIvOGpMYnMrUE9p?=
 =?utf-8?B?WXFaQjkxYlM0MktSWXZNVWkyZVZvRmFLeDAxdXZYejRkZ3piNGtjWDhaWi95?=
 =?utf-8?B?RitpaWhoUll6N1FYUGRJS05FOElVa2JtbGRvMnhjQkxHNGl5aEt0TVZURXdE?=
 =?utf-8?B?QTRpSk8vMzdOVi9RcVFQbnE5cmRoTW0vWWJibllabEZCOXpoV0Z2bWFtLzJp?=
 =?utf-8?B?MlBtQTZocGNUQkhTQ0VEeGVTZXpIWlJhV2RhcTgza2pmZlNvblpKRzFucnhW?=
 =?utf-8?B?WDlxYTJFRFVXS1Rab3dBZE9OU3YxNGJ3UTRSL2RiL0xVMW1lVEczclE2TzRD?=
 =?utf-8?B?U1puUzRRc0xDY25BY2NKazVFeURGU0lqZHVzMFVwbTFXYVBFajZlZ2l0V1V3?=
 =?utf-8?B?RTRzSHlUWnh6eEQvcTFwWWJPUWZDaFpIVXZXNzIzejlORkY5U1FKN0dqN0Rw?=
 =?utf-8?B?QVVZK3hlRFpnNURoZDNRQitRbW1OdVNTcGJML0FoY0dOb0FkMWdhNVE1dkFS?=
 =?utf-8?B?c016SGZtMVJ0UDAyY21VWEZvL1BmRk5IbXFXeTdaWXRJVTFVVWtTM3F0QW9O?=
 =?utf-8?B?N1g1ZlZvaUpYQTNEa3ozYU9YWjlKU0xmQlhCYU91QlRHMEROWDBGdmZSSHo0?=
 =?utf-8?B?R0hSbnlBdWtJNU5pZThwWVNta0NqN2h4OS9uU0R4RXNhYjNoR05vU2UxVy9w?=
 =?utf-8?B?Rlc2alIxVGVOUlVVYi93VE5YSWxBb2pTZkJTQnVvYk9rR1g1TzFMRWpGZUs3?=
 =?utf-8?B?TjhSa1psVHB4M3BYZW14bmdmZFZoS1NEaE5MNVl2QmJFbjVCTC91QUdHTVoz?=
 =?utf-8?B?ZjJEd1lMWGdoaDIvNWFOdHNrTk1ZVCsyNlhNaGFjVnZMYzZpeFl4dXNodE1B?=
 =?utf-8?B?M0o4V2tFSnBKZXRSWERtRFZOckZJZVVEVU5pZG9yKzZEZHI0OFVYZUpWWTdS?=
 =?utf-8?B?RFpwNGxTOXhDODJWSlIzUmdzbHRJZk5tU0EySzdCS1FzaTRTbFFoTmMzQjBJ?=
 =?utf-8?B?Q2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f0efcfda-daee-4996-3cb3-08dc6f3fb3c6
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 09:17:37.0542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B79Yf8Lvca6dnwrCyYSHpF0I9fQelmEvqyN1zL5ubnQtRilqH++FWpb5p8yxZTCiMlI5dxpV062Y+VavJfU1r7YSS0FN248ln1umk1263GI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6904
X-OriginatorOrg: intel.com

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: Tue, 7 May 2024 10:08:19 -0700

> On 5/7/24 06:13, Alexander Lobakin wrote:
>> From: Florian Fainelli <florian.fainelli@broadcom.com>
>> Date: Mon,  6 May 2024 10:50:40 -0700
>>
>>> Allow the Dynamic Interrupt Moderation (DIM) library to be built as a
>>> module. This is particularly useful in an Android GKI (Google Kernel
>>> Image) configuration where everything is built as a module, including
>>> Ethernet controller drivers. Having to build DIMLIB into the kernel
>>> image with potentially no user is wasteful.
>>
>> Some bloat-o-meter -c vmlinux.{before,after} would be good to have here.
>> The library is small, but I personally would like to see it modular.
> 
> ./scripts/bloat-o-meter vmlinux vmlinux.after
> add/remove: 1/16 grow/shrink: 0/0 up/down: 8/-1980 (-1972)
> Function                                     old     new   delta
> e843419@0740_00005048_4014                     -       8      +8
> e843419@07b3_000055c6_5944                     8       -      -8
> dim_park_on_top                                8       -      -8
> dim_park_tired                                16       -     -16
> net_dim_get_def_tx_moderation                 24       -     -24
> net_dim_get_def_rx_moderation                 24       -     -24
> dim_turn                                      52       -     -52
> net_dim_get_rx_moderation                     60       -     -60
> net_dim_get_tx_moderation                     64       -     -64
> tx_profile                                    80       -     -80
> rx_profile                                    80       -     -80
> dim_on_top                                    84       -     -84
> net_dim_step                                 132       -    -132
> dim_calc_stats                               172       -    -172
> net_dim_stats_compare                        176       -    -176
> net_dim                                      464       -    -464
> rdma_dim                                     536       -    -536
> Total: Before=12668884, After=12666912, chg -0.02%
> 
> This is on arm64 FWIW.

-2 Kb sounds reasonable I'd say. This doesn't even require adding new
exports, nice.

> 
>>
>>>
>>> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
>>
>> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>>
>>> ---
>>> Changes in v2:
>>>
>>> - Added MODULE_DESCRIPTION()
>>>
>>>   lib/Kconfig      | 2 +-
>>>   lib/dim/Makefile | 4 ++--
>>>   lib/dim/dim.c    | 3 +++
>>>   3 files changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/lib/Kconfig b/lib/Kconfig
>>> index 4557bb8a5256..d33a268bc256 100644
>>> --- a/lib/Kconfig
>>> +++ b/lib/Kconfig
>>> @@ -628,7 +628,7 @@ config SIGNATURE
>>>         Implementation is done using GnuPG MPI library
>>>     config DIMLIB
>>> -    bool
>>> +    tristate
>>>       help
>>>         Dynamic Interrupt Moderation library.
>>>         Implements an algorithm for dynamically changing CQ
>>> moderation values
>>> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
>>> index 1d6858a108cb..c4cc4026c451 100644
>>> --- a/lib/dim/Makefile
>>> +++ b/lib/dim/Makefile
>>> @@ -2,6 +2,6 @@
>>>   # DIM Dynamic Interrupt Moderation library
>>>   #
>>>   -obj-$(CONFIG_DIMLIB) += dim.o
>>> +obj-$(CONFIG_DIMLIB) += dimlib.o
>>
>> I guess you renamed it due to that there's already a module named 'dim'?
> 
> This is required to avoid the follow recursive dependency:
> 
> make[4]: Circular lib/dim/dim.o <- lib/dim/dim.o dependency dropped.

Aaah I see!

Thanks,
Olek