Received-SPF: pass (google.com: domain of linux-kernel+bounces-172982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Subject: Re: WARNING in fuse_request_end
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: lee bruce <xrivendell7@gmail.com>, linux-fsdevel@vger.kernel.org,
 yue sun <samsun1006219@gmail.com>, linux-kernel@vger.kernel.org,
 syzkaller@googlegroups.com
References: <CABOYnLwAe+hVUNe+bsYeKJJQ-G9svs7dR2ymZDh0PsfqFNMm2A@mail.gmail.com>
 <2625b40f-b6c5-2359-33fe-5c81e9a925a9@huaweicloud.com>
 <CAJfpegvGhtLSxOHUQQ95a3skqEgEPt+MzpBT8vOOdqWcRxPR5Q@mail.gmail.com>
From: Hou Tao <houtao@huaweicloud.com>
Message-ID: <58f13e47-4765-fce4-daf4-dffcc5ae2330@huaweicloud.com>
Date: Wed, 8 May 2024 17:42:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAJfpegvGhtLSxOHUQQ95a3skqEgEPt+MzpBT8vOOdqWcRxPR5Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 5/8/2024 4:21 PM, Miklos Szeredi wrote:
> On Tue, 7 May 2024 at 15:30, Hou Tao <houtao@huaweicloud.com> wrote:
>
>> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
>> index 3ec8bb5e68ff5..840cefdf24e26 100644
>> --- a/fs/fuse/dev.c
>> +++ b/fs/fuse/dev.c
>> @@ -1814,6 +1814,7 @@ static void fuse_resend(struct fuse_conn *fc)
>>
>>         list_for_each_entry_safe(req, next, &to_queue, list) {
>>                 __set_bit(FR_PENDING, &req->flags);
>> +               clear_bit(FR_SENT, &req->flags);
>>                 /* mark the request as resend request */
>>                 req->in.h.unique |= FUSE_UNIQUE_RESEND;
>>         }
>>
> ACK, fix looks good.
>
> Would you mind resending it as a proper patch?

Thanks for the ACK. Will post it.
>
> Thanks,
> Miklos
>
> .