Received-SPF: pass (google.com: domain of linux-kernel+bounces-173007-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 8 May 2024 12:57:11 +0300
From: Andy Shevchenko <andy@black.fi.intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org, Levi Yun <ppbuk5246@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>, x86@kernel.org
Subject: Re: [tip: timers/urgent] timers/migration: Prevent out of bounds
 access on failure
Message-ID: <ZjtMdx8v051qcNtU@black.fi.intel.com>
References: <20240506041059.86877-1-ppbuk5246@gmail.com>
 <171516154125.10875.14125964308560203288.tip-bot2@tip-bot2>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <171516154125.10875.14125964308560203288.tip-bot2@tip-bot2>

On Wed, May 08, 2024 at 09:45:41AM -0000, tip-bot2 for Levi Yun wrote:
> The following commit has been merged into the timers/urgent branch of tip:

(Yes, I noted above)

..

> -	do {
> +	while (i > 0) {
>  		group = stack[--i];

Looking at this and most used patterns for cleanup loops, I would amend
this to

	while (i--) {
		group = stack[i];

which seems to me an equivalent.

>  		if (err < 0) {
> @@ -1645,7 +1645,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
>  				tmigr_connect_child_parent(child, group);
>  			}
>  		}
> -	} while (i > 0);
> +	}

-- 
With Best Regards,
Andy Shevchenko