Received-SPF: pass (google.com: domain of linux-kernel+bounces-173056-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 8 May 2024 15:56:03 +0530
From: Prahlad Valluru <quic_vvalluru@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC: Abhinav Kumar <quic_abhinavk@quicinc.com>, <andersson@kernel.org>,
        <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <konrad.dybcio@linaro.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_nankam@quicinc.com>, <robh@kernel.org>
Subject: Re: [PATCH v3] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge
Message-ID: <20240508102603.GB28609@hu-vvalluru-hyd.qualcomm.com>
Reply-To: <2f810036-1832-42ef-b896-e9470f469029@linaro.org>
References: <jr3ble6sxr5mr6cvm6ldvpyk5j4rucj3xy6vbha6ttoecte3d7@llu6qf6oasuc>
 <20240507163045.28450-1-quic_vvalluru@quicinc.com>
 <a32fa81d-bd70-4dfa-b512-e2adce4f8c35@linaro.org>
 <9a48b0a8-d1d7-8e2d-dafa-47e136a46c99@quicinc.com>
 <2f810036-1832-42ef-b896-e9470f469029@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2f810036-1832-42ef-b896-e9470f469029@linaro.org>
User-Agent: Mutt/1.9.4 (2018-02-28)

On Wed, May 08, 2024 at 09:38:50AM +0200, Krzysztof Kozlowski wrote:
> On 07/05/2024 21:20, Abhinav Kumar wrote:
> > 
> > 
> > On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote:
> >> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote:
> >>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with
> >>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24.
> >>> Bridge supplies are Vdd connected to input supply directly
> >>> and vcc to L11c. Enable HDMI output, bridge and corresponding
> >>> DSI output.
> >>>
> >>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>
> >>> ---
> >>> v3: - Updated commit text
> >>>      - Arranged nodes in alphabetical order
> >>>      - Fixed signoff
> >>>      - Fixed drive strength for lt9611_irq_pin
> >>>      - Removed 'label' from hdmi-connector, which is optional
> >>
> >> Please respond to each Bjorn comment and explain how did you implement it...
> >>
> > 
> > Yes, agreed. Even though it seems like you mostly just agreed to mine 
> > and Bjorn's suggestions and decided to implement all those in v3 , it 
> > would have been better to explicitly ack them or tell why you agreed or 
> > what went wrong that you had not done it in v2 itself to close the loop.
> 
> The problem is that one or more were ignored... By responding to each of
> them, I hope they will be finally read and understood instead of
> repeating the same mistake three times.

Agreed. Will make sure to acknowledge the comments.

> 
> Best regards,
> Krzysztof
>