Received-SPF: pass (google.com: domain of linux-kernel+bounces-173073-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f54e0ffb-4087-4e83-9953-122fc19f488b@fiberby.net>
Date: Wed, 8 May 2024 10:41:27 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: =?UTF-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= <ast@fiberby.net>
Subject: Re: [PATCH net-next 01/14] net: qede: use extack in
 qede_flow_parse_ports()
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Manish Chopra <manishc@marvell.com>,
 netdev@vger.kernel.org
References: <20240507104421.1628139-1-ast@fiberby.net>
 <20240507104421.1628139-2-ast@fiberby.net>
 <e3993bb2-3aac-4b07-8f8a-e537fa902af4@intel.com>
Content-Language: en-US
In-Reply-To: <e3993bb2-3aac-4b07-8f8a-e537fa902af4@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Przemek,

Thank you for the review!

On 5/8/24 10:07 AM, Przemek Kitszel wrote:
> On 5/7/24 12:44, Asbjørn Sloth Tønnesen wrote:
>> Convert qede_flow_parse_ports to use extack,
>> and drop the edev argument.
>>
>> Convert DP_NOTICE call to use NL_SET_ERR_MSG_MOD instead.
>>
>> In calls to qede_flow_parse_ports(), use NULL as extack
>> for now, until a subsequent patch makes extack available.
>>
>> Only compile tested.
>>
>> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
>> ---
>>   drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
>> index ded48523c383..3995baa2daa6 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
>> +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
>> @@ -1700,7 +1700,7 @@ static int qede_parse_actions(struct qede_dev *edev,
>>   }
>>   static int
>> -qede_flow_parse_ports(struct qede_dev *edev, struct flow_rule *rule,
>> +qede_flow_parse_ports(struct netlink_ext_ack *extack, struct flow_rule *rule,
>>                 struct qede_arfs_tuple *t)
> 
> there are ~40 cases in drivers/net/ethernet that have an extack param as
> not the last one, and over 1250 that have an extack as the last param.
> My grepping was very naive, and counted both forward declarations and
> implementations, but it's clear what is the preference.
> 
> Could you please convert the series to be that way?

Sure, will do that in v2.

-- 
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541