Received-SPF: pass (google.com: domain of linux-kernel+bounces-173166-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 8 May 2024 20:41:43 +0900
From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Johan Hovold <johan+linaro@kernel.org>, Lee Jones <lee@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Das Srinagesh <quic_gurus@quicinc.com>,
	Satya Priya <quic_c_skakit@quicinc.com>,
	Stephen Boyd <swboyd@chromium.org>, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver
Message-ID: <Zjtk90ZoKvFrmi1L@finisterre.sirena.org.uk>
References: <20240506150830.23709-1-johan+linaro@kernel.org>
 <20240506150830.23709-13-johan+linaro@kernel.org>
 <Zjkq_nWyvc6bUtiu@surfacebook.localdomain>
 <ZjpMeVk_HiixZUEu@hovoldconsulting.com>
 <CAHp75VdUFMvkj-r76H7GFZdpcoh_nb8v6CBj4wBHztNhiaWULQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WOUJEMZDjv5vndYJ"
Content-Disposition: inline
In-Reply-To: <CAHp75VdUFMvkj-r76H7GFZdpcoh_nb8v6CBj4wBHztNhiaWULQ@mail.gmail.com>


--WOUJEMZDjv5vndYJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 07, 2024 at 08:22:34PM +0300, Andy Shevchenko wrote:
> On Tue, May 7, 2024 at 6:44=E2=80=AFPM Johan Hovold <johan@kernel.org> wr=
ote:

> > > > [ johan: rework probe to match new binding, amend commit message and
> > > >          Kconfig entry]

> > > Wouldn't be better on one line?

> > Now you're really nit picking. ;) I think I prefer to stay within 72
> > columns.

> Not really. The tag block is special and the format is rather one
> entry per line. This might break some scriptings.

No, really - the above is absolutely fine, random notes in the middle of
things are reasonably common and scripting that can't cope with them is
going to encounter a bunch of problems.  This stuff needs to be readable
by humans and this is just a stylistic preference on your part.

--WOUJEMZDjv5vndYJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY7ZPYACgkQJNaLcl1U
h9BDMAf/c6jnrB5DGzsK8YxcJFkAon0+x6MNIbq3mZGjufO9NdnEf0FSC6u51Aad
nSF6gSZe49arslXszvjwJJszRuYMga7OQzwRwROoqxxWfKx29XcXappYyYeA/mBN
Vfxej1jCTKxQpogB+Ma5J3AFcNf0diNSG/V3ZF/YCYv4aW7vNwthkuKVgjnU+GsX
Y/0hNkfrBIilPzomD0DxG3aSNhHMs0BCENrTDHDY4zONqoGdqotH4aUQZN+wdPTL
UcEUImtpVm2e7yJBHM9HXOLtOAsYhwmy08gvgDAZig/JFOIykDo1NLqINmmV0Q2V
MBTJQFmsBLt6fu6YfbdeF9deJqFC3w==
=xko8
-----END PGP SIGNATURE-----

--WOUJEMZDjv5vndYJ--