Received-SPF: pass (google.com: domain of linux-kernel+bounces-173183-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 8 May 2024 20:53:34 +0900
From: Mark Brown <broonie@kernel.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	johnny_lai@richtek.com, cy_huang@richtek.com
Subject: Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with
 both fixed and adjustable vout
Message-ID: <ZjtnvjlJpfNn7qVT@finisterre.sirena.org.uk>
References: <cover.1714467553.git.alina_yu@richtek.com>
 <ffeecd61c194df1f7f049bd50cb2bbbad3cf1025.1714467553.git.alina_yu@richtek.com>
 <ZjGmmYWHu-ZQQdIh@finisterre.sirena.org.uk>
 <20240502073029.GA4055@linuxcarl2.richtek.com>
 <20240502092614.GA31518@linuxcarl2.richtek.com>
 <ZjRAsJHn57pZy5UH@finisterre.sirena.org.uk>
 <20240503073536.GA12846@linuxcarl2.richtek.com>
 <ZjjwFTtiopqsYdeJ@finisterre.sirena.org.uk>
 <20240508065402.GA7462@linuxcarl2.richtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mtC14iJaOWxhpsjn"
Content-Disposition: inline
In-Reply-To: <20240508065402.GA7462@linuxcarl2.richtek.com>


--mtC14iJaOWxhpsjn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 08, 2024 at 02:54:02PM +0800, Alina Yu wrote:

> May I modify the code into this ?
> I'll add 'richtek,fixed-microvolt' property in dtsi; remove 'regulator-min-microvolt' and 'regulator-max-microvolt'
> to prevent fail caused by constraints->apply_uV.

Adding the new property seems fine.  You still need to permit the
min/max microvolt properties for the case where the regulator is in
normal mode and can vary, you could write rules that ensure that the
constraints line up in the case where a fixed voltage is specified but
I'm not sure it's worth the effort.

--mtC14iJaOWxhpsjn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY7Z7sACgkQJNaLcl1U
h9Aquwf9H+G8Hr6XIT+TdTjeWbKbmYnY5RaWfJdxK43T7eNU/oHJdAsLluk2/pVx
K/fkI82xYzAFuHBcOolpKy3Vxp7tMt2W3+edHzxSQWr+wWcJLlHWEpSWHrfjxMA/
1rCfVnpKZPZUJM+3CShDOHwWdwEtGQMEtH/+GTjxl/DJV3UCybGBQq+1O/0QPg0b
bXSFJtrpu56D5ePvApQKSBvrE6K9KPw5cgRh8/1SWLOIvQZNOnc5WybUuTRt6Q4O
IAJiS86ZvbvHOq4jK0dSYOzmRXjSknDrb2qzaQKCN4k7WJ3bWuwDm5i4MRUgITUI
qnqEDr00RhOleKjbf4AD4YG+GO7z2Q==
=iHZI
-----END PGP SIGNATURE-----

--mtC14iJaOWxhpsjn--