Received-SPF: pass (google.com: domain of linux-kernel+bounces-173219-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 08 May 2024 14:34:07 +0200
Message-ID: <874jb8cwjk.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <tiwai@suse.com>,
	<linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>,
	<alsa-devel@alsa-project.org>,
	<linux-sound@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: hda_component: Initialize shared data during bind callback
In-Reply-To: <20240508100347.47283-1-rf@opensource.cirrus.com>
References: <20240508100347.47283-1-rf@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Wed, 08 May 2024 12:03:47 +0200,
Richard Fitzgerald wrote:
> 
> Move the initialization of the shared struct hda_component array into
> hda_component_manager_bind().
> 
> The purpose of the manager bind() callback is to allow it to perform
> initialization before binding in the component drivers. This is the
> correct place to initialize the shared data.
> 
> The original implementation initialized the shared data in
> hda_component_manager_init(). This is only done once during probe()
> of the manager driver. So if the component binding was unbound and
> then rebound, the shared data would not be re-initialized.
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Fixes: fd895a74dc1d ("ALSA: hda: realtek: Move hda_component implementation to module")

Applied now.  Thanks.


Takashi