Received-SPF: pass (google.com: domain of linux-kernel+bounces-173225-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Michael Ellerman <mpe@ellerman.id.au>
To: Gautam Menghani <gautam@linux.ibm.com>, npiggin@gmail.com,
 christophe.leroy@csgroup.eu, naveen.n.rao@linux.ibm.com
Cc: Gautam Menghani <gautam@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org,
 kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Vaibhav Jain
 <vaibhav@linux.ibm.com>
Subject: Re: [PATCH v6] arch/powerpc/kvm: Add support for reading VPA
 counters for pseries guests
In-Reply-To: <20240506145605.73794-1-gautam@linux.ibm.com>
References: <20240506145605.73794-1-gautam@linux.ibm.com>
Date: Wed, 08 May 2024 22:36:35 +1000
Message-ID: <87o79gmqek.fsf@mail.lhotse>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Gautam Menghani <gautam@linux.ibm.com> writes:
> PAPR hypervisor has introduced three new counters in the VPA area of
> LPAR CPUs for KVM L2 guest (see [1] for terminology) observability - 2
> for context switches from host to guest and vice versa, and 1 counter
> for getting the total time spent inside the KVM guest. Add a tracepoint
> that enables reading the counters for use by ftrace/perf. Note that this
> tracepoint is only available for nestedv2 API (i.e, KVM on PowerVM).
..
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index 8e86eb577eb8..ed69ad58bd02 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -4108,6 +4108,54 @@ static void vcpu_vpa_increment_dispatch(struct kvm=
_vcpu *vcpu)
>  	}
>  }
>=20=20
> +static inline int kvmhv_get_l2_counters_status(void)
> +{
> +	return get_lppaca()->l2_counters_enable;
> +}

This is breaking the powernv build:

$ make powernv_defconfig ; make -s -j (nproc)
make[1]: Entering directory '/home/michael/linux/.build'
  GEN     Makefile
#
# configuration written to .config
#
make[1]: Leaving directory '/home/michael/linux/.build'
./arch/powerpc/kvm/book3s_hv.c: In function =E2=80=98kvmhv_get_l2_counters=
_status=E2=80=99:
./arch/powerpc/kvm/book3s_hv.c:4113:16: error: implicit declaration of fun=
ction =E2=80=98get_lppaca=E2=80=99; did you mean =E2=80=98get_paca=E2=80=99=
? [-Werror=3Dimplicit-function-declaration]
 4113 |         return get_lppaca()->l2_counters_enable;
      |                ^~~~~~~~~~
      |                get_paca
./arch/powerpc/kvm/book3s_hv.c:4113:28: error: invalid type argument of =
=E2=80=98->=E2=80=99 (have =E2=80=98int=E2=80=99)
 4113 |         return get_lppaca()->l2_counters_enable;
      |                            ^~
In file included from ../arch/powerpc/include/asm/paravirt.h:9,
                 from ../arch/powerpc/include/asm/qspinlock.h:7,
                 from ../arch/powerpc/include/asm/spinlock.h:7,
                 from ../include/linux/spinlock.h:95,
                 from ../include/linux/sched.h:2138,
                 from ../include/linux/hardirq.h:9,
                 from ../include/linux/kvm_host.h:7,
                 from ../arch/powerpc/kvm/book3s_hv.c:18:
./arch/powerpc/kvm/book3s_hv.c: In function =E2=80=98kvmhv_set_l2_counters=
_status=E2=80=99:
./arch/powerpc/include/asm/lppaca.h:105:41: error: =E2=80=98struct paca_st=
ruct=E2=80=99 has no member named =E2=80=98lppaca_ptr=E2=80=99
  105 | #define lppaca_of(cpu)  (*paca_ptrs[cpu]->lppaca_ptr)
      |                                         ^~
./arch/powerpc/kvm/book3s_hv.c:4119:17: note: in expansion of macro =E2=80=
=98lppaca_of=E2=80=99
 4119 |                 lppaca_of(cpu).l2_counters_enable =3D 1;
      |                 ^~~~~~~~~
./arch/powerpc/include/asm/lppaca.h:105:41: error: =E2=80=98struct paca_st=
ruct=E2=80=99 has no member named =E2=80=98lppaca_ptr=E2=80=99
  105 | #define lppaca_of(cpu)  (*paca_ptrs[cpu]->lppaca_ptr)
      |                                         ^~
./arch/powerpc/kvm/book3s_hv.c:4121:17: note: in expansion of macro =E2=80=
=98lppaca_of=E2=80=99
 4121 |                 lppaca_of(cpu).l2_counters_enable =3D 0;
      |                 ^~~~~~~~~
./arch/powerpc/kvm/book3s_hv.c: In function =E2=80=98do_trace_nested_cs_ti=
me=E2=80=99:
./arch/powerpc/kvm/book3s_hv.c:4145:29: error: initialization of =E2=80=98=
struct lppaca *=E2=80=99 from =E2=80=98int=E2=80=99 makes pointer from inte=
ger without a cast [-Werror=3Dint-conversion]
 4145 |         struct lppaca *lp =3D get_lppaca();
      |                             ^~~~~~~~~~
./arch/powerpc/kvm/book3s_hv.c: In function =E2=80=98kvmhv_get_l2_counters=
_status=E2=80=99:
./arch/powerpc/kvm/book3s_hv.c:4114:1: error: control reaches end of non-v=
oid function [-Werror=3Dreturn-type]
 4114 | }
      | ^
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:244: arch/powerpc/kvm/book3s_hv.o] =
Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:485: arch/powerpc/kvm] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [../scripts/Makefile.build:485: arch/powerpc] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/home/michael/linux/Makefile:1919: .] Error 2
make[1]: *** [/home/michael/linux/Makefile:240: __sub-make] Error 2
make: *** [Makefile:240: __sub-make] Error 2


cheers