Received-SPF: pass (google.com: domain of linux-kernel+bounces-173260-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Thomas Gleixner <tglx@linutronix.de>
To: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "x86@kernel.org" <x86@kernel.org>, "dave.hansen@linux.intel.com"
 <dave.hansen@linux.intel.com>, Ingo Molnar <mingo@kernel.org>, Keith Lucas
 <keith.lucas@oracle.com>
Subject: Re: [PATCH v3 4/4] selftests/mm: Add new testcases for pkeys
In-Reply-To: <C91DA697-0483-4AF0-A29D-FBAA1669E845@oracle.com>
References: <20240425180542.1042933-1-aruna.ramakrishna@oracle.com>
 <20240425180542.1042933-5-aruna.ramakrishna@oracle.com>
 <875xvprfnm.ffs@tglx> <87ttj9pnm8.ffs@tglx>
 <C91DA697-0483-4AF0-A29D-FBAA1669E845@oracle.com>
Date: Wed, 08 May 2024 14:55:40 +0200
Message-ID: <871q6cpinn.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Tue, May 07 2024 at 18:04, Aruna Ramakrishna wrote:
>> On May 7, 2024, at 9:56=E2=80=AFAM, Thomas Gleixner <tglx@linutronix.de>=
 wrote:
>>=20
>> On Tue, May 07 2024 at 14:05, Thomas Gleixner wrote:
>>> On Thu, Apr 25 2024 at 18:05, Aruna Ramakrishna wrote:
>>>> especially with pkey 0 disabled.
>>>>=20
>>>> Signed-off-by: Keith Lucas <keith.lucas@oracle.com>
>>>> Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
>>=20
>> Forgot to mention that this Signed-off-by chain is invalid.
>
> Apologies for what is probably an obvious question.
>
> Keith Lucas developed the testcases in the new file pkey_sighandler_tests=
c.
>
> I added them to tools/testing/selftests/mm (i.e. just the changes
> to Makefile, protection_keys.c and some comments etc.).
>
> So should I change this to:
>
> Co-developed-by: Keith Lucas <keith.lucas@oracle.com>
> Signed-off-by: Keith Lucas <keith.lucas@oracle.com>
> Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>

If Keith developed them, then you probably want to credit him as author.

[ aruna: Adopted to upstream ]

Signed-off-by: Keith Lucas <keith.lucas@oracle.com>
Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>

Or split out the pkey helper changes into a separate patch which is
authored by you.

Either way works just fine.

Thanks,

        tglx