Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp509149lqo; Wed, 8 May 2024 06:47:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVp1OZyqh8/NQNVKvh1Bck1Mu4z1r3cWabqZ1frzqVTU/mNk3QEwzXx3onqM4JU7TadndJIW51GtM6UAkAwJsOj0PkE+lOtiN/NVTsvPw== X-Google-Smtp-Source: AGHT+IHqAt7VQptD9hxJ/puyGRTs+cty0VcJo5rL/0Tpg+xHh0geAsAuk5JW7GXFDPwWXDjIGnTc X-Received: by 2002:a0d:c306:0:b0:61b:16d9:47cd with SMTP id 00721157ae682-620861f534emr23514337b3.11.1715176061637; Wed, 08 May 2024 06:47:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715176061; cv=pass; d=google.com; s=arc-20160816; b=iLQ+4shQ+Z2rf0zRklLgHyg+kAZn7Xg1xvacccslfKBB1K5mPiXcqaCQrek0sZmHOU 4dTmiMT4blIXDHDICZ/DhezFW25Hsxcz+fPzrtmSJIho/jU1ZGWpXibXRRQE7r3LaMxu aaGsMTgrPA5zmjEfjk/1H0gCOpaBtUO7Ic20IwP1bOLLOv80QzO4okgUCT19C6hIff6D Y1J2wrwflJMdh3XmV+SCqy9onmDsFBT2KGXLSI7Eq881mJreBENmCH0t6NjsZEdx2Bxf NFo8deelJztJIPYfGn7Hd10wm9+QKnhQ9NYEbtbpg2A1QCDuBP4K2EYO2D0QRtjuuVcr NmUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=u+GZmNy0f1QaCQLLso8mwzsQrL2vfhyfgTwlxOhhB+4=; fh=8mecYgt5OT/tq5mYZNEdefVGNcHGzQoaM/4RGlmFz+Q=; b=QDBXzEx458ov6u7vM9I3v7kVz1uTzejm7fWuKaE1+9M512Z4T9O6gGlaPb3q5/vJLg v5VOyH3LCB+J0pyu2hWxAcHZNUaz+aR+rmA/PekyJ3tGM/Kw6Wg/b0CY/ym43vuRS64K I24vjD/ol4ii14DeZrLxQ7C9/QT0vqgXfMT5rda2uSC5UfLP6RsYhB4uk70PKPMmhREZ 3DxBG8e7NgUWjRp8En9AQh16jZTJEuESa3LVLGqMTY89dDSX49LNZVY48u9wr64XKU9F PRKx+gXpeHF29laDDPl73OWPa0EmPpUQTx/rA4H8QMsfo3vuoIRRjxj1NoEo86kQC6os t2vg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-173354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173354-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t7-20020a05622a180700b0043ac4e8cb44si4947521qtc.301.2024.05.08.06.47.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 06:47:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-173354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-173354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173354-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AD9D71C232C7 for ; Wed, 8 May 2024 13:47:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C34A84E16; Wed, 8 May 2024 13:46:25 +0000 (UTC) Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEECD78C9B; Wed, 8 May 2024 13:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715175984; cv=none; b=Co7QbNJAa33LxlyN9VSxVcRqT0n0vOePNsGhmq5EfmIYIolR3j074BRuqo9Y8xREVN2cP9qyt4YpOunQtRthec6zrAqFWvtyAx0RYuRnBsvB6r/jk3quguC2P7Fj66cYE1XMNY7g91v+RmvzRPmeDowuzo7/aCICEqhNF6iQFj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715175984; c=relaxed/simple; bh=PdHakPGfziCL3JETjXF2HpcAQm9uAp9U4XC+GgVdLok=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=Ktj9gkFkhf/zwCPYbAFDJehsi1KHd0vjrd8pkXGXvcvZLNJ4JsH7uVmcGsqF6q6CMrcPrsiec07JLHa3LywmNj8XOF2jPYlDaeA7Q3HpfrAvkUXj8jAKf8CPhRbWDxIbVzAOWbRahwuy146TfypLY2Fgwry1pxw6ga6ycmCTew4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VZGdS57yFz4x0v; Wed, 8 May 2024 23:46:20 +1000 (AEST) From: Michael Ellerman To: Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Vaibhav Jain , Kautuk Consul , Amit Machhiwal , Jordan Niethe , Christophe JAILLET Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Gautam Menghani , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info() Message-Id: <171517595459.167543.3276617285735136069.b4-ty@ellerman.id.au> Date: Wed, 08 May 2024 23:45:54 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Sun, 28 Jan 2024 12:34:25 +0100, Christophe JAILLET wrote: > The return value of kvmppc_gse_put_buff_info() is not assigned to 'rc' and > 'rc' is uninitialized at this point. > So the error handling can not work. > > Assign the expected value to 'rc' to fix the issue. > > > [...] Applied to powerpc/topic/ppc-kvm. [1/1] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info() https://git.kernel.org/powerpc/c/b52e8cd3f835869370f8540f1bc804a47a47f02b cheers