Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp517372lqo; Wed, 8 May 2024 07:01:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUldlYprKRCecBPNSRJqNDmphnDwcKOVBB+BhaWy4g6neyJpFYagvbDleQ3UqZCzVup4viMQLoO1kZq45fUDQ0s8LOp3qxCwE8uOlYq1g== X-Google-Smtp-Source: AGHT+IG8egEH2nalrZehvQQnDz4PZg1gLkrKWIyc/2yx19DdtCiewJsM3nc3Ay3XY3Kmut7nbe9p X-Received: by 2002:a50:d543:0:b0:56e:238e:372c with SMTP id 4fb4d7f45d1cf-5731da64135mr1938233a12.26.1715176903732; Wed, 08 May 2024 07:01:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715176903; cv=pass; d=google.com; s=arc-20160816; b=WAdnPQMQ7WptqCQkmL+uFF78RPINDNfVJaCJ7lb66QSesDDEvV5wNS6tQwufBgo+HF 15WAlWCn7vuNIsYsrDtfSt0g9tCneSFXSMwXlLlnV6VEsBJ2JWqGMeB8X4WGbTBDC53X +Ilw4BctvyG1Id7U/7DeYlLU5BIJ8XGvqZUSy/zHXrEu4kzGNz7LIBNYp311X/p5iUrp 2s3mz7FYV+Jm7l/q5jKJULoXg4MfsLrGm+95w5v299vDaZyDOB3vnXrKEab2W0DUsrTI o+xRvDQWcFuX/0zrFaigLcTOHWL8P35zmWp8opMD0lPEaNwUQ6ZGAYCxCjy6nWIbaJRj 96dA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=k4/XzfxHm2HAV59nufUVMe2H7Iyjec3oXI258oBkEsA=; fh=4W5nlmHWNgkRztIfFSGge3ViKObSg62+1TVI5sAjYT8=; b=YswnT1ro+US89DA8eqG0JzicLK97ePwzSKPqh0j2/Ww2Vl1re7bF+KRU74/GL52Uvu 8qYTxiVY9FQUV1wtKs0ruERT+OV/9SJ7jjTzO/mN46zHJa/mNvjmqjI6s8UdpBUnXI+D mdRHoN3LTz2SraWTcFLtAl1OAX7JjzqlMz5bEday/c5bdZGX+I8drw5ELba8XvlaDfu2 /fT7elaNa98Ps3ggs54nYRHrs+KRrRFIXQKdfxHfQC5tLiNwCFy6nMHQnTCwqmk0FjQq NGOom0gb3yRnu5dXyGXViPzF9MUuOj0mS7XY/4Sl0ykhJ6Akfe25Dl+/HNjqoprSaaUb sEKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="J5pvVf/2"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-173377-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173377-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id k21-20020a508ad5000000b00572b83efd26si7378049edk.311.2024.05.08.07.01.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 07:01:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-173377-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="J5pvVf/2"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-173377-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173377-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7FE4F1F2768F for ; Wed, 8 May 2024 14:00:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 163C585639; Wed, 8 May 2024 14:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J5pvVf/2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21E7A26291; Wed, 8 May 2024 14:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715176805; cv=none; b=Q1/cXvUO4pj6bO5+raO+7cLnBM6QXKX5biRwPNIdG+Wyw5koY9OEZQaQrHNXe4PetXl+Wi/Utvd9JOiVYxBNH/dOuE0z9QhawKVRrFlRFPbZRkhW1psassveNKT0G+CRQwvzY0Gi6TbZtx4SY1f4P1y8O74Xp37xmKmm9VXJCZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715176805; c=relaxed/simple; bh=k4/XzfxHm2HAV59nufUVMe2H7Iyjec3oXI258oBkEsA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TTK9uIqpYv6cvn67BefLvSY8aIe6YF8tEkEx03fydCJqyhws2gV2ksjfmVTBFueLJdqY7S4DSN683WCWnKDGMskg4gkCQAvs+5M7NZiedCnZQTMYDaVB7Aa9btKfGG9T21tb7NcGVYidP2Cf5Ls/TTc4ai7uM/iYZKwSmRPzgaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J5pvVf/2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECCF9C113CC; Wed, 8 May 2024 14:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715176804; bh=k4/XzfxHm2HAV59nufUVMe2H7Iyjec3oXI258oBkEsA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J5pvVf/2/25oH20Wp+8UM3NI9VvyFNF9xzxQzAYiZ7bhv7EqRNqPZj/ahCuz0r6oq mx6ia0xOCwyBONjFaGGjG/x9Yn/ixG23LVGcNfskpCzzJruetudJJ2UWSSW7jDPM2m ljsmjZRCgB0F3+xHeXWGeMMWC3gHTMqD4cy002k0tgHnzfzmpUSJJvBPG3sKJFm4a3 mBylBci6We7oEM4mErgeSeeMAZ6Vuq6Zhoa6rym9918JFCNd1kedKuFewztKSoMf0p seVAZdMSzj+6LPs4J30quX1XI3M9f9F+3J7tcXnYgxGawaaRGj/nDqz5/OLo77KiAc Y3QGK9FaXVxww== Date: Wed, 8 May 2024 07:00:03 -0700 From: Jakub Kicinski To: Tao Su Cc: Andrew Morton , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, edliaw@google.com, ivan.orlov0322@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, shuah@kernel.org, seanjc@google.com, pbonzini@redhat.com, bongsu.jeon@samsung.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, alexandre.belloni@bootlin.com, jarkko@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h Message-ID: <20240508070003.2acdf9b4@kernel.org> In-Reply-To: References: <20240507063534.4191447-1-tao1.su@linux.intel.com> <20240507100651.8faca09c7af34de28f830f03@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 8 May 2024 10:55:05 +0800 Tao Su wrote: > Back to commit 38c957f07038, I don't see any advantage in using LINE_MAX. > Can we use a fixed value instead of LINE_MAX? E.g., 1024, 2048. Then we > just need to revert commit 809216233555. SGTM, FWIW. The print is printing a test summary line, printing more than 1k seems rather unreasonable. Other facilities, like TH_LOG(), should be used for displaying longer info.