Received-SPF: pass (google.com: domain of linux-kernel+bounces-173380-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 8 May 2024 16:01:30 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Bjorn Andersson <andersson@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] samples: qmi: Convert to platform remove callback
 returning void
Message-ID: <ealrtx5jnk43tt47rvjyipj2vr7f6noau44p5mw74invmb23oj@wvbovzbx54tt>
References: <d30beb557e0e97ea194028f62d3c4c10841d3e7c.1709886922.git.u.kleine-koenig@pengutronix.de>
 <g5iy5jov5uufi4oxdfgagqln6odwgdilrbbhsg3lkdidkvybbg@qbmsipcojt4t>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="m4oghvifu5wblbtt"
Content-Disposition: inline
In-Reply-To: <g5iy5jov5uufi4oxdfgagqln6odwgdilrbbhsg3lkdidkvybbg@qbmsipcojt4t>


--m4oghvifu5wblbtt
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Bjorn,

On Fri, Apr 12, 2024 at 02:20:12PM +0200, Uwe Kleine-K=F6nig wrote:
> On Fri, Mar 08, 2024 at 09:51:21AM +0100, Uwe Kleine-K=F6nig wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >=20
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >=20
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >=20
> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> This patch didn't receive any feedback yet, I guess because I used an
> old email address for Bjorn. I updated the address for this mail now.
>=20
> Would you consider applying this patch; please tell me if I should
> resend.

I intend to change struct platform_driver after the upcoming merge
window. So if this patch doesn't go in, please accept me sending it
together with the actual change to struct platform_driver to Greg.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--m4oghvifu5wblbtt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmY7hbkACgkQj4D7WH0S
/k7ugggAjUAp2rVIn3jp5rWIgRqZKk++gUBBMI67muZgf3E7t6W4M62OivR9Frli
ChqbfrudlzqZMhSnx0mWEBCqVC/Em9/YAdT9VSr6+sPH/WhZ8XcoqGh6aGLt/4rM
YYeoOKar8liBdHvP9rrWlSkDgLxzI6hJwvJmbkDMooFBT9yObNzeNUl622R4erNb
LUXp+RE6txHZ3Z8ru6P0VJHmytUm33QYXs9ziLu1iQFOFOvWuhCTvRgcKtCnIzz+
0oM2o7YlclU/YRwttHPjabum8jITp03UMEeJeE8rtFL+eaj9Mn3N0jpFI39jnVxt
HaG2ut+4A6c+KwnqdhWLmsshQH9bGQ==
=Mtim
-----END PGP SIGNATURE-----

--m4oghvifu5wblbtt--