Received-SPF: pass (google.com: domain of linux-kernel+bounces-173385-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3e10ff86-902d-45ed-8671-6544ac4b3930@web.de>
Date: Wed, 8 May 2024 16:09:00 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Jeroen de Borst <jeroendb@google.com>, Ziwei Xiao <ziweixiao@google.com>,
 netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Harshitha Ramamurthy <hramamurthy@google.com>,
 Praveen Kaligineedi <pkaligineedi@google.com>,
 Willem de Bruijn <willemb@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, John Fraker <jfraker@google.com>,
 Paolo Abeni <pabeni@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
 Shailend Chand <shailend@google.com>, rushilg@google.com
References: <20240507225945.1408516-6-ziweixiao@google.com>
Subject: Re: [PATCH net-next 5/5] gve: Add flow steering ethtool support
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240507225945.1408516-6-ziweixiao@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:37HGseiCCJg=;Bo90SZctH6Pl03ncbBVsfMAV1TL
 xCSXsrtfkfVPuudD6KhmGQGRFt84YDQHeoLhxC0r7UqZdEauv57IzzcxAwa3CFjXvYv2Xlc3q
 /j6nK1BYRbzIILfaUSaTbFgF/YvjEgy3PEkIXfXea5atvoaTCwzfKESJdzSUB3M6x2Ki/I5Ev
 6hxeEsRfY/eaJbzgnaZ1pvjVnNmbCF+eryh3mMNd6wnMGpLZK1fl8JG33dez4NnZV8sLMOODa
 BrbwlTw5vlwVoLiQF13v8a1wWiZCR5QndoqzdKD2fh3afkNyb3xF7RZ+gkIEMETVprJTqUR2H
 g80V8oPO5uIDKIN04d1StpO8safJjD4T9+kkJwOmXr4TcfIefhHr7dSFA4I3csCVug4ZZHcSF
 Ka9dChBRLffkYdnQOMrgn27L3favwBGyWQiqsuOTwFS4of/tq9zd9fC8x76DGrfQcnqAr9bPz
 i1S2pP3J3EdxPJ4SEVFnUyt2uQY7kX/md7nHIeKBZk8UIQFu0YCJtXjHXP00FxyZ6HTRthvf9
 roL/h09cG5v1RH0io7CefP+nEugOUOnRqT92aaylI4l0ooZl9k+i4kKRHzT0FXA7FiYp/IM6p
 LuZoiK0VZbaNU3OBGSyfIutiQ74lYuvnTe0xSVI6HCB71WECE1TssdvVDu2clWb0KNi3Ft03b
 9QKu3k2TXnLjasZLZokB55HaDFMqp0g4hykoQx9scDB3RxRukwtSeIeqsB6+Ml8e0R7nUQzs5
 1o5xWj6KeIDRw7KBVBW0FEU9oJjsx0T58zjxSquuhmzV768jcWW8t+66OmUgDSSNoUWVQIJ0q
 qroxQRLRYfj4UFHDCB+FMTYSiCt7s+v4vmu0XXDrai8C4=

=E2=80=A6
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
=E2=80=A6
> +static int gve_get_rxnfc(struct net_device *netdev, struct ethtool_rxnf=
c *cmd, u32 *rule_locs)
> +{
> +	struct gve_priv *priv =3D netdev_priv(netdev);
> +	int err =3D 0;
> +
> +	dev_hold(netdev);
> +	rtnl_unlock();
=E2=80=A6
> +out:
> +	rtnl_lock();
> +	dev_put(netdev);
> +	return err;
> +}
=E2=80=A6

How do you think about to increase the application of scope-based resource=
 management
at such source code places?

Regards,
Markus