Received-SPF: pass (google.com: domain of linux-kernel+bounces-173374-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 8 May 2024 15:57:55 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linuxpps@ml.enneenne.com, linux-kernel@vger.kernel.org, 
	kernel@pengutronix.de
Subject: Re: [PATCH] pps: clients: gpio: Convert to platform remove callback
 returning void
Message-ID: <v7sefhmq42ro2dfpxgipxxajxpuh3xy46c77uibmypyp34duqs@5vw5ava4ns7d>
References: <f4b9402af72e5f285c8b0f068076a76418f653f5.1709886922.git.u.kleine-koenig@pengutronix.de>
 <6d73b0a4-34e6-44ce-8757-4f4931c3da85@enneenne.com>
 <4iii7uxyfovs6ntm7hs2w546k3upbhkepgzxarjk4wnlqmeern@sh6gkyuiqpjs>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="l2exd44x4zpgzyxq"
Content-Disposition: inline
In-Reply-To: <4iii7uxyfovs6ntm7hs2w546k3upbhkepgzxarjk4wnlqmeern@sh6gkyuiqpjs>


--l2exd44x4zpgzyxq
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 12, 2024 at 02:26:48PM +0200, Uwe Kleine-K=F6nig wrote:
> [Cc: +=3D linuxpps@ml.enneenne.com]
>=20
> On Fri, Mar 08, 2024 at 09:57:29AM +0100, Rodolfo Giometti wrote:
> > On 08/03/24 09:51, Uwe Kleine-K=F6nig wrote:
> > > The .remove() callback for a platform driver returns an int which mak=
es
> > > many driver authors wrongly assume it's possible to do error handling=
 by
> > > returning an error code. However the value returned is ignored (apart
> > > from emitting a warning) and this typically results in resource leaks.
> > >=20
> > > To improve here there is a quest to make the remove callback return
> > > void. In the first step of this quest all drivers are converted to
> > > .remove_new(), which already returns void. Eventually after all drive=
rs
> > > are converted, .remove_new() will be renamed to .remove().
> > >=20
> > > Trivially convert this driver from always returning zero in the remove
> > > callback to the void returning variant.
> > >=20
> > > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> >=20
> > Acked-by: Rodolfo Giometti <giometti@enneenne.com>
>=20
> The MAINTAINERS entry for drivers/pps lists you as single maintainer.
> Who is expected to pick up this patch given that you "only" send an ack
> but didn't pick up the patch? (Or only picked it up in a tree not
> included in next.)

In the meantime you sent an Ack to my patch. Does that mean I can/should
include this patch in the series changing struct platform_driver that I
intend to send to Greg after the upcoming merge window closes?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--l2exd44x4zpgzyxq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmY7hOIACgkQj4D7WH0S
/k76Egf+LXTa3JOc5moyPTsiH03oXITiy/C2BSfJL0T1V6NP6vcbp4iOv/KK0NuY
WRrokUjCmTCi+K3YIZmtbkUOyk5XrI2K02Su16J86RCU+XJksoKRTAdGo3m+PTqr
ESJfPkPqkLJ4kwSJpLGPxrRJMVLKCWhgmvBYppCYucSxGxfxZcMleBrTnFFMdCPc
udupzK8vaprPVNKbAFfyOY7OazzsbopSaYGYPLBgrJVfUiJJmp1c3TffesEVZYKy
nFxZkD5Vo39w7s6sts1digxHTtCCVcx5fULfk1EhHIdbeolybYFkqEZiZE4sm9vC
tnxTQSblEBTkNNbRwBEuBiFnHpMlaQ==
=r0Au
-----END PGP SIGNATURE-----

--l2exd44x4zpgzyxq--