Received-SPF: pass (google.com: domain of linux-kernel+bounces-173426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <821d3abe-c15d-4118-9dcd-f4c1b71fddb8@intel.com>
Date: Wed, 8 May 2024 16:41:03 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: <linux-kernel@vger.kernel.org>, Tal Gilboa <talgi@nvidia.com>, "Florian
 Fainelli" <florian.fainelli@broadcom.com>
References: <20240508143039.1196671-1-andriy.shevchenko@linux.intel.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240508143039.1196671-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVZPT1paQW00Z25xSnNNNHExcUUwT0U4QVhJNXFpSXQyTE9pNzNWVGRUeDA4?=
 =?utf-8?B?ZUVqc0tpR1BNS25EdkN5a1ByeEoxNWw5SCsrR01kSG5pcUJrbGs0eUtidDNB?=
 =?utf-8?B?Ykw1eGpHM1BLTFhaamFScndrZ0tGTXZjalJucE5TZHM3RlJyMHRTYm5XZkpE?=
 =?utf-8?B?dnFpWDA1RHdnRm5tcmw3OXg3WjRYOWZsZDdQQkZKeFFId01rRWFwbFMwV1gz?=
 =?utf-8?B?QXE5K295T3VWdFF6M08rWndlN0p2SWJ3WmlqRkFaV0I0K0VkM29kL3A4MzJ1?=
 =?utf-8?B?V0NvMTR1aHpsL2g2NkpjNC9keHNITm4yZ3RuN3huYnJVOTJYRnZqckZIdFhq?=
 =?utf-8?B?MXVoTnpCUXNHZzdzZHFWaDVNRS9UdTd1NTRBRmN4OU9JclY0YW50b1M5VFE1?=
 =?utf-8?B?SmdhVVFsMExZclZsNGl4NDZsV3l0ampQSlVDbTdZeDl6OHJYTGxuUm54Vk5B?=
 =?utf-8?B?WUhpTEhOZERJc3VpOVhqMGtLdHRZcGxkTUdEOTJQYWdZK1IyWVY5b2xodCtY?=
 =?utf-8?B?emJmK0NSZ2JMUmVpNEdrMjZ0U0RkMklTaDZ6UGh1SGF3SDQrakVra2gxM2NJ?=
 =?utf-8?B?V211K0xNMEpCSklaeHJId2YxVGlxWFFpL3pSbG5GRUlmN2E4OUEySTA0OXBC?=
 =?utf-8?B?YXF2VlJQSHl6NVNwb2R1YjQyajNRa25zYVIwY1NYS3BwdkdBNEFlb1pUdTBK?=
 =?utf-8?B?KzlTTURYNVNlV0RNbFVkNDJBTSt2UWNCQmYxTkdXZ2JwbjROWjhBcFJObGNV?=
 =?utf-8?B?QjZPZkRVSG1idk9iMkRHRVlMZmlwbGlyQkFKOW5OK2xiMzF6RDIxV1RKMlFV?=
 =?utf-8?B?bVRzYVZ3SjdqSnZVbEFnKzQxZElpQUNPYUFzWG5VWktpYUNHUWtuOU9LS2Zr?=
 =?utf-8?B?QzAwYkREOVZkZm91eGM0MStERURiVUdjUmVHd0F3eGdDNHYzcFhhSlZWUFNF?=
 =?utf-8?B?ODVsdGQvNUJNdHhPMmowaEV3ZzZCd3lOVk9hc2drM1RMWDQzZmwvZnQ3MlNz?=
 =?utf-8?B?Si81TnVZQVZIK2dFbzhXVWdmTGhTVU5lcTJqc0lhdnVvb1EwOUV5M1NubFY3?=
 =?utf-8?B?UWlkQXFrVFhVbC9KeFdRQ2dhcnE0TVEybGRkY0RHamZNN08zZWh3am8xVStI?=
 =?utf-8?B?dmFockhrSCtZWWJ6WitDYXVwcHBERDBndjJFdmUxODJGdEhieXJNNXpaLzVn?=
 =?utf-8?B?N3RpcEEwVDBaUXplZmRoek5Oa0phR1lqeXYvU3lEOStvek4zdUxqS2FxL0pp?=
 =?utf-8?B?NkJjVTdBNFVMTmVYUXRaR0NuRXEzSGFEOFFMelBwQTFZT3luYnkzelJ2UVIv?=
 =?utf-8?B?UExnTUNQSVZVZFlTcnF1WnV3dSttbllPcDYrSlF2SU5ueGFqSG9HelJEMFFm?=
 =?utf-8?B?MGlNdEtwRjlrWDlwV2M1QURDcyt5a1BaRjU2bG5QbzR1NVVDQmEyT0FRVnJC?=
 =?utf-8?B?L3FqeWc5blZQRmxwcGZnOCtwT244aHNaaDhYVE90TGFBc3VnT204cGZpY08x?=
 =?utf-8?B?aFBVOHZEQTBlUVlrUXpoNk5hQjZ0WkZEWU9uYzFhbkd6Rzg5QVBhRUJ5N2tW?=
 =?utf-8?B?SXpEa2ovMldxc2JFOVVnRitLMUpBbHA5LzFCVUdkTE9Bd20yM21mMG9GdUhy?=
 =?utf-8?B?NGljL1oxbFJ4UE1PMENjVlNhRmhvTmFZTnlIUzFnYTVhOFZ6dmZ2RTFhWHYw?=
 =?utf-8?B?ZTlWd1pRY08xRFE0YlhWN0hJRmt2N2tjU1U4UFJNcVlzaG42cC9BbmNhcEw3?=
 =?utf-8?B?MitMc2N4S2lqMm1rRVVlem1HMkliYVVXaHJLN0hOMzRMcEcrTnoramU2UnVC?=
 =?utf-8?B?WTk4OUFTbjYxRjFITnNNejJmK2FEY3FWcGxnY1I3MjZLN1ZEejBWdXRNUUY4?=
 =?utf-8?B?K3ZxQTN0K3ozUVRpMzBnS2RSU3pLMDc5NkdXcVN0ZytwZDdZSjZVSkc0QlVF?=
 =?utf-8?B?S1Fnc3hQT24xTUdQTUlyVDJYdXc1VTBLOFhIbGN5VFJ1MittSHVRRS9xZTgx?=
 =?utf-8?B?QjlOendIZ0NUV095RWhjR1JQZnF1VDZqUCtzMEsvZzU2SmVyYXp5ak94VUF3?=
 =?utf-8?B?dWdBbzJKVUV5NVREeWlJamNiMlFFbEpDbTd5d0NrWTRYQUE1Zk80Qm82SjZH?=
 =?utf-8?B?dDlzNnVLa25DRmN2STNrTCt4VEpBdDRqTndMTm5SZmw3aGh3T25GR1krWVVV?=
 =?utf-8?B?L2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e318c87e-55bd-4b56-87c4-08dc6f6cf085
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 14:41:26.4438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mKy2ZwKNl9OO308GaKbUWMWLCPgHBAL6JHSxNNIpi0vE1ilj96Z71ptwNgFH7N+T7fEkcuo3b3wPeXXmCuULtrz/oGJEa+tsvlwj+xbs6uk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6094
X-OriginatorOrg: intel.com

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 8 May 2024 17:29:42 +0300

> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
> 
> Reported by Olek. As I said him this is correct change which is
> documented in Documentation/kbuild/makefiles.rst "Composite Host
> Programs" (mind the meaning of the word "host"!). 
> 
>  lib/dim/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index c4cc4026c451..5b9bfaac7ac1 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -4,4 +4,4 @@
>  
>  obj-$(CONFIG_DIMLIB) += dimlib.o
>  
> -dimlib-objs := dim.o net_dim.o rdma_dim.o
> +dimlib-y := dim.o net_dim.o rdma_dim.o

Thanks,
Olek