Received-SPF: pass (google.com: domain of linux-kernel+bounces-173425-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <4038b9d4-6618-46cc-bed8-a0ccd1c92cd2@intel.com>
Date: Wed, 8 May 2024 16:40:23 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in
 Makefile
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Jacob Keller <jacob.e.keller@intel.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, "Richard
 Cochran" <richardcochran@gmail.com>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>, Jesper Dangaard Brouer
	<hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>
References: <20240508132315.1121086-1-andriy.shevchenko@linux.intel.com>
 <6ac025de-9264-4510-ba7f-f9a56c564a80@intel.com>
 <ZjuLW8jA3MuT0oih@smile.fi.intel.com>
 <5ab7ae5c-79d2-494e-8986-d18d4a8e74bb@intel.com>
Content-Language: en-US
In-Reply-To: <5ab7ae5c-79d2-494e-8986-d18d4a8e74bb@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0J3Qy95OFBwckZVZ0RHb1pTL1R3d2pMdk5weDlUV2I2YXcvaHExSmRkd0tn?=
 =?utf-8?B?ME9LdzNFcHl5djk3NzFrcU9MYXdrNE1NeSt6bHE3YkQybmVBZ2Jzc1o4T3da?=
 =?utf-8?B?am9DM1lVQ0FEUzNWN1VVWnhXVGh6WXh1bFoxYVhVT3QyemY2cWR2cUtGRjdj?=
 =?utf-8?B?dFhpVTg4L1lUZDlwdERUTkVxTVgwQnRrSDNhOTFaSDlzaTlrMXAxb2tGMm1O?=
 =?utf-8?B?dENVaXZzTlozQm11enhESloycGkybnVJR1pNaS9uSmtTQk55WDVJOUZSeDd0?=
 =?utf-8?B?L29sUUd1dUh2QyszSWZyZUtmM1dBdjh0bGFzd2hiOXpRMEcwZzVyVHdOOHJx?=
 =?utf-8?B?S294S28rOTQ3ZzlKMUM4MzRJUVBRaHJlZVJvWlVFVXZJWDdoY0R5cS9QQ1A4?=
 =?utf-8?B?aXRIZDR4ZWFBb2o2Q1N5Q0RPa08zZHhrSkdwZ1p0UGEyRHIrWmZhcjJQM1E0?=
 =?utf-8?B?YXlKMlhaQzN6N1lscTE1a0pidWhUZkFYNkJkaVdZYUNzMjNyc2lFSzJZQmRj?=
 =?utf-8?B?RWhnSEkrNEY0ZW43a0YwTkVleU5QRzhES1JZcGhtelpRblRiMWlRVi9nTENj?=
 =?utf-8?B?dXpzQzhDNHVEeitwSWpYRUFYd0h4OWRzeFFWK29XU3N2UGZ0RjUxRGxyb1lY?=
 =?utf-8?B?M1NUTlY2SmZKcGdXYWlGZ0VtWks3N3ZOVUVJbWJpYVMwWUFEMUk4SUhTWDZE?=
 =?utf-8?B?TkFyakhSNCtOenN6YUl6dmx6dmw1UUNIazJwYTBUVWw1bTZOU1Rmb0czbEdJ?=
 =?utf-8?B?eTBPSWNMMXV3RkMxTlNwd1JGY0FWMmFuRmd1Y0VsQlRiVHdaK1dYdVN5NmVv?=
 =?utf-8?B?dWdJbDY0KyttYU9iOEo4WlVhWnFQYXUvYS9mZ3JvYTZ5TzhmTnFvYzJGZG9R?=
 =?utf-8?B?SWFkczRxa0lTRS9LM0NBVEhSOW9rYzlwa0EwUlBZQXI2QVNncEZSa3ZGSmU3?=
 =?utf-8?B?K3FHY0VobzRRMzgvR3ArcjB4dGM4THl3cFR3enBrVlJibVdGZ3dnOSs0TzQz?=
 =?utf-8?B?cnlkWWJYR0pNeUNUeWJJVm5tTUxUNFBBcHJ4UE5Uc3Z4dFFheE82MEtoOWdS?=
 =?utf-8?B?TXlQRUtJd0xFK3RkMStMNnBqSWtmZ3FmdGRrSHdKZERISzFiQk1FcGI1VzA2?=
 =?utf-8?B?bnN0K0ZDMkhKMEE4Tkp4dC9qa0dseWRtS0laT3MxL2gzaEk1cFhLRVM3R2dV?=
 =?utf-8?B?RWdwQTVyWDdMTHM5Z0NqNzlCR0EvclczV3FrZlFyd254UDBvUzN0RytZT01s?=
 =?utf-8?B?cnFMRmgxMjhERytwam9kQmd5T2xsUllTUW1SdzdyS04wVkhYZ0NXRzhZUkky?=
 =?utf-8?B?M1ZxeWRzNUo5aGNJZ0w0OTFRRjhpZmJsM2hTV093MjJVN1RueWVMNEdFdkFR?=
 =?utf-8?B?NzFpOUR4alBzekU4QnZJS2JNT016RllRUWFrdzJTYzN5U2N4eHVIZUZuaDFy?=
 =?utf-8?B?ek42U2NtOHlDWDQ2aE1FRU9ITTRzaDNXcVN6UGRoOHZpcjErOXpaVCtWQXBT?=
 =?utf-8?B?UnFJc2xTK0lSUEpHcTFCUGFmL1luZkRycVgrbHdFQmhuVi8vM1pNd1RLY1Yy?=
 =?utf-8?B?YXVVVVFLYkdKb09rNUg4ekt5S0xLK1JuaXgrMGdsWDNVMVVmWUdTOWlPWHpK?=
 =?utf-8?B?SERtTUl6eGlTdTBUK0JPMkNzdWNFazgwSytEb3lZcnJ3c3RCRGdza3dYRmdi?=
 =?utf-8?B?dmVDZDBvd3cvN3ZYako4VmxGbURJTm80MWtzbkNpKzVrS2syM1VYVU1OQWRC?=
 =?utf-8?B?czdkc0FHcy9Ib1VoQ2o0b0x0cEhPRGVXbTVUdkJidTRFSE9BMy83Vy93Sk5s?=
 =?utf-8?B?WTFUazFLaEY4bkl6VWw4K00rMDlWeDdlOUx6WkZmVGxpOFhNVlBjWkZOcjQy?=
 =?utf-8?B?TlZrS0xhZHFLalBQSEMvVFlURW5oZDZSV21VTGxYQ1dxMjdSdjUzVFR5cUpz?=
 =?utf-8?B?K1ZsaER5Y2lhRmE5UFRoUGhRSjg5MTBOUjZMUkQwNXdJRzJmN0U3eVRMeXJ1?=
 =?utf-8?B?UXVCV20xV2JrL3ZuVVlUS2IzNlJmbk9uQTRaNFJSdWVGdWgxWFlEaVZJUmRV?=
 =?utf-8?B?UUFvdE5ramN5V21SS05rbXBQUnJyNXI4NnpFcFMwYWYvaERhMm10QTlHRWRj?=
 =?utf-8?B?L0tBUFhLa2NyeUI0VGdSeS9abXE3MmtFOW5JR3JGaWZxV0JpQ05jNGtjZEIy?=
 =?utf-8?B?UFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 435d835a-ad3b-4296-3c7b-08dc6f6cda5a
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 14:40:49.2915
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HA1d+LKjEpqUwyaCTeymAsVqvPfauQk6sNMiFPkAB5zzPD/4ZtStA8g0X+cp6VWsWEH1ddJyIpfbJ3k5moiz9Z3aF6H0FHDTg6CNdE8fzPg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6094
X-OriginatorOrg: intel.com

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Wed, 8 May 2024 16:39:21 +0200

> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Wed, 8 May 2024 17:25:31 +0300
> 
>> On Wed, May 08, 2024 at 03:35:26PM +0200, Alexander Lobakin wrote:
>>>> *-objs suffix is reserved rather for (user-space) host programs while
>>>> usually *-y suffix is used for kernel drivers (although *-objs works
>>>> for that purpose for now).
>>>>
>>>> Let's correct the old usages of *-objs in Makefiles.
>>>
>>> Wait, I was sure I've seen somewhere that -objs is more new and
>>> preferred over -y. 
>>
>> Then you are mistaken.
>>
>>> See recent dimlib comment where Florian changed -y to
>>> -objs for example.
>>
>> So does he :-)
>>
>>> Any documentation reference that -objs is for userspace and we should
>>> clearly use -y?
>>
>> Sure. Luckily it's documented in Documentation/kbuild/makefiles.rst
>> "Composite Host Programs" (mind the meaning of the word "host"!).
> 
> Oh okay, I see. `-objs` is indeed only mentioned in the host chapter.

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Thanks,
Olek