Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp561031lqo; Wed, 8 May 2024 08:06:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWx8awyOcp1hZruMFewyK//tzDy6UQKEqsYTbzUvKF6E0+rfk22rk3SI2G+II4J0PVEA9y/HdIwaNkAnQfWJTJYaylRLjcr7hMqeLKsEA== X-Google-Smtp-Source: AGHT+IH7rVeb5uJ121I/TaLibyLv/bssKjZxK7OeLeHaRT74F0KcJBUhSJBgGqHPUeaM4BbzvfyT X-Received: by 2002:a25:ac20:0:b0:dd0:97e8:74e6 with SMTP id 3f1490d57ef6-debb9e4d3ecmr3053288276.55.1715180779444; Wed, 08 May 2024 08:06:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715180779; cv=pass; d=google.com; s=arc-20160816; b=d51UvtQ0QLE6eAZVKpRZHTHZdxS7mz4b/bgCfIgOlQIPQqNEw8f9ZmdSUgF7kQHPO5 9+o7I45IpCePRgb7YsmkZCWacsWPXPHcDb4OTyUFB9DXLRHjpfpRYCHN4hRAKK0rmQML ysj1PnOitYmnwfqr39p6ot+0CG8FPypYKi946pH/PkYlCM6aPnuiICmoYKsCdNML2hC7 Jb+uaJpo2qP/3QeBv1tL0GOXKL04l3JG7qtkQEomALYMBMkcoIBq/CpI1KDIKPPW9b/k jXVqPlVZ/M0dqEO2QqOlHdn6t+xRu2j7lyY9JhTRyuwLFtVPta1TJ5ZT/dijxJmjPbr5 fapA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=+U5WOXHKUq5uFxbYVCtgzret/BCB2H9tdTIlQlVV7vo=; fh=9teDWdDZNTiVZ12bjRpD+ezeWG788ktACEroBA+2q/Q=; b=PhK4lTxHshk5MKcNmOb24yfzJFwYbZxvxmxDp+YEtB5y8bF8CtQccUyRXYKyM/aV1E cqQfwgC1N7kKWQFxM2j49KZQWmXpc699HmWS4fVeHaLy3O5JHQENUQ9zhGa77GLC14wD bJReUpmFyHbDUW2qhIQdlvn1Eg//OLkGS5gLliXD9jpqmDkTkzJRCezIAITEN0XHF95S Ri4EX2ztnk5rC/V1YnWo8byqeCYmjC6PfBUj8bB1wdiN5zZeKCAV2K1CjDx1YqO2iT+X +VbmDv86IRrCNSxZlj5gxxAUp0HacVwAwU9FJtWyW3B6o27BtJ1pByis18hF7aAIIW5w rBqA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lC+Akvw8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-173452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g33-20020a25ae61000000b00de60bd0410esi5251850ybe.102.2024.05.08.08.06.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 08:06:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-173452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lC+Akvw8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-173452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BB7301C23BDD for ; Wed, 8 May 2024 15:06:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EC47086AE5; Wed, 8 May 2024 15:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lC+Akvw8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EF5C69D29 for ; Wed, 8 May 2024 15:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715180773; cv=none; b=h2IY4X6SLpoJht80RVMnIwU7ENPn+wIagX/L1S7UKPBMSfTt1aQ4eBDqgkFUF1Zx3aDpx6EPyrDgR4S3RjczlK6Quaft22RyDfDKUOFHOr227qBmSq3wHZ6NPrSmtqIzSV4506t7t9pW9W5+3PjsJgRN3X+hBJ59O64acapA8nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715180773; c=relaxed/simple; bh=Nz+Ol3vDINwnuP6otiaKVduS2hEYhg4Wrkrvo4FR4qI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uL6bdcs5AT87nzp66IrBVhRGqLj8oG6sjC8c1DUaOJJfDBNSObGyEnxL/tKHV9GXskR07nmLYjhsg0FeHM4f/rVxtl5b6YJEETaj6E5ahR4FvkTvSX/9jzONpAwEEOt3hO0oEEzYbzuOasfJG7JHirQCEFWgINWKMuL0H4gEpf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lC+Akvw8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91BC8C2BD10 for ; Wed, 8 May 2024 15:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715180772; bh=Nz+Ol3vDINwnuP6otiaKVduS2hEYhg4Wrkrvo4FR4qI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lC+Akvw8dV6t4qfe6Nkt77+WkF/akNWt5CcuHD5E180y42aZOTMqm8X4lBJkm4Isw HAOSBgxq3QXI1M+ZGdPuHW361X6TC1jJ5PRaVGykyyC5j22gUdqTbuDT96Cijhmkyh HRTLA0dBHYlFm248NYT/i+NS+AA+++7lbTppiVVugl9b2/R2LhqIywUwKq93Iu29vD gN/kfPrscSbPQuBSF6qb0XtWHA0mn8iLtAC8Xq30Ak7s1iBcx1GKIqoWBKSsmRZbru WNyoa9so/QgOr1fNRs/Ep821vi8LGsCxDDMiGo3BqjReCfMCMwGJDs9ZlyWGV+mkxE mmW54hbAYGwOw== Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-5b206b78b47so1713722eaf.2 for ; Wed, 08 May 2024 08:06:12 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUlppiS6TonLvqnE1GfSjPa2cT552twYQWsqxmfBzhEfJ163y7tk/lOpZGcY15j2OlYzkOcjs8PyVnWmELNpibjhwVWL4B5s76k10Ae X-Gm-Message-State: AOJu0Yw58Q6jyC0oQCy9BaPUgYVhyw27ExycEaUrpK+Q8gTTGqBP0QpS Fm/3/SJw0E4mLmLCMsPL5uf9j5fIa1FxS+IvJQYdo1HkJWT56qMfwVtN0x1dsbp/Ic+DBS5Xqge 6K9aW2pPfE7vzeyK7X3DSpa4FGUc= X-Received: by 2002:a4a:8c6b:0:b0:5b2:ef4:873d with SMTP id 006d021491bc7-5b24d62e22dmr2550971eaf.4.1715180772008; Wed, 08 May 2024 08:06:12 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240426100054.61506-1-yang.lee@linux.alibaba.com> In-Reply-To: <20240426100054.61506-1-yang.lee@linux.alibaba.com> From: Chanwoo Choi Date: Thu, 9 May 2024 00:05:34 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] extcon: adc-jack: Document missing struct members To: Yang Li Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 26, 2024 at 7:01=E2=80=AFPM Yang Li wrote: > > This patch adds kernel-doc comments for the previously undocumented > members `dev` and `wakeup_source` in the struct adc_jack_data in > adc-jack device driver. > > Signed-off-by: Yang Li > --- > drivers/extcon/extcon-adc-jack.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc= -jack.c > index cf5050a244b2..125016da7fde 100644 > --- a/drivers/extcon/extcon-adc-jack.c > +++ b/drivers/extcon/extcon-adc-jack.c > @@ -26,6 +26,7 @@ > > /** > * struct adc_jack_data - internal data for adc_jack device driver > + * @dev: The device structure associated with the adc_jack= . > * @edev: extcon device. > * @cable_names: list of supported cables. > * @adc_conditions: list of adc value conditions. > @@ -35,6 +36,7 @@ > * handling at handling_delay jiffies. > * @handler: extcon event handler called by interrupt handler. > * @chan: iio channel being queried. > + * @wakeup_source: Indicates if the device can wake up the system. > */ > struct adc_jack_data { > struct device *dev; > -- > 2.20.1.7.g153144c > > Applied it. Thanks. --=20 Best Regards, Chanwoo Choi Samsung Electronics