Received-SPF: pass (google.com: domain of linux-kernel+bounces-173501-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240417044459.1908-1-linux.amoon@gmail.com> <20240417044459.1908-2-linux.amoon@gmail.com>
In-Reply-To: <20240417044459.1908-2-linux.amoon@gmail.com>
From: Chanwoo Choi <chanwoo@kernel.org>
Date: Thu, 9 May 2024 00:42:50 +0900
Message-ID: <CAGTfZH08WoMpBxw6JRsjobYsh-e1CAuddwp4j1DQOTTvAwtS=A@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] PM / devfreq: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS
 for PM functions
To: Anand Moon <linux.amoon@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, 
	Kyungmin Park <kyungmin.park@samsung.com>, Krzysztof Kozlowski <krzk@kernel.org>, 
	Alim Akhtar <alim.akhtar@samsung.com>, linux-pm@vger.kernel.org, 
	linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 17, 2024 at 1:45=E2=80=AFPM Anand Moon <linux.amoon@gmail.com> =
wrote:
>
> This macro has the advantage over SET_SYSTEM_SLEEP_PM_OPS that we don't
> have to care about when the functions are actually used.
>
> Also make use of pm_sleep_ptr() to discard all PM_SLEEP related
> stuff if CONFIG_PM_SLEEP isn't enabled.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence
>     change the $subject and the commit message
>
> v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM
>    is disabled
> ---
>  drivers/devfreq/exynos-bus.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 153340b6685f..b89e04eb8430 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -454,7 +454,6 @@ static void exynos_bus_shutdown(struct platform_devic=
e *pdev)
>         devfreq_suspend_device(bus->devfreq);
>  }
>
> -#ifdef CONFIG_PM_SLEEP
>  static int exynos_bus_resume(struct device *dev)
>  {
>         struct exynos_bus *bus =3D dev_get_drvdata(dev);
> @@ -482,11 +481,9 @@ static int exynos_bus_suspend(struct device *dev)
>
>         return 0;
>  }
> -#endif
>
> -static const struct dev_pm_ops exynos_bus_pm =3D {
> -       SET_SYSTEM_SLEEP_PM_OPS(exynos_bus_suspend, exynos_bus_resume)
> -};
> +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_bus_pm,
> +                               exynos_bus_suspend, exynos_bus_resume);
>
>  static const struct of_device_id exynos_bus_of_match[] =3D {
>         { .compatible =3D "samsung,exynos-bus", },
> @@ -499,7 +496,7 @@ static struct platform_driver exynos_bus_platdrv =3D =
{
>         .shutdown       =3D exynos_bus_shutdown,
>         .driver =3D {
>                 .name   =3D "exynos-bus",
> -               .pm     =3D &exynos_bus_pm,
> +               .pm     =3D pm_sleep_ptr(&exynos_bus_pm),
>                 .of_match_table =3D exynos_bus_of_match,
>         },
>  };
> --
> 2.44.0
>
>

Applied it. Thanks.

--=20
Best Regards,
Chanwoo Choi
Samsung Electronics