Received-SPF: pass (google.com: domain of linux-kernel+bounces-173510-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <046082f5-0d6a-4df3-b0c7-49938bcd872d@amd.com>
Date: Wed, 8 May 2024 11:51:02 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
 avadhut.naik@amd.com, muralidhara.mk@amd.com
Subject: Re: [PATCH v4 0/4] RAS: ATL: DF 4.5 NP2 Denormalization
To: John Allen <john.allen@amd.com>, bp@alien8.de,
 linux-edac@vger.kernel.org, tony.luck@intel.com
References: <20240506154605.71814-1-john.allen@amd.com>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240506154605.71814-1-john.allen@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NCtVZ29LRjM4NEpMZmRhUlJCN1F4K25vdnM4Y1ZpZEozSVJJZXM2ampyY1pV?=
 =?utf-8?B?RVJPVzB6OTU0dlRLYWw0aG03NXRUcTJTK3RPa2RtMHM2RDNDN05WRUJqWC9I?=
 =?utf-8?B?MWJnK1hFS3ZvNHFmalZoS2tIZVVBMDFsaDI4eXZDVzRUUDZLd290ZnE0ZmNW?=
 =?utf-8?B?V3BPRUloTEozWmxOZUNzaVB0bDVZNTFZaFRIaFo3WU1LRDI4ZU9ESnRTcWtk?=
 =?utf-8?B?MnR4SXdhcmkxSHBGMkxYK21JOFFRQ2FpdldYUUFZSmF6UW1WL2pnb2lmZU42?=
 =?utf-8?B?RWdDSXpJa2FGOXltdGtCaWhxMnFLZmJmWXZ5TFF6WldSd1Z5bmZ2elNlOVA5?=
 =?utf-8?B?OWhQMFRkWGtXamhxRXdxcHI5ZndQZG5MeUZJMUwxOUNvZVBMTU5XSmU3aDZY?=
 =?utf-8?B?ZXNWT21ybXE4SkhrTjJlYXllSnVieUVRKzNsYU96bXEzRVIzbllGUHFuQ0k0?=
 =?utf-8?B?bUtyWlZvMjZsRmdQK245alU3bExTWG92bkdpRzYxeHFENG56d09MaVduRjJN?=
 =?utf-8?B?cllSL1BBaGk5a2N5eXE4blNrSXB3WFhHSXRNSzBCckFoMG9TbUpCNzB1Ny9H?=
 =?utf-8?B?SGd3ZlZWN1JoWC9CRVFEU3V0NTRPYkVNVC92NW80UnhuUkR3TE15YzZ4dXcx?=
 =?utf-8?B?Q3U2SVFTc2tkTGt5TEhYS1JDU3pXeHYrVDQ5WjkxVFF0QVA1aHpnMndOdmdq?=
 =?utf-8?B?Vm03dDAwNU9TNHBHNU1jRmVQZkFjQlprNEpSVXBPNy96WE5zQ2YrK0JyTXdC?=
 =?utf-8?B?UkVKMlRUK3ZDOEtzL1prcC96TjFtZGxzYm5WUTZkWUZRNXVmYW80UkVZV0Ex?=
 =?utf-8?B?VFdQK2h2RU9qMm5JTE9IWG82MFRIRXJUaDlibGFGZ3RHMWg2RFZiSXd4akdS?=
 =?utf-8?B?dEg4Z0g1MThDQ21hNmdyODMxclZQb3pUQittdlVVc0NCMHRSanZwRFhsVTQr?=
 =?utf-8?B?anZjQmlrMElNanpDZXJLLzNFRXZsT1NES0tnWmx1UUFMb3ByVHEzRExvc29a?=
 =?utf-8?B?Q2JxcU9VYzFac2ZhWEhZb0ExT3UzSGZJNnhLRW4zTTZvZ1E0dzRVYmFCOEIz?=
 =?utf-8?B?eDVFbzdYRjBKeGlDaWxFZHBMeEN3TnFTQ3c5ck1KVFdId09IRUNSTnhscnY1?=
 =?utf-8?B?TDBobUFydzhGcFZWUytiKzlyN2dhNDk5dHo2dU9HTW56VzZkY2t0cGw5QzU4?=
 =?utf-8?B?QUFmckNSZU1oQXlnWnBoUTRleWVweFRySnF2SWJvQ3AyWW1Hc3RaQXlCWEYv?=
 =?utf-8?B?eW1aTm5mWkJmWmcxRjF0S2dhUGVWQ2VSMy83ZnppVTVTTXVRWnNNdVZKSFB4?=
 =?utf-8?B?Z2ttOXUzSUsyL3hCNmE0OHJqSUNKSDZHNE00TlJSU29ScG1lK1BYQk1vR1E4?=
 =?utf-8?B?L3pkb3NlTWx0SEV0QWFYQ2IwTHVoUEQzam56MGRBeXppYWlJejcwRHZzdG95?=
 =?utf-8?B?Z2xuT1dBbE10cEVWR0Z2TEpYaEk2dHNOM3VSWTM1c21NN0VxUG1ndHNXUDUx?=
 =?utf-8?B?dUY2MEMwNlQ5SWxjdWtVeGJTV1Vhbm5HazdlOHJIeDA3cXZGUkFPUUwwZmk3?=
 =?utf-8?B?QVZsZTdBdVJKVTF2NElmbmhseWRKUmNMN1F2NzUySTdoMTNsMmcxQ010Y1BN?=
 =?utf-8?B?MDBXMThZZVdHNEsrQiszekE1TFcrQ1JzRGJIUHptNHhBc0c5OGN2T0pmQ3Mv?=
 =?utf-8?B?YjN0UzFxaG93dG1JNUFyUk41U0R5OEhMaldjaThWT0ltbXJXc2NESW85WTVN?=
 =?utf-8?B?dDhlRzZRVGRTL0RrdUlwalM1cGtkNGFkS2xPUVViUERKZERDRGlsWXR5S1Qr?=
 =?utf-8?B?b0JEWXFlZ0ttbitwVkVRMkFvY2FSQnZtTVM5VmtRVU9OamNod2c1QzRsZVNB?=
 =?utf-8?B?MkNGVCtHSnZwb1NqaEcxYXRvUnArM3l2Y0pkcnF0WldJajRVdXlWNFlna1Jh?=
 =?utf-8?B?MWtneFNHcFpmR09MWkp2Q1BSdTBxWHBFNW1jRTFpanMwQXEwSmFtUitRcmZ0?=
 =?utf-8?B?K0p0aUVtR2VsQ1B3Zy9TaDkzVS9rL2pxb08rWGM3WVU2bjg4SXRQUWRPVmYz?=
 =?utf-8?B?WE9vR25QZVJtTjYrYytoc1pVT3YvdzJDcEtBSUZUZEhDK1BoaU9saDk1ZjlI?=
 =?utf-8?Q?jjgO7kSRJAvXBYJlWnRCBlTZm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6f7ed5f-6dc5-4279-ae52-08dc6f76ab5a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 15:51:05.2692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9tOiRCxWeA4Z1F9+L2uiXCHm+8y7fMLiEgNiOkdcn1uwdqlDw7zagZHs36aDqJEq8inDjInrO/E2TFtSQVn00Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5821

On 5/6/24 11:46 AM, John Allen wrote:
> Implement non-power-of-two denormalization for Data Fabric 4.5 in the
> AMD address translation library.
> 
> Tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git
> Base commit:
> bd17b7c34fadef645becde1245b9394f69f31702
> (origin/edac-amd-atl)
> 
> v2:
>   - Fix compilation error.
>   - Make remove_base_and_hole the inverse of add_base_and_hole.
>   - Move all map validation checks to validate_address_map at the
>     beginning of translation
> v3:
>   - Fix bug where the legacy hole was not getting removed properly.
>   - Minor rework of functions for matching the normalized address and
>     logical cs fabric id.
> v4:
>   - Merge common cases in map validation function.
>   - Fix map validation for cases that don't have explicit checks.
> 
> John Allen (4):
>   RAS/AMD/ATL: Read DRAM hole base early
>   RAS/AMD/ATL: Expand helpers for adding and removing base and hole
>   RAS/AMD/ATL: Validate address map when information is gathered
>   RAS/AMD/ATL: Implement DF 4.5 NP2 denormalization
> 
>  drivers/ras/amd/atl/core.c        |  48 +--
>  drivers/ras/amd/atl/dehash.c      |  43 ---
>  drivers/ras/amd/atl/denormalize.c | 523 ++++++++++++++++++++++++++++++
>  drivers/ras/amd/atl/internal.h    |  45 +++
>  drivers/ras/amd/atl/map.c         |  97 ++++++
>  drivers/ras/amd/atl/system.c      |  21 ++
>  6 files changed, 711 insertions(+), 66 deletions(-)
>

This set looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen