Received-SPF: pass (google.com: domain of linux-kernel+bounces-173513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <63894ef1-c482-4646-8351-4d6cfc6c528f@amd.com>
Date: Wed, 8 May 2024 10:53:22 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: RE: [PATCH v5] platform/x86: dell-laptop: Implement
 platform_profile
To: "Shen, Yijun" <Yijun.Shen@dell.com>, Lyndon Sanche <lsanche@lyndeno.ca>
Cc: "pali@kernel.org" <pali@kernel.org>, "W_Armin@gmx.de" <W_Armin@gmx.de>,
 "srinivas.pandruvada@linux.intel.com" <srinivas.pandruvada@linux.intel.com>,
 "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
 "lkp@intel.com" <lkp@intel.com>, Hans de Goede <hdegoede@redhat.com>,
 Matthew Garrett <mjg59@srcf.ucam.org>, Jonathan Corbet <corbet@lwn.net>,
 Heiner Kallweit <hkallweit1@gmail.com>,
 Vegard Nossum <vegard.nossum@oracle.com>,
 "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Dell Client Kernel <Dell.Client.Kernel@dell.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240501215829.4991-2-lsanche@lyndeno.ca>
 <BY5PR19MB392256C65661E76FC292C0889AE52@BY5PR19MB3922.namprd19.prod.outlook.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <BY5PR19MB392256C65661E76FC292C0889AE52@BY5PR19MB3922.namprd19.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MFJqQk5MSTlyeGl0ZkYrbEdTRW1CQ1YwWXdzTi9KWXF2OWtvNTNVZDhXUldK?=
 =?utf-8?B?L0V1aG5RMkpDUVNsNDlCM0lxZHJkZkNOQVQ1T05hUnRWczNUVEdCbHhLWUxy?=
 =?utf-8?B?LzAzcTlDUjlickFxcm8vbkQ0YjFoQVlJUU05QUVJWjRoWjZRR2ZZQUdmbmFL?=
 =?utf-8?B?bXQ3cXpYQnd6RXpnc0VNK2M5b2lESit4TVAxSkJIQWh5ZjhRcHM3YXVWVHRa?=
 =?utf-8?B?K3o5SkM0cmthS0NwWDVibytHQWwyczNsVmpIUDZURVNoTzB0TlIrTEg2eWRM?=
 =?utf-8?B?T2ZadHBvNUZ4QW8velBQZHlXa2VLQUZGT1RpVzlmRVo2TTdtS3pjdk14QllF?=
 =?utf-8?B?b1ZocFZCUEdFeC9Ubk01aGlEL3FuRVhUQnRNNklPd0NJMllBajk5VmlmdjJI?=
 =?utf-8?B?ZHdMeG0ySE9Jd2luNHJDUDhhVEYzZTIrT3JjWHQrWkJtamk0MzlacDY4MFJW?=
 =?utf-8?B?THlOMEpyK21Dd2Q1UVcxb1B4VXdWQ2lKeWhXTEJvUTdrd3Bnb0hObkNab0c5?=
 =?utf-8?B?aFFKWnY0b1pvbHNtQjhINXZQd094Rm9nN09kWGpMZGhZbklQZ1BmWllUbFlB?=
 =?utf-8?B?ZC9kUmZyUEVDdE45L3FZYkhzZk1OeXVDeDg2ZDh1SWtFa3JYUklWVEpRcWx0?=
 =?utf-8?B?M0NBQU9SOFFUS1huT3VjMlVtbzZGMDR2Vjg4U3FXZURVVm5XZlc5V2FJcldJ?=
 =?utf-8?B?ZnRzVTJoNzE4d1JRV3RtelZPWG5lUUhkU3pzVGVveG92S09YL0VYRnBJYS85?=
 =?utf-8?B?emQwSFZzSHN4OHRvREY1LzVrbWZHdEx5eEo3MVAzWHJMM21GS2pieXNlTUFr?=
 =?utf-8?B?ekxFcnlKM2FJdWNtd2Fqb3RNNExidnJLQmxRSTBaUWt1bDM4V3BmczdYM2Zv?=
 =?utf-8?B?ZHhBc2wxVlVjb21xc0wzQ3ozNXo2bjd0L2Z2WElrZ2VkN2VVUlJENm1hWW1s?=
 =?utf-8?B?cnRaMUZqQnpUS1AvUUo1TzZERnhnLy9FcHdxem5GMGpQRnBzNDFYY2xrTlZQ?=
 =?utf-8?B?T0diejhqSlE1L2k0QU1lTmhSa3ZHVG1uaFowUHc5Tk5uVjdmVUI4TDF1eUNV?=
 =?utf-8?B?U0lIMXBWdXVkbTdMVDNPMlZqMUVwbTdtUUhuSERwNlpMUDJmTEJ3NzcydVBR?=
 =?utf-8?B?T2Q1VklLaENvaW1DbUFYRytrVy9hbVJwRmNQSmM4em9QMG9WL1JrT2FkalZW?=
 =?utf-8?B?M0UyQ0lPTEs0K0padmNJc0VsUzlGR2VQZFd5Z2ZCVmx0NXdaRGRqaStJWlh3?=
 =?utf-8?B?Q3V4MGFBbjJQM1dSVkxBYi9nSE5NdVR2NG0yQXZualVIaEFFcStJNW9lTy9I?=
 =?utf-8?B?M1grZ2E0a25meStoak4rZzhXenIrdUtMMm9QbTNPN0JJNkpQTDdxTmYwNWZD?=
 =?utf-8?B?YldVTmVaNDk3QnNIejlDekZHeWhTRk8yV0dSbHczZkpETUJ3ZFE2OVgzT2tR?=
 =?utf-8?B?cHI2YjJicDJkM0M0QnEzN0JzOFdtNzlpcDJlSHB4Zmd1dnkzWjhTYnpZQk0w?=
 =?utf-8?B?cVJOS3NLaG0vTHBqVlVsb011REtJQ2Y3Wlptc1p0akRHdjBZZjdhc0xvTTVt?=
 =?utf-8?B?WUlMQVVROVh6MHBhN0lFL1k0bk0xNG1HeE9ZdzRYOEFGVS9GL29FbVd0Y2FD?=
 =?utf-8?B?Y3BsZ0dwelAyVGtkMnZqN1daVC9zbXlNYkEwZ3VJVzlkWE00TkpHanZiMXEz?=
 =?utf-8?B?dUFUYmJsUTA1dHJvSEljSFU3V3QvejJXQk9HVDRLeW5sK0RyYkdLWFlFdk5T?=
 =?utf-8?B?VGhFTVJUblhlVnFuYkNGNjlkckVUQU16VWdUMnBXSnhDaE5BZlNGdEtLeTFk?=
 =?utf-8?B?cVpBZzBkRmQwbDNSRzN5YllvckZUYUh3bnNEYUljYVBPOXR6ZWtyR1RjTm9N?=
 =?utf-8?B?b3o1TWJ3RFVtanpwb2p1VHhUdlhWdVhGRDRWUFBNbXR0OU1telNrdmdXcVAx?=
 =?utf-8?B?L3dvY251NlJFa1hUTDIvUmQ3elJvUmdLbEFPd1pmL0FPQTZHc3gvUTdJNUZ1?=
 =?utf-8?B?aENBSUpFZTVTZkw3aXNkcXp0OURwM2d0NE96Z3JkQUdSQ2VVcHlFWlVYTnYx?=
 =?utf-8?B?UWRsZ2ZCSytsMlpQNFBnZlQxSFdVWUFkeXFXS2NBblBNZUxwMzRUcVhISlV5?=
 =?utf-8?Q?aIlhZltIDL+77C7n7LAd0UW8U?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a05e7868-44d8-449b-228d-08dc6f76ff56
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6095.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 15:53:26.1835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LvDPcG4uukSy6TACM9MMBn/YCADXZubcPVpIUOuB1gwv5ev1tR0E6CVsEHZcyzblVsEDPIjKEPk/8WDei723cA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6763

On 5/8/2024 09:24, Shen, Yijun wrote:
> Hi Lyndon,
> 
>   Thanks for working on this patch.
> 
>>
>   Dell side has an initial testing with this patch on some laptops, it looks good. While changing the platform profile:
> 1. The corresponding USTT option in BIOS will be changed.
> 2. thermald will not be impacted. The related PSVT and ITMT will be loaded.
>   Some Dell DTs does not have the USTT, Dell'll have a check if nothing is broken.

Hi Alex!

Have you had a check both on both your AMD laptops and workstations too, 
or just the Intel ones?  I think it would be good to make sure it's 
getting the correct experience in both cases.

> 
>    Additional, with this patch, follow behavior is found:
>   1. For example, the platform profile is quiet.
>   2. Reboot the system and change the USTT to performance.
>   3. Boot to desktop, the platform profile is "quiet", the USTT will be changed back to "quiet".
>   This looks like not a proper user experience. The platform profile should honor the BIOS setting, aka, the platform profile should be switched to "performance".
> 

I agree, this sounds like the initial profile needs to be read from the 
BIOS settings too.

Furthermore I wanted to ask is there also a WMI setting that corresponds 
to this that dell-wmi-sysman offers?  I'm wondering if both should be 
probed in case the SMBIOS one goes away one day.  Or should that one 
just be used as preference?

It seems like maybe ThermalManagement corresponds.  There was some test 
data in fwupd for it:

https://github.com/fwupd/fwupd/tree/main/libfwupdplugin/tests/bios-attrs/dell-xps13-9310/dell-wmi-sysman/attributes/ThermalManagement