Received-SPF: pass (google.com: domain of linux-kernel+bounces-173560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 8 May 2024 13:35:26 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Zi Yan <ziy@nvidia.com>
Cc: Lance Yang <ioworker0@gmail.com>, Alistair Popple <apopple@nvidia.com>,
	akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org,
	maskray@google.com, ryan.roberts@arm.com, david@redhat.com,
	21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com,
	zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com,
	libang.li@antgroup.com, wangkefeng.wang@huawei.com,
	songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: [PATCH v4 2/3] mm/rmap: integrate PMD-mapped folio splitting
 into pagewalk loop
Message-ID: <20240508163526.GM4650@nvidia.com>
References: <20240501042700.83974-1-ioworker0@gmail.com>
 <20240501042700.83974-3-ioworker0@gmail.com>
 <0077A412-0AF1-4022-8F49-EE77AE601ECB@nvidia.com>
 <CAK1f24mRVam3w9CZkq4O0smGUTVUQfdvA48mqsU+NKxMUxdz1A@mail.gmail.com>
 <B1DA2DA4-AFEA-4541-8DFC-0D815249A064@nvidia.com>
 <CAK1f24mpt+ZGow4LLdXKZcwopmkZDrM_eh15SnkEgpiBXTmOwA@mail.gmail.com>
 <10BA9EED-A2BB-44C2-B80A-26527CDFFA50@nvidia.com>
 <1B2017A4-A252-4C1F-9608-D43ECEAD53B1@nvidia.com>
 <20240508155253.GK4650@nvidia.com>
 <30469615-2DDC-467E-A810-5EE8E1CFCB43@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <30469615-2DDC-467E-A810-5EE8E1CFCB43@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?p76T6yqTsQOHnQpcWmThksxrKFYXd/AkW4bqSmwYUz8bz2Hdfg/Ao2VShGvW?=
 =?us-ascii?Q?BRm4jgx3Vwtu7Az2gTjRJA7lKAOj4HbbkIiutNl0rGAcCe7Zgk+ZIZpDFkr8?=
 =?us-ascii?Q?6/5oTnoDUTfvz9mx1da7QnXn1kxptHFn2R2nJULgaK6dlLd1v+C5/590vvd1?=
 =?us-ascii?Q?KpsSZzhOo1VX7jAvTifWmmCKBSWiSBjEeTPcE3abyqAxTyBhlgH5Txyc1LOk?=
 =?us-ascii?Q?XBazbfZLKv7LUVqjSDZgQF0qlq9ZIfhaGd0xvj3t+rjCRSwOeICdQWRqyV+O?=
 =?us-ascii?Q?XV/JRMDJxdGWwXQ8yQ5KcJo3df8zw34X4TT0vMWBl9hLAENJk83pttDC7wWa?=
 =?us-ascii?Q?D+KD3RT6VfmR9X/xD4CxZAxvHgaZqj3eLSgY3O2hN3AzjvyIAjGsQXWfFUwD?=
 =?us-ascii?Q?4rZ4IKQ9nSxTKulFlwu0H/KEcrdqk7c4aKAe+LEKWm/PBmISBfDtNe4T2alH?=
 =?us-ascii?Q?GrRIwZQKdt8S43pwZpLHBH4JypLYD9CogFbgGVgJYzGVi75wy9qAUpVA70fm?=
 =?us-ascii?Q?sd47XLjFDLalvIjCAPnPamRGi1QGGyb6idM1rO5OD/r3EIQ/PXc2tZ6XYg7G?=
 =?us-ascii?Q?WZKTWhFS7/z6r0CxciVn8j+yCiLGBfdW0kpmjJBVgvg1AMhNbGfJUJSCy7sa?=
 =?us-ascii?Q?dgir/LZPysYiBGefYiZwlSaiuDQ38S+7CsOqGvs6vRUxRuOVl7wWMScebkkz?=
 =?us-ascii?Q?1aL2aUQ4ouH/s7+AfzVE3Yp2PUz40bfaZJRkHV2O9miULwH9C47JiUa7bbxN?=
 =?us-ascii?Q?u6/PmFnAa0HDCK2eMHAfTS1qsd8c3o3w174FKbRdyxLiT4HCrG/AJCKHiPtR?=
 =?us-ascii?Q?6UENhFdYzrXxjdIpsDSwdje8h5pbFgwuYRWATuY4JNjizD5YKQERTXpfmk0r?=
 =?us-ascii?Q?zbS0wN7whbw85Yyg4mHGgiUPCOZEV1xlGjHu+hqZSrHRemYRGHhZTxZwmpgS?=
 =?us-ascii?Q?G0R+8zZy1OtKWhesPmBDFpnPHQeQ7+S5yQMaBdWCVefDYtZF2/t1HiDy+k3V?=
 =?us-ascii?Q?jkDEEIru9HQgTx6cuI3Z377FMKDM26vB59tu8ladGxDRzytcC+MbpcqG0gFq?=
 =?us-ascii?Q?Z72gBHzRBGMPzcA/CosGk1t6zy2sVBtAPwTEuvC75GcHVEvmv0zGfdQ4z3MP?=
 =?us-ascii?Q?3gcRzmxTJoWV2b2vbxtH3LwBfOQ5vjBI9+Op/MtpZUQ3GZqesK9IHyxWI8yI?=
 =?us-ascii?Q?gfDUwEFr43km5uUoY+XojK535nLxYd15GfVeY/rz+ZQ7FzaON1penByQpZSg?=
 =?us-ascii?Q?3V0v3f67iWGowsreeOu96imzFy7mmcLl09VGs9VaRlC7O41fSaJt8hIRm9U/?=
 =?us-ascii?Q?yapsYM2Rl+o+ec0v3C9eGFIaCN2/q5mdlgIXCEVPRmr2yKmZt5VHOzC7E7XN?=
 =?us-ascii?Q?H7RilTJV4wBErjHMx80NeoFAntk27/SYp0fq9N4IqBC58AaBwfRJG+UhxIFa?=
 =?us-ascii?Q?8+frIHpPLeLXFSAzQjx47ntcQDwySiAvfI+JShPbIcdcaCKZya7NgNoVn0uO?=
 =?us-ascii?Q?GzfNrU0TNbaDitfiwek5Hn0FKqLT7LtRKhWaVPsnGPnrCZYWQtOUHNNcn61L?=
 =?us-ascii?Q?TSfrqRyJV7CSDXXErhHnqpp8OMaPrDgOxl3bI2S1?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0355b6ab-4452-4a1a-4af7-08dc6f7cde70
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 16:35:27.9658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xPyMdqyK3WysIKrMlcxTEXfhGBXQ7JcEM0uR5J5NhAwaewpodyhxx3wdVeb3GBz6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6368

On Wed, May 08, 2024 at 12:22:08PM -0400, Zi Yan wrote:
> On 8 May 2024, at 11:52, Jason Gunthorpe wrote:
> 
> > On Wed, May 08, 2024 at 10:56:34AM -0400, Zi Yan wrote:
> >
> >> Lance is improving try_to_unmap_one() to support unmapping PMD THP as a whole,
> >> so he moves split_huge_pmd_address() inside while (page_vma_mapped_walk(&pvmw))
> >> and after mmu_notifier_invalidate_range_start() as split_huge_pmd_locked()
> >> and does not include the mmu notifier ops inside split_huge_pmd_address().
> >> I wonder if that could cause issues, since the mmu_notifier_invalidate_range_start()
> >> before the while loop only has range of the original address and
> >> split huge pmd can affect the entire PMD address range and these two ranges
> >> might not be the same.
> >
> > That does not sound entirely good..
> >
> > I suppose it depends on what split does, if the MM page table has the
> > same translation before and after split then perhaps no invalidation
> > is even necessary.
> 
> Before split, it is a PMD mapping to a PMD THP (order-9). After split,
> they are 512 PTEs mapping to the same THP. Unless the secondary TLB
> does not support PMD mapping and use 512 PTEs instead, it seems to
> be an issue from my understanding.

I may not recall fully, but I don't think any secondaries are
so sensitive to the PMD/PTE distinction.. At least the ones using
hmm_range_fault() are not.

When the PTE eventually comes up for invalidation then the secondary
should wipe out any granual they may have captured.

Though, perhaps KVM should be checked carefully.

> In terms of two mmu_notifier ranges, first is in the split_huge_pmd_address()[1]
> and second is in try_to_unmap_one()[2]. When try_to_unmap_one() is unmapping
> a subpage in the middle of a PMD THP, the former notifies about the PMD range
> change due to one PMD split into 512 PTEs and the latter only needs to notify
> about the invalidation of the unmapped PTE. I do not think the latter can
> replace the former, although a potential optimization can be that the latter
> can be removed as it is included in the range of the former.

I think we probably don't need both, either size might be fine, but
the larger size is definately fine..

> Regarding Lance's current code change, is it OK to change mmu_notifier range
> after mmu_notifier_invalidate_range_start()? 

No, it cannot be changed during a start/stop transaction.

Jason