Received-SPF: pass (google.com: domain of linux-kernel+bounces-173567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <7fd20d16-066d-4ec3-9ca1-e99ff39d3d86@oracle.com>
Date: Wed, 8 May 2024 09:51:51 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] mm/memory-failure: try to send SIGBUS even if unmap
 failed
To: Oscar Salvador <osalvador@suse.de>
Cc: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20240501232458.3919593-1-jane.chu@oracle.com>
 <20240501232458.3919593-2-jane.chu@oracle.com>
 <ZjnuJgUVVnwYrr5p@localhost.localdomain>
 <2f965887-19b5-47bf-98ca-d40b3ec05e75@oracle.com>
 <Zjtqqs_ImPIn7I-B@localhost.localdomain>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <Zjtqqs_ImPIn7I-B@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dGp0UUpHUlkvQWZ0NExvdTVvdXk0R2I3dG91ODJVQ3F5Q0dwVlVxbElnV1Nz?=
 =?utf-8?B?M2FTanliWWpyaVBRdGtrdy9WSzNjUXA0dmFUMHkrTGFCTHRGalN4ZlBFbWtP?=
 =?utf-8?B?TEVvRkxCdG5PYklQckxUMHhNcWpiYzNaTTBBdElNTFA5RlJpOUR4MDhkbUUy?=
 =?utf-8?B?R2YyM1FIY3ZvZlFRaWxLM1BkbGtIRXFvNzA1VkNZdmhSMEVNL2YrTjRhRHgw?=
 =?utf-8?B?algzeFc2VzhCRCtRbUN3ZGtxM2JLaDZLOTNxN1Z6RWJCaS9FOEZPNmJSNnFw?=
 =?utf-8?B?YUM1V2Q1aHg0aWovbzQ2NVZ6djZNUC8reHgzL1dkeXBySHNNMXhsMjVvcVJj?=
 =?utf-8?B?ZEczV1lpM05iaEhHV2tVazNZMGN6WG9CTVpBRU96Z3hxckZldSsremRjZG9m?=
 =?utf-8?B?dTd1SVZZenhleTdCQ002WStKeUc0T1RadXdvZlJZVG9VeDl4Zm5VVExTYndO?=
 =?utf-8?B?dWdzbkxqdVg3UnZlQ2Y5eFpBdUE3NHgxSEp6ZG03U1g2MXpSckIyRUl6Vm5N?=
 =?utf-8?B?b25RbzBybjNENm0vbm9EVTE0UXQ1b3Z0RUZsMXQ1bXFLWkFkUkRuVUtxUzdx?=
 =?utf-8?B?a3R2Si9mUGJoaW0rTnN1bGIveWtHSmVZZ3JkOVp6OXorcWxmTHJETGU3cFgv?=
 =?utf-8?B?OU9mWlo0dE05Q2dVYWhXUWl5eHdTT1ZtVWdMbHgvQjR3U1Q4U2tkNVBqM0ZP?=
 =?utf-8?B?eGlncWMxeU5DY2FjVUY1Wno4SzNLSmNhb3VPSW5jQWJ4VEkrbXpFc2p2bkVY?=
 =?utf-8?B?dUFMK0JreThYSzRtN3pCdy90TkpCK2pOU2JTUUVmUXRGS2cxN2Q5UkJvdTQ1?=
 =?utf-8?B?STFGbGYreUdnUG0rdThMcGpnYy8vSkJuSXlhWkVTNTlyenphdU5xL1lxOTYx?=
 =?utf-8?B?Nm9acmVDMlF2ejdBWlJoZWw2QUNDTUxwWTNGT0lhbzQrc2ZqR2FSd2ZYbTFw?=
 =?utf-8?B?Qmp2bzVOU1d0MVJvK2Y2cDFBMmgzVnNUMVpidXdDT3l5Tk94d1psOFVtTk05?=
 =?utf-8?B?M2Jxc2xCdmxJTUg1ZUIyUVk4Z1RVc3RvNElOTk13M1V1Uzlad2g1dkthTE03?=
 =?utf-8?B?eVduSHZLVjdrdW1RYXROWFdibHlHa3piQmxGc2pqbmNWTitici9VaDV5dEJj?=
 =?utf-8?B?UHBEaTR6cVA2UFo0TlMxdFpwZFJTQXgwTWFaNGlObkdQcEdYaStNVWN0eDNq?=
 =?utf-8?B?YTF5L0R0UGhEU0E4Y2Noc3AxcnpOVC9pVXlFRGwvRkpleWZFMHhwSFRDdXpk?=
 =?utf-8?B?MVlNMVpXVW1mWWR3WlFPNG1kZzBOcHJzQzZuTHFMS2hqSlN1eUEwSXd3VHVP?=
 =?utf-8?B?RFpuNHlYc05JV2NacFIvamZ3NTYvU0syR0dQYzBFdU5OTFFyMWQrdTk4K1lE?=
 =?utf-8?B?L3Ewd0VmZFJSRUVLeW5INVJTMWpHcUJ2RnJtbzdzSXJTalZRZ3N6ZmtRWmd3?=
 =?utf-8?B?eHk5VzNvdWlURHpTc0xsbG03T0FtR0lLRVlJQVlKa1RLN2JoMCtMMEg2T0tU?=
 =?utf-8?B?K01Ga3JtbEtHUUczbTVuVjh3Y3p4OXkxaW5tNnoyc0hEY1JsZDJRTUR6L2p2?=
 =?utf-8?B?RjJ4R1o5RFYvYTFtZ1AwcHJkMjcySzhEd0VIbGE1a25oQW9iT0VzaEl2VGx4?=
 =?utf-8?B?ZlpPRDh1NGV4TlhCdFdsT05GQ05McnZtQmpqdVVybGoyci9qV2F4NGVBQk5t?=
 =?utf-8?B?bVhqZ09XZ09EY3JCQzRTNklTMjloZFc0cGVYSUJ4Q1dsaWVweFNudXdDVUgv?=
 =?utf-8?B?TndGanFLeHp4L0JuWkcvcjkzS25ocnZMbW1ablVYQ2xLVzdvZFU2VzZ4V2ta?=
 =?utf-8?B?b1F0RWVhdXcrMGMzUzJISllwUkwxdXMvckJVMU9uYmZ3WjF6RW5SUzdFZnVY?=
 =?utf-8?B?WGNYNENWTkcrbmhtSzhFWktNSnRUWDc4dDBYeHpVVE4zbml3Z0xXNDhzZ1p0?=
 =?utf-8?B?RTN5UjMwbXJxVU5rb3Q1TEJHZlFud3VsWTkwdW5memN3Ujl1QUhTNmUyQ0NQ?=
 =?utf-8?B?U1lWNXJuaS91QnVtWExJL3BrQ0tFS2o3eUg4MDVpdkpkeCs5Slk1WTljdmhE?=
 =?utf-8?B?Tld5YlNpeGY3cGdHZnh4SHM2R0JnTDZRS0Jqd0pXT0dtTUt1K2FGS3hjaThx?=
 =?utf-8?Q?OCuRuSZpVRfoHJvTWeJkHdBfm?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	D9gc4/DBolSqgGHlc/VVUdjWmlaELvXPcKIR7pkIfQ/++4Of6XszEhrA8jG8VfU1mCkNSF3+Zpjv6osnLZcaWQrdhg1eNKFcG+tTgJfhOxln8XHbQTAudsm6e6kBisNiLtERBE/xI86PeuQ6OLoXlgZ4wghswEan+VT5Ur1BvR+WVPIPR40JcyDBORWMYA/0nEFRw3Y+fo6zJ5351AUO9mmM/Fsnd6a8BStoAIEPx7fDRMBXB/zv9hGxjgXww2Jt0sIRRBMI4Yqbd2kIUNdluXXDfGt+I4A8qHTmLE6fVS9KqXAAoyPJ1MsD3EiOzLNgCvQSsUURJM+0fXCOP/U/y02bjzj+a9sbBMO5xzi1dCT9MdNI7HI4fxVAELNGYPag/ZOeQ4vLeQOBKNMXvtkt+mXL5QVis9+3PW5RKucdiJHtQ6phYkouuV1DHdDqNiBQ0JIXrF0fdn4smgn05tAtB3e8rM4R5pkk48MgnYXJnxhzM1IMt5CH9NlPangYgMhoqap0eescgPLp2j7cW2E2l23y4gv+F3htpv4rq29MJ52UOWuXzXs2vlxOR8ix4e/Arq4vQL4jx1RKjU2+bZ+kidpLIkJpliyuG75HWihBgZE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68454f81-36e7-49d3-33c1-08dc6f7f2abe
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 16:51:55.0444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lbgc26fWWr4+J0eKZ8zkpbcarFXfS5Smxm4pQ1OKjdNXjOu3iyPAZV7Sr0jsmpSCl5XFgzGYfHyOZ152MELwiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6867
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-08_09,2024-05-08_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 suspectscore=0 spamscore=0 malwarescore=0 mlxlogscore=945 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405080122
X-Proofpoint-GUID: YYbBqB1m4wlmLcdF8WfLksrNqy_MFXMG
X-Proofpoint-ORIG-GUID: YYbBqB1m4wlmLcdF8WfLksrNqy_MFXMG

On 5/8/2024 5:06 AM, Oscar Salvador wrote:

> On Tue, May 07, 2024 at 10:54:10AM -0700, Jane Chu wrote:
>> I actually managed to hit the re-access case with an older version of Linux
>> -
>>
>> MCE occurred, but unmap failed,  no SIGBUS and test process re-access
>>
>> the same address over and over (hence MCE after MCE), as the CPU
>>
>> was unable to make forward progress.   In reality, this issue is fixed with
>>
>> kill_accessing_processes().  The comment for this patch refers to comment
>> made
> So we get a faulty page and we try to unmap it from all processes that
> might have it mapped in their pgtables.
> Prior to this patch we would kill the processes right away and now we
> deliver a SIGBUS.
>
> Seems safe as upon-reaccesing kill_accessing_process() will be called
> for already hwpoisoned pages.
>
> I think the changelog could be made more explicit about this scenario
> and state the role of kill_accessing_process more clear.
>
> With that: Reviewed-by: Oscar Salvador <osalvador@suse.de>
>   

I will revise the changelog and mention kill_accessing_process().

Thanks!

-jane

>