Received-SPF: pass (google.com: domain of linux-kernel+bounces-173582-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <56448498-96e4-4350-a915-15b97294bc62@oracle.com>
Date: Wed, 8 May 2024 09:56:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] mm/memory-failure: send SIGBUS in the event of thp
 split fail
To: Miaohe Lin <linmiaohe@huawei.com>, nao.horiguchi@gmail.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20240501232458.3919593-1-jane.chu@oracle.com>
 <20240501232458.3919593-4-jane.chu@oracle.com>
 <2e51deff-24ca-32d5-dbd2-9077f860723c@huawei.com>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <2e51deff-24ca-32d5-dbd2-9077f860723c@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MUVjU1NGcVNZdjh4TmRwaEh4Y1NILzk1c1lwVjdEZ1VyRUk2a082S2NXSnZS?=
 =?utf-8?B?UUtZMHZhYkx6dGxFdGFFRDJNOHVnTDNtU3ovU3VnVklYS25pcTc2bHdtMTVT?=
 =?utf-8?B?TWVmY2N3cVYzdjFNeWxkdWdxTWZldzNpWjh6NWY4ckNKaHpsT3pBMEdxVzln?=
 =?utf-8?B?cGFXYkZLYjJPSFIvUXpCeitaYWRMeWRYTHZwRG8wN01Zd3BISjVnOFFGL0dS?=
 =?utf-8?B?QTJ3Q0ZvWTF5OWtUWEdsY3ZRN2hPNTBCQmRXdk5YbU1wanBVTkJJUzBhbGtG?=
 =?utf-8?B?aTcxemtqNUVxdnlhM0hlNGVUbm83SFZKcmNxRjk4S1J1YjBaajBGWGswV2I4?=
 =?utf-8?B?aE9PeVAwenhoWkU3aWpEcFpmdFllbFhJakxtNWZKb3RmWEE4TzhhaHI4WThW?=
 =?utf-8?B?NFIvVnJDVzV5cFpWWnpBaFlHblgvS3l1eGFsVDNOdzJBcXF1SGNQZ3M1RDl2?=
 =?utf-8?B?SGl2anU0aUlrdWh0TmNFR3VKclIzNmxMaEh3RUdCT0hmYkJSSjRhK2JiLzhn?=
 =?utf-8?B?d0xhTVozSXV2ZjF6MFQrN1pDVCtDNUtQU0dENlFhMlMxTndVQjlsd2JGaTZO?=
 =?utf-8?B?WVNEa0U1MEp1a3FwRDFrSjBFekxXZVNzMkVaaXhDVUl5NmI5ZEoxQmJyb0xy?=
 =?utf-8?B?OS9URmxvbnJIQVZYbCswWjZzT2h4UGs0WU0wYlk4RC9kbFpHalhhQXhvQncx?=
 =?utf-8?B?UHg3WFlwa3RZd25DdzhpVjdoMitySnNRcXhzc1BZR3I1ZTArRHEyWWZwUzhn?=
 =?utf-8?B?VkNKcVB3Rks2dFc2QWZIaEdZYkVIWG4rUVBJS2FkeVFiWUttdzEydW96b21u?=
 =?utf-8?B?VmVYY0F1RlgxNVpYUWpGdTdWVzVkemtQOGNRSE04TWNINVpwdEZOb1MrQmdJ?=
 =?utf-8?B?czcwN21FaExnWlh6RGlVM0lRVlNjZWNCRjR6MHVhNFplUW01a2M4SXdVdjNh?=
 =?utf-8?B?WmhIN3VkRWIydFJYY1o3dldTN3d0SU94WUxMeUt6Z0diVzdibmpCMTBqdnJw?=
 =?utf-8?B?VTF0dncvZmgzMkZYYzJoUWhhNHRnNHhkVDFjc2oycStycHhmeU5FY01VVDNu?=
 =?utf-8?B?ZCtwRFVUeHpYUzVjbi96aWFFZzlpdGhKcFBaUk53NXByWUZMd3lJUHJVaEJS?=
 =?utf-8?B?SDU1dGFhVDlTVitPMW5lYmZHcFk3MzlvYUhvcG4zNi9QN1ZVbmE3eUtLUEVL?=
 =?utf-8?B?Q05qT1dOZmJ4Y1B4SWl6b1Vvbm5CMGcxU2NpaUo4QnhaZkRkY29tbFVLS3VN?=
 =?utf-8?B?dXBCVU5MemNrU1UxdkhVZVVrMVpzUk5YamtrSUFJbldDM2c5VlJvR2FmVzBP?=
 =?utf-8?B?bXFmYTVLWi9pK05RZU1ZdndwSHBRWlhmNTNwLytuVjlrVVVIZGp0ZlU5aTgy?=
 =?utf-8?B?aXcrdTloaUVDNzc1MVhiT1AraEVlTUNsSjkxRVIxWTZTcFpSbjhscklXYW4x?=
 =?utf-8?B?QlU1N3pKd2NybW5jbE1haStWMU8zRUl1RzRMSXhxbTB4VlBTL2R6cExmREQ2?=
 =?utf-8?B?NkRRWWFiRGh4bjJDak9sQnRPaUhxSG90ZFlFSEdVRkQzcVFqYkFuZ3VranFy?=
 =?utf-8?B?MzRnUzhJQVExa2VBOHg0d0RYa0ZvcVNCU0VkckNBbktjMnBIRDlrZDV6bUFQ?=
 =?utf-8?B?aVMvQU9lVmtEZ0tZajFjWnpMS0cwRElFWk9zNVE3NUdzOG9qeFFkbGRZMWpN?=
 =?utf-8?B?RWtRVEw0UTA2a0VMeWY5N2NsYlY0OWtZM3hQbzlMK0RpcDFEMk1nUDhrSjNC?=
 =?utf-8?B?SHhYSXhBVVdwT0pTM3E2L3hpRXozK3JiTmxjVkQwdGQxT2Q2UDhXRnAzQjVy?=
 =?utf-8?B?WUlCNTRjNTZUVThFTUNZNkVkWXZkbEZrYU5QWHRuSkt5VGV6Yjl0WVppZ2Mw?=
 =?utf-8?B?aHZUdUlZdnYwYmpOTExyQ1FnUXJNaUJaMmtlLzZyUUszZGlOeDNYTTZEWjFr?=
 =?utf-8?B?dHlPaW1IRVprNGlWWURpWElqTEdlSmtqeUhUZXhwdWg5K1dYdjZ6ejlXKzI3?=
 =?utf-8?B?WXZOaGRyZUVUZ1FOTk4yQ0o2ZUtLOEozWXNqZGlpZCtsT3A3MXdDR201djd3?=
 =?utf-8?B?bDFMRWVtSmNzeFVFVHIyaE9GY1l0VEtmTitXanJjekh3V2pldklHQ0NBNGRx?=
 =?utf-8?Q?Qa1TleROTJ4b/cK7Ppkh782o3?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	LkCqqIqe1jRLIb0p+pFAEVYFsXEQ8UTiMHxwKB4SoRljWFGGSb7n4UI7Z2JitpkPT8dtq/zy57CtA9bmnjvdKCyuryAHI6wxrzv+zzOF5QgvGc4oZVrZxOGhV09RWjvbSjYGg09+aLC3LZCMqxNWFMJ46ags+IMPjF3MJDs6305pp6o3lmWaLTvpWWMCgHFgs6BVSGS12fqdsaScDFwc/bEH06fGnpaT/RMi0XyC0Q6qqwwmARn+mPz6fOajUmlTen5lk/OU+t19oLOaZdiCXuKx2U+RRqNgJwj0CPaxqu0SpUtgL8gTv39n6IfBGtRbS/uVRdXOHn0ltApq60bwlkoqQnTUF5Z+TM+P3EcZh5HhwD1BmEVG2WSrcuBonNI/kIpzLT+ClUvFHxATeVeJnaApLj7wIP5NWGcdyg5Al5W8oJ3CNPa9oPwDyEBqFQ0dU/iRDqGLAqIOuNNZN1HqZHGBzmeKSHFXso+Ia1wWjA1ay34gzdkpVU2M090VLGWcSzxrdIMAg24GedjmB1+cvX3dnTJos0y+WrnGIJHaaTk1QE7kPP+ezHGc2bmNpQBoL2JxI8tDASFqFqRe6AyXVwDcygatdvq2uw9db3pvwG8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d27c572f-ed06-41dd-22e7-08dc6f7fc62e
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 16:56:15.8896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lsuzEGLMlsPMIaqCpYD6flXyXg5IwkTGIQpeY/+Dka9KExeBxwUmgu+H+fK8+xCQsQhq3lY9haH4JMJrahFnzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4791
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-08_09,2024-05-08_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 mlxlogscore=845 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405080122
X-Proofpoint-GUID: FkmPXyQJWyvVBeZaLPfnBFsAR46Yc0KQ
X-Proofpoint-ORIG-GUID: FkmPXyQJWyvVBeZaLPfnBFsAR46Yc0KQ

On 5/8/2024 2:03 AM, Miaohe Lin wrote:

> On 2024/5/2 7:24, Jane Chu wrote:
>> When handle hwpoison in a GUP longterm pin'ed thp page,
>> try_to_split_thp_page() will fail. And at this point, there is little else
>> the kernel could do except sending a SIGBUS to the user process, thus
>> give it a chance to recover.
> It seems the user process will still receive SIGBUS via kill_accessing_process()
> when (re-)access thp later. So they should have a chance to recover already.
> Or am I miss something?

The concern is about real UE consumption in which case, it's desirable 
to kill the process ASAP without having to relying on subsequent 
access.  Also to honor processes' MCE-early-kill request. 
kill_accessing_process() is very conservative in that, it doesn't check 
other processes that have the poisoned page mapped.

thanks,

-jane

>
> Thanks.
> .
>
>