Received-SPF: pass (google.com: domain of linux-kernel+bounces-173583-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <64df4f60-464a-4fae-81c3-f355c07410d0@oracle.com>
Date: Wed, 8 May 2024 09:58:42 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] mm/memory-failure: try to send SIGBUS even if unmap
 failed
To: Miaohe Lin <linmiaohe@huawei.com>, nao.horiguchi@gmail.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20240501232458.3919593-1-jane.chu@oracle.com>
 <20240501232458.3919593-2-jane.chu@oracle.com>
 <1bc8c5ff-1452-11d3-edee-9f45a87015a9@huawei.com>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <1bc8c5ff-1452-11d3-edee-9f45a87015a9@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?T1Y1cEFGNnFYbnJaLzFSQW5TazVaSjJGaHlWMWc3UUplKzdobjh6Qm5aRm9L?=
 =?utf-8?B?WUROVEJkd1pzbW9nTEJmazVCeXJIcDFWRXJEL0NtdFdIMkxidDNNWlU5RGJJ?=
 =?utf-8?B?MFdMSTR3VlRNMTl5N2s3UHIwMWMzbGthdG1IR3lYK2lIS2VCVm9pQ20rclVF?=
 =?utf-8?B?dWZJS3lYYUFxUEJVUTk1eFIrTEpOTUx5ZXpRZHpCY0lVTDMwOGEvbGVQVzhh?=
 =?utf-8?B?OU9Ocmp3d0hrbHhGTFE3VDlPSEs3dTA5T0JGN0Joays4bTNOeUxMS3ZoeFNQ?=
 =?utf-8?B?L25WS2NBMStmYkZkRVhVOFA5YThCTnQ2SEsrczZSNkpvY1JsVEZNOGJ4bjNy?=
 =?utf-8?B?Mk5OQWdGdk56eXFNck5jYTR3ZzVZZlRtb0FlWmM0bGcrKzBaeWxjTXQxeGdH?=
 =?utf-8?B?WG5ZTGFRakkwaEVDR0E3MW5pNVdXT0cvVTdIZ1lGY2czVUtFWGtlT3NmM0U2?=
 =?utf-8?B?eDVqNHpjZi9pOEV2eDM2YjJtdHhJVy91ZVF5RXZndE04OEpPVEF0bXpRS0xM?=
 =?utf-8?B?Q2hDa1MvVG9PZ1lsN0JneDJ0QmlHNWppb1JFMktuK29UYms3dnBTRVltV3dj?=
 =?utf-8?B?cGdtZW85VE9hcmJndnBJVXdodzE0SFhZL1c0b1B1eFp5dFdTQWVKRVA1ckFo?=
 =?utf-8?B?VE04WENBMGJmUHhNZHcrZDZEcitpMUZGM0ZZaTVsLys5eUlQR3ZEZmtkRkIv?=
 =?utf-8?B?UWk4Y1NoZ0cwN21xaXMzU2lxZlk5em5mdk1UcUFHelJsQy9JYmVpdVR3Tzhu?=
 =?utf-8?B?VWZDVDFacDBxUytUR1N5UndoajBuSTBFSS9RUXZ6K1Bkc01EQzBRalpLaDYv?=
 =?utf-8?B?cC91WTNMNUFOYndWRngxSXpsZXhYVklreUFWR0lRbWRjZTRseVJmS2l3WktZ?=
 =?utf-8?B?ME9sQ0wxT1k4NDlyeXIrWnZ4cFpvc3RVQUFQb2x5Q0Exd2YvSFF1UmtkckZs?=
 =?utf-8?B?Z1ZFYktKelZReTk5SmhrTXNNOHFXRDE2bVB2cUthRnluZVFwdlNDY0hKQjBT?=
 =?utf-8?B?SWhjc2c3UnlQMDVnZW9tMGNyMXhOTENNc0VPNFZ1UU9BdVlkUDZTcVR5cjNw?=
 =?utf-8?B?Ri9yK3ovSHJpdVZQalJXbEo5UW5DNTAwU1FULzB5MC8zUnJrSVl2d0VQcjRa?=
 =?utf-8?B?dnV3U2RFcTJrSkIzYUdYVEt2bEc1cHVDbUY1MjRwSWFwOVdKR1dQSEFWckZM?=
 =?utf-8?B?WWhMMWhWY09oS3NoVkFjT3h0UGpZNU9DVFV1YmlSZlI3VS8vMXFJSWJ5Vm1Z?=
 =?utf-8?B?eFpIQmdpVENvRzBuWlBVY2JucGFnT0pnZnRiOXJVVlIycG9uNG9XQlVhN2w5?=
 =?utf-8?B?MWlpZkQ0bElrUmYxMjRUNWliZFRTNlFaajlYMyt1dE11UEhlODc1MVVxVXhD?=
 =?utf-8?B?eENaVmdwNnhubDNyM3VQbDF5VFhIWXBVTVVIZGNmaEhZa0RDNmVIajEzNENv?=
 =?utf-8?B?QTFTS2puUTJYQkF1TE91TldKWklBTzRSekRqMU0rOWdNWGgvdjRPTUhYd1pU?=
 =?utf-8?B?WXM5ZkZvTmppaC9INkMxVnI1OGNGS1FzSS96VytCUTFHODZVaVhMK2NwNlEy?=
 =?utf-8?B?TW9YMlp3QTJRR0JBOGFUbGZXVFh6WnRVT0crVGFmT1FjVm1CdWphUXpFT0F4?=
 =?utf-8?B?cjk0Ui9icC9xSndLdkJjbHJSVTBFVC9KOWdyam5RcTJjdHZOSzBwZTlvK3Mr?=
 =?utf-8?B?eFd2L2ZaSE1lYkxIZmUrYTBpLzhxZ3N3RktnZCttemhxa25NNVNmR3cxWit2?=
 =?utf-8?B?UjQzNkd5cUoyZ0QwanBYd0F3S3hBcVZrMWVMUkJkczJhZU0wMmlncFdUL1Zx?=
 =?utf-8?B?d1JWQktRYzQzRXAwOXZxeXpOakJ2dFI4N2xHZmdoK3hWKzFHdzN2WnlVY0po?=
 =?utf-8?B?VnRBSjBWc2o0WjRwU1VFaDFHcmc3WC9RUk5nS2ZUV0srRC80QURkNE4wVVJn?=
 =?utf-8?B?Y1dhWGh0M1YrZUMwS0pEbkZNU0s1Y3BWR2VDMVl1d2pkelpINjg2MFl6c0Nu?=
 =?utf-8?B?WVdWWVY2MGduR1BaZ3ZyWktwVzZDWXYwZk81UnYyaTlka2ZEbllYZXI1ZE1a?=
 =?utf-8?B?SmkzN0JFbzJvRitUSUhJL0JqYjkzU2k2Q2dFMnRaOW9WZWlVUkc4WitGUXVG?=
 =?utf-8?Q?unXYf1y5iENntcAJqtq76qbdU?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	WjA9RZevjHqsN6LpZwfMA2LtTABB/4FNnG8SCjwZdU1E1PNV3zKxRtgLbu8HpmQNCs4iKHTo5IL740EziiIq47FmeemVAb8B2nG12PZ73ikVVIlfGRk5j2pC9927a1wOiuXGD+Qk6v9gZ6rDCeHJLkcrF/gs40PsKNyRaRp6uqPxoH8oZZk0GKb3vycyerOpnlAvmGC8HWPPFwn1ijimrVQh8OHrf9RcuAAS7L4IXuKCqAxgfNTOtlwu5902qgWjjyea4a1iQ9a9/ZxFj0zn7ZMysHaB4+ukmOqOyht+pHQksbUzoeVuI6aX8sGw6ket7BNUHkAJqap4f1b4gvMT/M0bolthdA4ipUlHH+CaWkpUbBN0oSDEYDsp80Wcyk5Y/C9paNc6lOncnzod1nWmW6fCLPPVndhOTlrMrmOOAHd3c6kpD27Kq32ClEsfv6L0GDtV0PMSaAc/qEbCQ1S17/FVivPy98Ockt9L8pR422lFLmyZQDURyoDO2nUj3FXgJQr8EDbEYVx2t5xBK3cVZasvx2JAaltfJ0vaNgiCXaZT00AmksjjUw+2wJf+xY9otBnlJKVvOXDQLmHWB3WFBEThL5vAlDOHu+z5gDYDHjM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30161ca8-5f22-40fd-c0f1-08dc6f802195
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 16:58:49.1327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HpAuXF4564CxzLG4X0pdo1vrfcDrUcQa9Ji4S72UYd3Co2HIe3wEVCktm7Rm72ARbsQVSl0ak/2m8l/fumobuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5895
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-08_09,2024-05-08_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 spamscore=0 bulkscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405080123
X-Proofpoint-GUID: HFJT40WwGSXnXjERO3mvm2b1HAl665tR
X-Proofpoint-ORIG-GUID: HFJT40WwGSXnXjERO3mvm2b1HAl665tR

On 5/8/2024 12:47 AM, Miaohe Lin wrote:

> On 2024/5/2 7:24, Jane Chu wrote:
>> For years when it comes down to kill a process due to hwpoison,
>> a SIGBUS is delivered only if unmap has been successful.
>> Otherwise, a SIGKILL is delivered. And the reason for that is
>> to prevent the involved process from accessing the hwpoisoned
>> page again.
>>
>> Since then a lot has changed, a hwpoisoned page is marked and
>> upon being re-accessed, the process will be killed immediately.
>> So let's take out the '!unmap_success' factor and try to deliver
>> SIGBUS if possible.
>>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
>> ---
>>   mm/memory-failure.c | 13 ++++---------
>>   1 file changed, 4 insertions(+), 9 deletions(-)
>>
>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>> index 9e62a00b46dd..7fcf182abb96 100644
>> --- a/mm/memory-failure.c
>> +++ b/mm/memory-failure.c
>> @@ -519,19 +519,14 @@ void add_to_kill_ksm(struct task_struct *tsk, struct page *p,
>>    * Also when FAIL is set do a force kill because something went
>>    * wrong earlier.
> Since @fail is removed, above comment should be removed too.
> Thanks.
> .

Good catch, will do.

Thanks!

-jane