Received-SPF: pass (google.com: domain of linux-kernel+bounces-173607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 8 May 2024 18:14:34 +0100
From: Conor Dooley <conor@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: mips: brcm: Document
 brcm,bmips-cbr-reg property
Message-ID: <20240508-prong-serving-660e6046621d@spud>
References: <20240508170721.3023-1-ansuelsmth@gmail.com>
 <20240508170721.3023-3-ansuelsmth@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="3T0eXEEj/GfP9EAy"
Content-Disposition: inline
In-Reply-To: <20240508170721.3023-3-ansuelsmth@gmail.com>


--3T0eXEEj/GfP9EAy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 08, 2024 at 07:07:18PM +0200, Christian Marangi wrote:
> Document brcm,bmips-cbr-reg property.
>=20
> Some SoC suffer from a BUG where read_c0_brcm_cbr() might return 0
> if called from TP1. The CBR address is always the same on the SoC
> hence it can be provided in DT to handle broken case where bootloader
> doesn't init it or SMP where read_c0_brcm_cbr() returns 0 from TP1.
>=20
> Usage of this property is to give an address also in these broken
> configuration/bootloader.
>=20
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  .../devicetree/bindings/mips/brcm/soc.yaml    | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.yaml b/Docum=
entation/devicetree/bindings/mips/brcm/soc.yaml
> index 975945ca2888..77f73ab48c11 100644
> --- a/Documentation/devicetree/bindings/mips/brcm/soc.yaml
> +++ b/Documentation/devicetree/bindings/mips/brcm/soc.yaml
> @@ -55,6 +55,15 @@ properties:
>           under the "cpus" node.
>          $ref: /schemas/types.yaml#/definitions/uint32
> =20
> +      brcm,bmips-cbr-reg:
> +        description: Reference address of the CBR.

Pretty sure that Rob commented last time that there's no definition
anywhere here of CBR, but I don't see either a response to him or an
explanation in v3 as to what CBR means.

> +          Some SoC suffer from a BUG where read_c0_brcm_cbr() might
> +          return 0 if called from TP1. The CBR address is always the
> +          same on the SoC hence it can be provided in DT to handle
> +          broken case where bootloader doesn't initialise it or SMP
> +          where read_c0_brcm_cbr() returns 0 from TP1.

Why is a ?linux? function name in the binding? Surely this is just
"or in SMP systems where reading CBR returns 0 from...", no? Ditto
above.

Thanks,
Conor.

> +        $ref: /schemas/types.yaml#/definitions/uint32
> +
>      patternProperties:
>        "^cpu@[0-9]$":
>          type: object
> @@ -64,6 +73,20 @@ properties:
>      required:
>        - mips-hpt-frequency
> =20
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - brcm,bcm6358
> +          - brcm,bcm6368
> +
> +then:
> +  properties:
> +    cpus:
> +      required:
> +        - brcm,bmips-cbr-reg
> +
>  additionalProperties: true
> =20
>  examples:
> --=20
> 2.43.0
>=20

--3T0eXEEj/GfP9EAy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZjuy+gAKCRB4tDGHoIJi
0qVMAQDuVWWj+vEUXNkj/tXEtwvj2RZ6t8pKRp7szq5BGLRp3gD+N+FBalhu+8dG
Im2poiIXGxI0tEoyutCeF6HaXJM63gg=
=GVnj
-----END PGP SIGNATURE-----

--3T0eXEEj/GfP9EAy--