Received-SPF: pass (google.com: domain of linux-kernel+bounces-173612-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 8 May 2024 18:18:03 +0100
From: Conor Dooley <conor@kernel.org>
To: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
Cc: linux-kernel@vger.kernel.org, jic23@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh@kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH v2 7/8] dt-bindings: iio: imu: Add ADIS1657X family
 devices compatibles
Message-ID: <20240508-monsoon-theology-d141f4e32bad@spud>
References: <20240508131310.880479-1-ramona.bolboaca13@gmail.com>
 <20240508131310.880479-8-ramona.bolboaca13@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="WpJ+I2U/bkBC8Ytu"
Content-Disposition: inline
In-Reply-To: <20240508131310.880479-8-ramona.bolboaca13@gmail.com>


--WpJ+I2U/bkBC8Ytu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 08, 2024 at 04:13:09PM +0300, Ramona Gradinariu wrote:
> Add ADIS1657X family devices compatibles and specify the according
> maximum SPI baudrate.
> Similarly to other ADIS1650X devices, ADIS1657X supports sync-mode
> values [0,2].
> Each newly added device has a different angular velocity/linear
> acceleration/ delta velocity scale combination, as follows:
> Accel dynamic range sensitivity:
> - 262144000 LSB/g: ADIS16575
> - 52428800 LSB/g: ADIS16576, ADIS16577
> Gyro dynamic range sensitivity:
> - 2621440 LSB/deg/sec: ADIS1575-2, ADIS1576-2, ADIS1577-2
> - 655360 LSB/deg/sec: ADIS1575-3, ADIS1576-3, ADIS1577-3
> Delta velocity sensitivity:
> - 2^15/100 LSB/m/sec: ADIS16575
> - 2^15/125 LSB/m/sec: ADIS16576
> - 2^15/400 LSB/m/sec: ADIS16577
> Each ADIS1657X device supports FIFO usage and a sample-rate of 4.1KHz,
> meanwhile the already existing devices do not support FIFO usage and
> have a maximum sample-rate of 2.1KHz.
>=20
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> ---
> changes in v2:
>  - updated commit message stating the differences between the new added d=
evices
>  and existing ones supported by this driver

Thanks for that. Was much easier to understand this way than cross
checking a bunch of structs and the justification for how the bindings
look should be in the binding commit message anyway :)

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

--WpJ+I2U/bkBC8Ytu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZjuzywAKCRB4tDGHoIJi
0mehAQC8UPguZodr1irMCzp/fysIvK+krWOQqFCuTAdnBGW4xgD/ZrNfugE7vATt
GBNvkJhgirM/PqrQECwkgCA8q+RkMAs=
=vlxh
-----END PGP SIGNATURE-----

--WpJ+I2U/bkBC8Ytu--