Received-SPF: pass (google.com: domain of linux-kernel+bounces-173656-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240418155151.355133-1-ivitro@gmail.com> <20240508174048.GA5257@francesco-nb>
In-Reply-To: <20240508174048.GA5257@francesco-nb>
From: Adam Ford <aford173@gmail.com>
Date: Wed, 8 May 2024 12:43:38 -0500
Message-ID: <CAHCN7xLnSEPzvsWbm-+JquJrpOfMFwaE3Hd26Qhv_WqGaweUaA@mail.gmail.com>
Subject: Re: [PATCH v1] pmdomain: imx8m-blk-ctrl: fix suspend/resume order
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Vitor Soares <ivitro@gmail.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, 
	Vitor Soares <vitor.soares@toradex.com>, linux-pm@vger.kernel.org, imx@lists.linux.dev, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 
	stable@vger.kernel.org, Lucas Stach <l.stach@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 8, 2024 at 12:40=E2=80=AFPM Francesco Dolcini <francesco@dolcin=
i.it> wrote:
>
> On Thu, Apr 18, 2024 at 04:51:51PM +0100, Vitor Soares wrote:
> > From: Vitor Soares <vitor.soares@toradex.com>
> >
> > During the probe, the genpd power_dev is added to the dpm_list after
> > blk_ctrl due to its parent/child relationship. Making the blk_ctrl
> > suspend after and resume before the genpd power_dev.
> >
> > As a consequence, the system hangs when resuming the VPU due to the
> > power domain dependency.
> >
> > To ensure the proper suspend/resume order, add a device link betweem
> > blk_ctrl and genpd power_dev. It guarantees genpd power_dev is suspende=
d
> > after and resumed before blk-ctrl.
> >
>
> Cc: Adam Ford

Thanks!  This is what I was thinking from the other thread.  I just
didn't see this one.


adam
>
> Francesco
>